BZ1739420 - Clarify selector-label volume binding#20998
BZ1739420 - Clarify selector-label volume binding#20998bobfuru merged 2 commits intoopenshift:enterprise-3.11from
Conversation
There was a problem hiding this comment.
Is this the right placement for this optional step (between Define and Deploy)? Also, not certain that "when using a selector" is necessary here?
There was a problem hiding this comment.
The placement is OK, however, the heading does not match the content. Heading says that it's about label selectors, but the two solutions don't use selector at all.
There are two mixed topics:
- bind a PVC to a specific PV
- This can be done either by specifying pvc.spec.volumeName (when knowing the PV name) or using pvc.spec.selector (when knowing PV labels).
- reserve a PV to specific PVC (or namespace)
- This can be done by using a specific storage class or setting pv.spec.claimRef, as outlined correctly below.
I would not mix those in a single chapter.
|
@liangxia or @qinpingli PTAL |
|
@jkaurredhat PTAL |
|
@chao007 Could you help review this patch? |
There was a problem hiding this comment.
The placement is OK, however, the heading does not match the content. Heading says that it's about label selectors, but the two solutions don't use selector at all.
There are two mixed topics:
- bind a PVC to a specific PV
- This can be done either by specifying pvc.spec.volumeName (when knowing the PV name) or using pvc.spec.selector (when knowing PV labels).
- reserve a PV to specific PVC (or namespace)
- This can be done by using a specific storage class or setting pv.spec.claimRef, as outlined correctly below.
I would not mix those in a single chapter.
| If necessary in a multi-tenant environment, use a quota definition to reserve the storage class and PV(s) only to a specific namespace. | ||
| ==== | ||
|
|
||
| . Pre-bind the PV to your PVC using the PVC namespace and name. A PV defined as such will bind only to the specified PVC and to nothing else, as shown in the following example: |
There was a problem hiding this comment.
@chao007 - I dropped "namespace" from the subhead as you suggested, but is it okay to still have it "PVC namespace" here or should it also be removed?
|
lgtm |
|
@chao007 Can you please approve from QE side? |
|
@openshift/team-documentation PTAL |
bobfuru
added
the
peer-review-needed
|
LGTM |
bmcelvee
added
peer-review-done
|
LGTM. |
5 participants
BZ1739420
Doc bug asks to include optional steps for how to reserve a PV for specific tasks, as described in BZ1717746.
Applies to
enterprise-3.11only.