Skip to content

Issue fixes for #19438 and #19437#21008

Merged
mburke5678 merged 1 commit intoopenshift:masterfrom
abrennan89:issuefixes
Apr 9, 2020
Merged

Issue fixes for #19438 and #19437#21008
mburke5678 merged 1 commit intoopenshift:masterfrom
abrennan89:issuefixes

Conversation

@abrennan89
Copy link
Copy Markdown
Contributor

@abrennan89 abrennan89 commented Apr 8, 2020

Fixes #19437 and #19438

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 8, 2020
@openshift-docs-preview-bot
Copy link
Copy Markdown

openshift-docs-preview-bot commented Apr 8, 2020

The preview will be available shortly at:

mgencur
mgencur reviewed Apr 8, 2020
View reviewed changes
Comment thread modules/interacting-serverless-apps-http2-gRPC.adoc Outdated
@abrennan89 abrennan89 requested a review from mgencur April 8, 2020 20:06
@abrennan89
Copy link
Copy Markdown
Contributor Author

abrennan89 commented Apr 8, 2020

Thanks @mgencur - updated the example. This this should be OK for QE approval now?

@mgencur
Copy link
Copy Markdown
Contributor

mgencur commented Apr 8, 2020

Thanks.
QE Approved.

@mburke5678
Copy link
Copy Markdown
Contributor

mburke5678 commented Apr 8, 2020

@abrennan89 LGTM

@abrennan89
Copy link
Copy Markdown
Contributor Author

abrennan89 commented Apr 8, 2020

Thanks @mburke5678 - could go you ahead and merge this please? It applies for OCP 4.3 and will apply for 4.4 also.

@abrennan89 abrennan89 changed the title [WIP] Issue fixes for #19438 and #19437 Issue fixes for #19438 and #19437 Apr 8, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 8, 2020
@mburke5678 mburke5678 added this to the Next Release milestone Apr 9, 2020
@mburke5678 mburke5678 merged commit b86c59e into openshift:master Apr 9, 2020
@mburke5678
Copy link
Copy Markdown
Contributor

mburke5678 commented Apr 9, 2020

/cherrypick enterprise-4.3

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 9, 2020
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Apr 9, 2020

@mburke5678: new pull request created: #21053

Details

In response to this:

/cherrypick enterprise-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678
Copy link
Copy Markdown
Contributor

mburke5678 commented Apr 9, 2020

/cherrypick enterprise-4.4

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 9, 2020
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Apr 9, 2020

@mburke5678: new pull request created: #21054

Details

In response to this:

/cherrypick enterprise-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abrennan89 abrennan89 deleted the issuefixes branch June 10, 2020 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgencur mgencur Awaiting requested review from mgencur

Assignees

No one assigned

Labels

branch/enterprise-4.3 branch/enterprise-4.4

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

[enterprise-4.3] Edit suggested in file serverless/interacting-serverless-apps.adoc

6 participants

@abrennan89 @openshift-docs-preview-bot @mgencur @mburke5678 @openshift-cherrypick-robot @openshift-ci-robot