BZ1783437 - Add PVC to vSphere

[bobfuru]

Adds step to create PVC and reference volumeName as described in BZ1783437.

Preview build to static provisioning steps: https://bz1783437--ocpdocs.netlify.app/openshift-enterprise/latest/storage/persistent_storage/persistent-storage-vsphere.html#vsphere-static-provisioning_persistent-storage-efs

[bobfuru]

@liangxia or @qinpingli - PTAL

[openshift-docs-preview-bot]

The preview will be available shortly at:

• https://BZ1783437--ocpdocs.netlify.com/

[qinpingli]

@duanwei33 Please help take a look at this.

[duanwei33]

@bobfuru

1. The volume capacity size is not the same in PV(2Gi) and PVC(5Gi) definition.
2. For VMDKs creating, I see vSphere doc refer to govc and vmkfstools, I'm not familiar with the vmware-vdiskmanager command, how can we get the datastore name after this command, which will be used in PV creating?
3. For the command "$ vmkfstools -c /vmfs/volumes/DatastoreName/volumes/.vmdk", better to replace "DatastoreName" by "", or we can use the same name according the one PV used.

[bobfuru]

Thank you, @duanwei33. See my comments below:

1. The volume capacity size is not the same in PV(2Gi) and PVC(5Gi) definition.

Good catch. I changed capacity to 1Gi in both places to match another example on the page.

2. For VMDKs creating, I see vSphere doc refer to govc and vmkfstools, I'm not familiar with the vmware-vdiskmanager command, how can we get the datastore name after this command, which will be used in PV creating?

I'm also not familiar and did not take part in the original creation of this doc. IIUC, the user will only need to include [datastore-name] if they used the vmkfstools command. I made this more explicit in callout #4 by stating "If you used vmkfstools".

3. For the command "$ vmkfstools -c /vmfs/volumes/DatastoreName/volumes/.vmdk", better to replace "DatastoreName" by "", or we can use the same name according the one PV used.

I changed it to <datastore-name> to match the <disk-name> variable at the end of the command.

With these changes, does this look good to you?

[duanwei33]

@bobfuru Thanks for the update, it looks good to me.

[lamek]

LGTM

[bobfuru]

/cherrypick enterprise-4.5

[openshift-cherrypick-robot]

@bobfuru: new pull request created: #21917

Details

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[bobfuru]

/cherrypick enterprise-4.4

[bobfuru]

/cherrypick enterprise-4.3

[bobfuru]

/cherrypick enterprise-4.2

[openshift-cherrypick-robot]

@bobfuru: new pull request created: #21918

Details

In response to this:

/cherrypick enterprise-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@bobfuru: new pull request created: #21919

Details

In response to this:

/cherrypick enterprise-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@bobfuru: new pull request created: #21920

Details

In response to this:

/cherrypick enterprise-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.