Skip to content

feat(router): Adds documentation for haproxy.router.openshift.io/rewrite-target#22021

Merged
bmcelvee merged 1 commit intoopenshift:masterfrom
benoitf:OPENSHIFT_20474
Sep 28, 2020
Merged

feat(router): Adds documentation for haproxy.router.openshift.io/rewrite-target#22021
bmcelvee merged 1 commit intoopenshift:masterfrom
benoitf:OPENSHIFT_20474

Conversation

@benoitf
Copy link
Copy Markdown
Contributor

@benoitf benoitf commented May 12, 2020

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 12, 2020
@benoitf benoitf marked this pull request as draft May 12, 2020 12:41
This was referenced May 12, 2020
Closed
Closed
Merged
elafontaine
elafontaine reviewed May 14, 2020
View reviewed changes
Comment thread modules/nw-route-specific-annotations.adoc Outdated
@benoitf benoitf force-pushed the OPENSHIFT_20474 branch from c100dd5 to 1bdbc14 Compare May 14, 2020 05:55
@bmcelvee bmcelvee self-assigned this Jun 3, 2020
@benoitf benoitf marked this pull request as ready for review July 28, 2020 07:18
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 28, 2020
@benoitf benoitf changed the title [WIP] Adds documentation for haproxy.router.openshift.io/rewrite-target feat(router): Adds documentation for haproxy.router.openshift.io/rewrite-target Jul 28, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 28, 2020
Miciah
Miciah reviewed Jul 31, 2020
View reviewed changes
Comment thread modules/nw-route-specific-annotations.adoc Outdated
Comment thread modules/nw-route-specific-annotations.adoc Outdated
Comment thread modules/nw-route-specific-annotations.adoc Outdated
Comment thread modules/nw-route-specific-annotations.adoc Outdated
Comment thread modules/nw-route-specific-annotations.adoc Outdated
@benoitf
Copy link
Copy Markdown
Contributor Author

benoitf commented Aug 3, 2020

PR updated with feedback

Miciah
Miciah reviewed Aug 3, 2020
View reviewed changes
Comment thread modules/nw-route-specific-annotations.adoc Outdated
@Miciah
Copy link
Copy Markdown
Contributor

Miciah commented Aug 3, 2020

Many thanks!
/lgtm

@bmcelvee, the path-rewriting feature is new in 4.6. I don't believe any other documentation changes are needed for the feature. Is there anything left for engineering to do to move this PR along?

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2020
@bmcelvee bmcelvee added this to the Future Release milestone Sep 10, 2020
@bmcelvee
Copy link
Copy Markdown
Contributor

bmcelvee commented Sep 10, 2020

@benoitf thank you so much! The PR looks good to me. I only see one thing (missing period on "Sets / as rewrite path of the request on the backend), but I don't mind opening a follow-up PR to fix that.

@Miciah this is great, thank you! I just need to request QE review before I can merge, so I'll go ahead and do that now.

@quarterpin would you mind reviewing this PR please? Thank you!

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2020
@benoitf
Copy link
Copy Markdown
Contributor Author

benoitf commented Sep 11, 2020

@bmcelvee I've added the missing .

@bmcelvee
Copy link
Copy Markdown
Contributor

bmcelvee commented Sep 11, 2020

Thank you!

@Miciah
Copy link
Copy Markdown
Contributor

Miciah commented Sep 11, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2020
@bmcelvee
Copy link
Copy Markdown
Contributor

bmcelvee commented Sep 25, 2020

@quarterpin would you mind reviewing this PR please? Thank you!

@quarterpin
Copy link
Copy Markdown

quarterpin commented Sep 28, 2020

/lgtm

@bmcelvee bmcelvee merged commit 7c1bc8e into openshift:master Sep 28, 2020
@bmcelvee
Copy link
Copy Markdown
Contributor

bmcelvee commented Sep 28, 2020

/cherrypick enterprise-4.6

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 28, 2020
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Sep 28, 2020

@bmcelvee: new pull request created: #25832

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Miciah Miciah Miciah left review comments

@elafontaine elafontaine elafontaine left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Miciah Miciah

@bmcelvee bmcelvee

@quarterpin quarterpin

Labels

branch/enterprise-4.6 lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.6 GA

Development

Successfully merging this pull request may close these issues.

8 participants

@benoitf @Miciah @bmcelvee @quarterpin @openshift-cherrypick-robot @elafontaine @vikram-redhat @openshift-ci-robot