-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Edit section on daemonsets #2242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I was mistaken in my email convo with you. The related PR was only merged a month ago so it wouldn't have made the 3.2 cut. Apologies for that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'd make this a little more scary and recommend using the DC. We don't want to recommend running as a DaemonSet until the upstream work is completed.
|
@pweil- If this didn't make the 3.2 cut, when does that mean it will be released? Maybe it'd be a better idea to hold of on documenting this then if such things as the logging use case, as discussed in the BZ, are not too valid ATM. Thoughts? |
The command flag is merged for 3.3. My stance on this is that anywhere we document it needs to be followed with a note that says it isn't recommended just yet. I don't mind having the type documented so people know it's available for use but it comes with the burden of not having rolling updates. |
|
@pweil- OK. I think what's best is:
I've also changed the wording of this to more recommend-ey like you suggest above. Does that sound good to you? |
|
sounds good to me, thanks |
|
@pweil- Great. I'll do that. Thanks! |
|
@bfallonf Does this need a revhistory? |
|
@adellape it does! |
|
[rev_history] |
|
@bfallonf Need a |
@pweil- As discussed.
As it's still a WIP, and it's the only thing that's supported with Daemonsets, I can't think of a better place to put it. So I just gave your PR some more context.
However, is there any reason why my 3.2 install does not have the --daemonset option for the oadm registry command? Am I missing something?