Skip to content

Conversation

@bfallonf
Copy link

@bfallonf bfallonf commented Jun 9, 2016

@pweil- As discussed.

As it's still a WIP, and it's the only thing that's supported with Daemonsets, I can't think of a better place to put it. So I just gave your PR some more context.

However, is there any reason why my 3.2 install does not have the --daemonset option for the oadm registry command? Am I missing something?

@pweil-
Copy link

pweil- commented Jun 14, 2016

is there any reason why my 3.2 install does not have the ...

I was mistaken in my email convo with you. The related PR was only merged a month ago so it wouldn't have made the 3.2 cut. Apologies for that

openshift/origin#7596

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd make this a little more scary and recommend using the DC. We don't want to recommend running as a DaemonSet until the upstream work is completed.

@bfallonf
Copy link
Author

@pweil- If this didn't make the 3.2 cut, when does that mean it will be released? Maybe it'd be a better idea to hold of on documenting this then if such things as the logging use case, as discussed in the BZ, are not too valid ATM.

Thoughts?

@pweil-
Copy link

pweil- commented Jun 15, 2016

If this didn't make the 3.2 cut, when does that mean it will be released

The command flag is merged for 3.3. My stance on this is that anywhere we document it needs to be followed with a note that says it isn't recommended just yet. I don't mind having the type documented so people know it's available for use but it comes with the burden of not having rolling updates.

@bfallonf
Copy link
Author

@pweil- OK. I think what's best is:

  • Merge this so that the info is in upstream
  • Label this PR as 3.3
  • Keep looking at the Daemonsets work so that this stuff can be elaborated on for 3.3

I've also changed the wording of this to more recommend-ey like you suggest above.

Does that sound good to you?

@pweil-
Copy link

pweil- commented Jun 16, 2016

sounds good to me, thanks

@bfallonf
Copy link
Author

@pweil- Great. I'll do that. Thanks!

@bfallonf bfallonf added this to the Future Release milestone Jun 17, 2016
@bfallonf bfallonf merged commit 8853bc6 into openshift:master Jun 17, 2016
@bfallonf bfallonf changed the title [WIP] Edit section on daemonsets Edit section on daemonsets Jun 17, 2016
@adellape
Copy link
Contributor

@bfallonf Does this need a revhistory?

@bfallonf
Copy link
Author

@adellape it does!

@bfallonf
Copy link
Author

bfallonf commented Aug 29, 2016

[rev_history]
|xref:../install_config/install/docker_registry.adoc#install-config-install-docker-registry[Installing -> Deploying a Docker Registry]
|Added section on deploying the registry as a daemonset.
%

@adellape
Copy link
Contributor

@bfallonf Need a # anchor after the .adoc in the revhistory. 🐧

@vikram-redhat vikram-redhat modified the milestones: OCP 3.3 GA, TEMP Oct 7, 2016
@nak3 nak3 mentioned this pull request Nov 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants