Skip to content

Add details about GPU resources for Knative services#22791

Merged
bobfuru merged 1 commit intoopenshift:masterfrom
abrennan89:GPU
Jul 1, 2020
Merged

Add details about GPU resources for Knative services#22791
bobfuru merged 1 commit intoopenshift:masterfrom
abrennan89:GPU

Conversation

@abrennan89
Copy link
Copy Markdown
Contributor

@abrennan89 abrennan89 commented Jun 9, 2020

No description provided.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 9, 2020
@openshift-docs-preview-bot
Copy link
Copy Markdown

openshift-docs-preview-bot commented Jun 9, 2020

The preview will be available shortly at:

rhuss
rhuss suggested changes Jun 10, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! Added some question for some extra content, but not sure whether we can deliver this (at least not me ;-).

Comment thread _topic_map.yml Outdated
Comment thread serverless/integrations/gpu-resources.adoc Outdated
Comment thread serverless/integrations/gpu-resources.adoc Outdated
navidshaikh
navidshaikh reviewed Jun 10, 2020
View reviewed changes
Comment thread serverless/integrations/gpu-resources.adoc Outdated
Comment thread serverless/integrations/gpu-resources.adoc Outdated
Comment thread serverless/integrations/gpu-resources.adoc Outdated
Comment thread serverless/integrations/gpu-resources.adoc Outdated
Comment thread serverless/integrations/gpu-resources.adoc Outdated
Comment thread serverless/integrations/gpu-resources.adoc Outdated
Comment thread serverless/integrations/gpu-resources.adoc Outdated
@abrennan89 abrennan89 force-pushed the GPU branch 2 times, most recently from 6d0cb17 to 0745543 Compare June 10, 2020 14:39
@abrennan89
Copy link
Copy Markdown
Contributor Author

abrennan89 commented Jun 18, 2020

Something else I've noticed - the third party docs we link out to are only for 4.1/4.2/4.3 - will this be supported for 4.4, 4.5? @markito
Can we request updated docs from NVIDIA somehow or is this just not yet documented for 4.4, 4.5?
Since those will be our main supported versions for Serverless soon, I'd hold off adding this until it's available for them too.

mvinkler
mvinkler reviewed Jun 30, 2020
View reviewed changes
Comment thread serverless/integrations/gpu-resources.adoc Outdated
@mvinkler
Copy link
Copy Markdown

mvinkler commented Jun 30, 2020

QE approved

bobfuru
bobfuru reviewed Jun 30, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@bobfuru bobfuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions...after they are updated, this LGTM. I didn't add labels because it looks like you're still trying to determine those.

Comment thread serverless/integrations/gpu-resources.adoc Outdated
Comment thread serverless/integrations/gpu-resources.adoc Outdated
Comment thread serverless/integrations/gpu-resources.adoc Outdated
Comment thread serverless/integrations/gpu-resources.adoc Outdated
Comment thread serverless/integrations/gpu-resources.adoc Outdated
Comment thread serverless/integrations/gpu-resources.adoc Outdated
@bobfuru bobfuru added the peer-review-done Signifies that the peer review team has reviewed this PR label Jun 30, 2020
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 1, 2020
@abrennan89 abrennan89 changed the title [WIP] Add details about GPU resources for Knative services Add details about GPU resources for Knative services Jul 1, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 1, 2020
@abrennan89
Copy link
Copy Markdown
Contributor Author

abrennan89 commented Jul 1, 2020

Thanks so much for the review and great comments @bobfuru - this should be ready to merge now.
I've commented this out of the topic map for now since the --limit parts will be for a later Serverless release (1.9.0), cc @navidshaikh @markito
This I think only applies for OCP 4.5+ since our 1.8.0 release will be for OCP 4.5 only.

@bobfuru bobfuru added this to the Future Release milestone Jul 1, 2020
@bobfuru bobfuru merged commit e980f0e into openshift:master Jul 1, 2020
@bobfuru
Copy link
Copy Markdown
Contributor

bobfuru commented Jul 1, 2020

/cherrypick enterprise-4.5

@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Jul 1, 2020

@bobfuru: #22791 failed to apply on top of branch "enterprise-4.5":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	_topic_map.yml
Falling back to patching base and 3-way merge...
Auto-merging _topic_map.yml
CONFLICT (content): Merge conflict in _topic_map.yml
Patch failed at 0001 Add details about GPU resources for Knative services
Details

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bobfuru pushed a commit to bobfuru/openshift-docs that referenced this pull request Jul 1, 2020
Fix PR openshift#22791 in 4-5 for AB
4c5d29a
@bobfuru bobfuru mentioned this pull request Jul 1, 2020
Closed
abrennan89 added a commit to abrennan89/openshift-docs that referenced this pull request Jul 6, 2020
@abrennan89
Follow up fixes from openshift#22791
19d0559
bobfuru pushed a commit that referenced this pull request Jul 6, 2020
Merge pull request #23411 from abrennan89/gpu45
12b5576 
Follow up fixes from #22791
@yuvalk yuvalk mentioned this pull request Mar 18, 2021
Closed
@abrennan89 abrennan89 deleted the GPU branch December 17, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

5 more reviewers

@rhuss rhuss rhuss requested changes

@markito markito markito left review comments

@navidshaikh navidshaikh navidshaikh left review comments

@mvinkler mvinkler mvinkler left review comments

@bobfuru bobfuru bobfuru left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.5 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.5 GA

Development

Successfully merging this pull request may close these issues.

10 participants

@abrennan89 @openshift-docs-preview-bot @mvinkler @bobfuru @openshift-cherrypick-robot @rhuss @markito @navidshaikh @vikram-redhat @openshift-ci-robot