Skip to content

BZ1826292 - Add proc for configuring block storage in image registry#24043

Merged
bobfuru merged 1 commit intoopenshift:masterfrom
bobfuru:BZ1826292
Jul 24, 2020
Merged

BZ1826292 - Add proc for configuring block storage in image registry#24043
bobfuru merged 1 commit intoopenshift:masterfrom
bobfuru:BZ1826292

Conversation

@bobfuru
Copy link
Copy Markdown
Contributor

@bobfuru bobfuru commented Jul 21, 2020 •
edited
Loading

BZ1826292 - 4.4+. Adds instructions for configuring block storage type in image registry during upgrade for RWO access mode.

Preview links for impacted assemblies:

@bobfuru bobfuru added this to the Next Release milestone Jul 21, 2020
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 21, 2020
@openshift-docs-preview-bot
Copy link
Copy Markdown

openshift-docs-preview-bot commented Jul 22, 2020

The preview will be available shortly at:

@bobfuru bobfuru force-pushed the BZ1826292 branch 2 times, most recently from 43d3fd9 to 8fdeb7d Compare July 22, 2020 20:30
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 22, 2020
@bobfuru
Copy link
Copy Markdown
Contributor Author

bobfuru commented Jul 22, 2020

@bmcelvee PTAL and LMK if you think the block storage module doesn't belong in any of these assemblies. Thanks!

@bobfuru
Copy link
Copy Markdown
Contributor Author

bobfuru commented Jul 22, 2020

@jhou1 PTAL from QE perspective, thanks.

@bobfuru
Copy link
Copy Markdown
Contributor Author

bobfuru commented Jul 22, 2020

@adambkaplan PTAL - This documents the steps you outlined here: https://issues.redhat.com/browse/RFE-489?focusedCommentId=14099892&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14099892

@jhou1
Copy link
Copy Markdown

jhou1 commented Jul 23, 2020

@wzheng1 @qinpingli PTAL, thanks.

@wzheng1
Copy link
Copy Markdown

wzheng1 commented Jul 23, 2020

I am working on these doc reviews now. Thanks @jhou1

@wzheng1
Copy link
Copy Markdown

wzheng1 commented Jul 23, 2020

@bobfuru The docs look good to me, thanks!

@adambkaplan
Copy link
Copy Markdown
Contributor

adambkaplan commented Jul 23, 2020

/assign @dmage

/cc @bmcelvee

dmage
dmage reviewed Jul 23, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@dmage dmage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one note, otherwise looks good

Comment thread modules/installation-registry-storage-block-recreate-rollout.adoc Outdated
bmcelvee
bmcelvee reviewed Jul 23, 2020
View reviewed changes
Comment thread modules/installation-registry-storage-block-recreate-rollout.adoc Outdated
bmcelvee
bmcelvee reviewed Jul 23, 2020
View reviewed changes
Comment thread modules/installation-registry-storage-block-recreate-rollout.adoc Outdated
@bobfuru bobfuru force-pushed the BZ1826292 branch 2 times, most recently from 62ecc93 to b986fe9 Compare July 23, 2020 21:14
@bmcelvee bmcelvee added the peer-review-done Signifies that the peer review team has reviewed this PR label Jul 24, 2020
@bobfuru bobfuru merged commit 52b8746 into openshift:master Jul 24, 2020
@bobfuru
Copy link
Copy Markdown
Contributor Author

bobfuru commented Jul 24, 2020

/cherrypick enterprise-4.4

@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Jul 24, 2020

@bobfuru: #24043 failed to apply on top of branch "enterprise-4.4":

Details

In response to this:

/cherrypick enterprise-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bobfuru
Copy link
Copy Markdown
Contributor Author

bobfuru commented Jul 24, 2020

/cherrypick enterprise-4.5

@bobfuru
Copy link
Copy Markdown
Contributor Author

bobfuru commented Jul 24, 2020

/cherrypick enterprise-4.6

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 24, 2020
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Jul 24, 2020

@bobfuru: new pull request created: #24162

Details

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Jul 24, 2020

@bobfuru: new pull request created: #24163

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 24, 2020
Merged
bobfuru pushed a commit to bobfuru/openshift-docs that referenced this pull request Jul 24, 2020
CP of openshift#24043
5363724
This was referenced Jul 24, 2020
Closed
Merged
@bobfuru bobfuru mentioned this pull request Sep 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmcelvee bmcelvee bmcelvee left review comments

+1 more reviewer

@dmage dmage dmage left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@dmage dmage

Labels

branch/enterprise-4.4 branch/enterprise-4.5 branch/enterprise-4.6 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

9 participants

@bobfuru @openshift-docs-preview-bot @jhou1 @wzheng1 @adambkaplan @openshift-cherrypick-robot @dmage @bmcelvee @openshift-ci-robot