BZ1850510 - Update NFS registry storage docs by bobfuru · Pull Request #24276 · openshift/openshift-docs

bobfuru · 2020-07-28T20:16:30Z

BZ1850510 - Add link to Group IDs module for recommended info about using supplemental groups for NFS shared storage. And also update NFS example to use root_squash and no_wdelay. Applies to OCP 4.3+.

Preview links - step 2 note and example now include root_squash and supplemental group note is added in step 1:

openshift-docs-preview-bot · 2020-07-29T20:43:34Z

The preview will be available shortly at:

https://BZ1850510--ocpdocs.netlify.com/

bobfuru · 2020-07-29T21:10:56Z

@huffmanca - PTAL and let me know if this approach makes sense to you. Still not able to add xrefs within the module itself, so the best solution seemed to add the supplementalGroups info at the end of the bare metal reg config procedure as an important note. I've also added root_squash in step 2 for NFS. Thanks!

huffmanca

Overall it looks good, but I do have a couple of suggestions and nitpicks.

In addition, while this addresses the issues in the baremetal assembly, we need to make identical changes to the vsphere assembly as well.

bobfuru · 2020-07-30T18:47:49Z

Thanks, @huffmanca! Changes made, and I've also added the note to the vSphere assembly. Could you please take a second look?

huffmanca · 2020-07-30T19:28:56Z

Thanks for these changes!

/lgtm

bobfuru · 2020-07-30T19:33:02Z

@qinpingli - PTAL for QE review.

bobfuru · 2020-07-30T19:34:40Z

@openshift/team-documentation PTAL

ahardin-rh · 2020-07-30T19:39:26Z

LGTM 👍

openshift-ci-robot · 2020-07-31T18:12:25Z

New changes are detected. LGTM label has been removed.

qinpingli · 2020-08-03T01:07:59Z

@bobfuru Thanks for the update.

Now the patch lgtm.

bobfuru · 2020-08-04T21:06:10Z

/cherrypick enterprise-4.6

openshift-cherrypick-robot · 2020-08-04T21:06:53Z

@bobfuru: failed to push cherry-picked changes in GitHub: pushing failed, output: "To https://github.com/openshift-cherrypick-robot/openshift-docs\n ! [remote rejected] cherry-pick-24276-to-enterprise-4.6 -> cherry-pick-24276-to-enterprise-4.6 (cannot lock ref 'refs/heads/cherry-pick-24276-to-enterprise-4.6': reference already exists)\nerror: failed to push some refs to 'https://openshift-cherrypick-robot:CENSORED@github.com/openshift-cherrypick-robot/openshift-docs'\n", error: exit status 1

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2020-08-04T21:06:53Z

@bobfuru: new pull request created: #24458

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bobfuru · 2020-08-04T21:50:44Z

/cherrypick enterprise-4.5

openshift-cherrypick-robot · 2020-08-04T21:50:48Z

@bobfuru: #24276 failed to apply on top of branch "enterprise-4.5":

Details

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bobfuru · 2020-08-04T21:50:50Z

/cherrypick enterprise-4.4

openshift-cherrypick-robot · 2020-08-04T21:50:54Z

@bobfuru: #24276 failed to apply on top of branch "enterprise-4.4":

Details

In response to this:

/cherrypick enterprise-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bobfuru · 2020-08-04T21:50:55Z

/cherrypick enterprise-4.3

openshift-cherrypick-robot · 2020-08-04T21:50:58Z

@bobfuru: #24276 failed to apply on top of branch "enterprise-4.3":

Details

In response to this:

/cherrypick enterprise-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Cherry Picked 788ed2c from #24276 on 4-5

bobfuru added branch/enterprise-4.3 branch/enterprise-4.4 branch/enterprise-4.5 branch/enterprise-4.6 labels Jul 28, 2020

bobfuru added this to the Next Release milestone Jul 28, 2020

openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 28, 2020

bobfuru force-pushed the BZ1850510 branch 3 times, most recently from b4087b2 to 42018d7 Compare July 29, 2020 20:41

bobfuru force-pushed the BZ1850510 branch 2 times, most recently from 1c36bc7 to 2e22562 Compare July 29, 2020 21:06

openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 29, 2020

huffmanca reviewed Jul 30, 2020

View reviewed changes

Comment thread modules/registry-configuring-storage-baremetal.adoc Outdated

Comment thread registry/configuring_registry_storage/configuring-registry-storage-baremetal.adoc Outdated

bobfuru force-pushed the BZ1850510 branch from 2e22562 to 2a5c4cc Compare July 30, 2020 17:53

bobfuru force-pushed the BZ1850510 branch 2 times, most recently from c0c9de8 to d05031c Compare July 30, 2020 19:27

openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 30, 2020

openshift-ci-robot assigned huffmanca Jul 30, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2020

ahardin-rh added the peer-review-done Signifies that the peer review team has reviewed this PR label Jul 30, 2020

qinpingli reviewed Jul 31, 2020

View reviewed changes

Comment thread modules/registry-configuring-storage-vsphere.adoc Outdated

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2020

bobfuru force-pushed the BZ1850510 branch 3 times, most recently from 9a24af8 to acba120 Compare July 31, 2020 18:46

BZ1850510 - Update NFS registry storage docs

1d2203b

bobfuru force-pushed the BZ1850510 branch from acba120 to 1d2203b Compare August 3, 2020 16:42

bobfuru commented Aug 3, 2020

View reviewed changes

Comment thread modules/registry-configuring-storage-vsphere.adoc

bobfuru merged commit 788ed2c into openshift:master Aug 4, 2020

bobfuru deleted the BZ1850510 branch August 4, 2020 21:05

bobfuru restored the BZ1850510 branch August 4, 2020 21:05

openshift-cherrypick-robot mentioned this pull request Aug 4, 2020

[enterprise-4.6] BZ1850510 - Update NFS registry storage docs #24458

Merged

This was referenced Aug 4, 2020

Cherry Picked 788ed2c from PR24276 #24460

Merged

Cherry Picked 788ed2c from PR24276 #24459

Merged

Cherry Picked 788ed2c from PR 24276 #24462

Merged

bobfuru pushed a commit to bobfuru/openshift-docs that referenced this pull request Aug 5, 2020

Cherry Picked 788ed2c from openshift#24276 on 4-5

348b7c1

bobfuru mentioned this pull request Aug 5, 2020

Cherry Picked 788ed2c from #24276 on 4-5 #24493

Merged

bobfuru pushed a commit that referenced this pull request Aug 5, 2020

Merge pull request #24493 from bobfuru/BZ1850510-4-5

ef49ebe

Cherry Picked 788ed2c from #24276 on 4-5

bobfuru mentioned this pull request Aug 13, 2020

BZ1850510 - Update all_squash mount options #24800

Closed

bobfuru mentioned this pull request Sep 28, 2020

BZ1850510 - remove NFS from image reg docs #25826

Merged

Conversation

bobfuru commented Jul 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-docs-preview-bot commented Jul 29, 2020

Uh oh!

bobfuru commented Jul 29, 2020

Uh oh!

huffmanca left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bobfuru commented Jul 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

huffmanca commented Jul 30, 2020

Uh oh!

bobfuru commented Jul 30, 2020

Uh oh!

bobfuru commented Jul 30, 2020

Uh oh!

ahardin-rh commented Jul 30, 2020

Uh oh!

Uh oh!

openshift-ci-robot commented Jul 31, 2020

Uh oh!

qinpingli commented Aug 3, 2020

Uh oh!

Uh oh!

bobfuru commented Aug 4, 2020

Uh oh!

openshift-cherrypick-robot commented Aug 4, 2020

Uh oh!

openshift-cherrypick-robot commented Aug 4, 2020

Uh oh!

bobfuru commented Aug 4, 2020

Uh oh!

openshift-cherrypick-robot commented Aug 4, 2020

Uh oh!

bobfuru commented Aug 4, 2020

Uh oh!

openshift-cherrypick-robot commented Aug 4, 2020

Uh oh!

bobfuru commented Aug 4, 2020

Uh oh!

openshift-cherrypick-robot commented Aug 4, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

bobfuru commented Jul 28, 2020 •

edited

Loading

bobfuru commented Jul 30, 2020 •

edited

Loading