Updated bare metal install for coreos-installer by chrisnegus · Pull Request #25709 · openshift/openshift-docs

chrisnegus · 2020-09-23T00:50:56Z

Primarily addresses OSDOCS-1431, but also OSDOCS-1427, OSDOCS-1434, and OSDOCS-1440.

openshift-docs-preview-bot · 2020-09-23T01:59:51Z

The preview will be available shortly at:

https://OSDOCS-1431--ocpdocs.netlify.com/

vikram-redhat · 2020-09-23T02:10:42Z

@codyhoag to peer review this.

codyhoag · 2020-09-23T18:39:10Z

@chrisnegus a couple high level comments before diving in:

Is this information intended to cover the IPI steps for bare metal? All other installer sections have IPI/UPI docs in separate assemblies, whereas this PR combines them together. Since bare metal is a different beast, wasn't sure if they were combined for a reason? According to Installer team release information, bare metal UPI and IPI (new) are supported for OCP 4.6.
There are several procedures outlined in the new installation-user-infra-machines-advanced.adoc module. Those procedures need to be broken out into separate modules (one procedure per module).

As discussed, I'll dive in deeper after QE/SME reviews. Thanks!

chrisnegus · 2020-09-23T18:48:25Z

@codyhoag I can separate the procedures into different modules. Can you point me to the installer team release information about bare metal UPI and IPI?

codyhoag · 2020-09-23T19:10:27Z

@miabbott @jlebon @bgilbert can you review? Thanks!

bobfuru

Nicely done! 😎 I agree with @codyhoag that the procedures should be broken into separate modules, so let me know if that's something I can help you with. Most of my comments are either suggested rewording for readability and/or ISG matching, so you can take or leave a lot of it. 👍

bgilbert · 2020-10-01T17:26:55Z

This whole sentence seems misleading to me. I'm not sure what "identify artifacts to include" means, and the last two items imply a degree of support for partitioning and network setup that might be expected in traditional OS installers, when in fact our support is very limited. Rather than trying to list coreos-installer features here, I'd recast this to just say that you can manually run the installer from a shell prompt, passing it options to configure some details of the installed system.

bgilbert · 2020-10-01T18:56:10Z

We will probably not have a container for 4.6, but an RPM or coreos-installer binary that can be fetched from somewhere. Details are still being worked out.

bobfuru · 2020-10-02T18:22:32Z

/cherrypick enterprise-4.6

openshift-cherrypick-robot · 2020-10-02T18:22:36Z

@bobfuru: #25709 failed to apply on top of branch "enterprise-4.6":

Applying: Updated bare metal install for coreos-installer
.git/rebase-apply/patch:88: trailing whitespace.
configuration before installing the system. 
.git/rebase-apply/patch:102: trailing whitespace.
 
.git/rebase-apply/patch:106: trailing whitespace.
provide support for installation on disks with 4k sectors. 
.git/rebase-apply/patch:583: trailing whitespace.
. Review the “Advanced {op-system} bare metal installation configuration” 
warning: 4 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	modules/installation-user-infra-machines-pxe.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/installation-user-infra-machines-pxe.adoc
CONFLICT (content): Merge conflict in modules/installation-user-infra-machines-pxe.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Updated bare metal install for coreos-installer
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bobfuru · 2020-10-02T20:53:33Z

Merged #26091 to fix CP merge conflict.

bgilbert

It looks as though most of the comments on installation-user-infra-machines-advanced.adoc have not been addressed?

bgilbert · 2020-10-13T07:15:20Z

+which allows you to prepare the permanent system in a variety of ways
+before first boot. In particular, you can run the `coreos-installer`
+command to identify various artifacts to include, work with disk partitions,
+and set up networking. In some cases, you can configure features on


This text has also not been updated in a couple places.

bobfuru · 2020-10-14T02:21:34Z

I am hoping that the feedback that was missed in this PR has been addressed now in #26442.

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 23, 2020

vikram-redhat added the branch/enterprise-4.6 label Sep 23, 2020

vikram-redhat added this to the Future Release milestone Sep 23, 2020

vikram-redhat added the peer-review-needed Signifies that the peer review team needs to review this PR label Sep 23, 2020

Chris Negus added 2 commits September 23, 2020 08:04

Updated bare metal install for coreos-installer

a6b4495

Fixed small formatting error

60d11fc

codyhoag self-requested a review September 23, 2020 12:47

codyhoag requested review from bgilbert, jlebon and miabbott September 23, 2020 19:08

bobfuru mentioned this pull request Sep 25, 2020

OSDOCS-1496 - Advanced networking tables #25656

Merged

bobfuru reviewed Sep 25, 2020

View reviewed changes

bobfuru added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Sep 25, 2020

miabbott reviewed Sep 28, 2020

View reviewed changes

Comment thread installing/installing_bare_metal/installing-bare-metal.adoc Outdated

bobfuru mentioned this pull request Sep 30, 2020

Fixes to PR #25656 - applies SME feedback #26004

Merged

bgilbert reviewed Oct 1, 2020

View reviewed changes

bobfuru mentioned this pull request Oct 1, 2020

Fix merge conflict and apply SME feedback #26070

Merged

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 2, 2020

Chris Negus and others added 2 commits October 2, 2020 06:48

Incorporated comments to PR

447fdaf

Merge branch 'master' into OSDOCS-1431

a2ca7ba

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 2, 2020

bobfuru merged commit ec23526 into openshift:master Oct 2, 2020

bobfuru mentioned this pull request Oct 2, 2020

Fix 4.6 CP merge conflict in PR25709 #26091

Merged

bobfuru mentioned this pull request Oct 5, 2020

Fix 4.6 CP merge conflict in PR25709, PR26091 #26132

Merged

bgilbert reviewed Oct 13, 2020

View reviewed changes

bobfuru mentioned this pull request Oct 14, 2020

Add SME feedback to original PR#25709 #26442

Merged

vikram-redhat modified the milestones: Future Release, OCP 4.6 GA Oct 27, 2020

Conversation

chrisnegus commented Sep 23, 2020

Uh oh!

openshift-docs-preview-bot commented Sep 23, 2020

Uh oh!

vikram-redhat commented Sep 23, 2020

Uh oh!

codyhoag commented Sep 23, 2020

Uh oh!

chrisnegus commented Sep 23, 2020

Uh oh!

codyhoag commented Sep 23, 2020

Uh oh!

bobfuru left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bgilbert Oct 1, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bgilbert Oct 1, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bobfuru commented Oct 2, 2020

Uh oh!

openshift-cherrypick-robot commented Oct 2, 2020

Uh oh!

bobfuru commented Oct 2, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bgilbert left a comment

Choose a reason for hiding this comment

Uh oh!

bgilbert Oct 13, 2020

Choose a reason for hiding this comment

Uh oh!

bobfuru commented Oct 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants