New MCO post-install tasks section#25823
Merged
bobfuru merged 6 commits intoopenshift:masterfrom Oct 2, 2020
chrisnegus:mcotasks
Merged
New MCO post-install tasks section#25823bobfuru merged 6 commits intoopenshift:masterfrom chrisnegus:mcotasks
bobfuru merged 6 commits intoopenshift:masterfrom
chrisnegus:mcotasks
Conversation
openshift-ci-robot
added
the
size/XL
|
The preview will be available shortly at: |
bobfuru
requested review from
cgwalters,
kikisdeliveryservice and
yuqi-zhang
Contributor
|
@cgwalters, @yuqi-zhang, @kikisdeliveryservice - PTAL for technical review. I'm helping Chris get these docs over the finish line for OCP 4.6 Thanks! |
|
Will take a look, also cc @runcom |
kikisdeliveryservice
left a comment
kikisdeliveryservice
left a comment
There was a problem hiding this comment.
Some comments and I'm a little confused about what {product-title} is going to be in each of the files as it doesn't seem to be correct if it's OpenShift not RHCOS
bobfuru
reviewed
Sep 29, 2020
Contributor
bobfuru
left a comment
bobfuru
left a comment
There was a problem hiding this comment.
Mostly minor style suggestions and nitpicks. Great work!!
bobfuru
added
the
peer-review-done
chrisnegus
commented
Oct 2, 2020
Contributor
Author
chrisnegus
left a comment
chrisnegus
left a comment
There was a problem hiding this comment.
@bobfuru I've responded to all the comments. If it looks okay to you, I'm okay with you merging it.
Contributor
|
/cherrypick enterprise-4.6 |
|
@bobfuru: new pull request created: #26086 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes existing modules and creates some new modules that are all gathered together under a new "Machine configuration tasks" section of the "Post-installation configuration" left navigation.