Skip to content

4.6 OLM disconnected mirroring #26067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adellape merged 1 commit into from
Oct 13, 2020
Merged

4.6 OLM disconnected mirroring #26067

adellape merged 1 commit into from
Oct 13, 2020

Conversation

@adellape
Copy link
Contributor

@adellape adellape commented Oct 1, 2020 •
edited
Loading

@adellape adellape added this to the Future Release milestone Oct 1, 2020
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 1, 2020
@adellape adellape force-pushed the 46_disconnected branch 2 times, most recently from 1d5a4df to 9b5990f Compare October 7, 2020 02:34
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 7, 2020
@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 7, 2020
@adellape adellape force-pushed the 46_disconnected branch 10 times, most recently from 9a6fb30 to 9392bf2 Compare October 7, 2020 05:23
ecordell
ecordell reviewed Oct 8, 2020
View reviewed changes
ecordell
ecordell reviewed Oct 8, 2020
View reviewed changes
@adellape adellape mentioned this pull request Oct 9, 2020
Merged
@adellape adellape force-pushed the 46_disconnected branch 3 times, most recently from ea8901c to 94f4d50 Compare October 10, 2020 03:11
@openshift-docs-preview-bot
Copy link

openshift-docs-preview-bot commented Oct 10, 2020

The preview will be available shortly at:

@adellape adellape force-pushed the 46_disconnected branch 3 times, most recently from 05f4131 to 1c54dc2 Compare October 13, 2020 07:47
@adellape adellape added the peer-review-needed Signifies that the peer review team needs to review this PR label Oct 13, 2020
kuiwang02
kuiwang02 reviewed Oct 13, 2020
View reviewed changes
kuiwang02
kuiwang02 reviewed Oct 13, 2020
View reviewed changes
sfortner-RH
sfortner-RH suggested changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@sfortner-RH sfortner-RH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor style guide nits, but otherwise LGTM.

@adellape adellape force-pushed the 46_disconnected branch 2 times, most recently from 787f779 to 821cfc2 Compare October 13, 2020 17:24
@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 13, 2020
@adellape adellape force-pushed the 46_disconnected branch 7 times, most recently from 0bf78b3 to b75c228 Compare October 13, 2020 20:19
@adellape adellape added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Oct 13, 2020
@adellape adellape merged commit e5f373c into openshift:master Oct 13, 2020
@adellape adellape deleted the 46_disconnected branch October 13, 2020 20:48
@adellape
Copy link
Contributor Author

adellape commented Oct 13, 2020 •
edited by openshift-ci-robot
Loading

/cherrypick enterprise-4.6

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 13, 2020
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 13, 2020 •
edited by openshift-ci-robot
Loading

@adellape: new pull request created: #26430

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@ecordell ecordell ecordell left review comments

@kuiwang02 kuiwang02 kuiwang02 left review comments

@sfortner-RH sfortner-RH sfortner-RH requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kuiwang02 kuiwang02

Labels

branch/enterprise-4.6 peer-review-done Signifies that the peer review team has reviewed this PR size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.6 GA

Development

Successfully merging this pull request may close these issues.

9 participants

@adellape @openshift-docs-preview-bot @jianzhangbjz @openshift-cherrypick-robot @ecordell @kuiwang02 @sfortner-RH @vikram-redhat @openshift-ci-robot