Skip to content

fix vSphere MachineSet issue #27437#27438

Merged
codyhoag merged 1 commit intoopenshift:masterfrom
annelson-rh:patch-3
Nov 18, 2020
Merged

fix vSphere MachineSet issue #27437#27438
codyhoag merged 1 commit intoopenshift:masterfrom
annelson-rh:patch-3

Conversation

@annelson-rh
Copy link
Copy Markdown
Contributor

@annelson-rh annelson-rh commented Nov 17, 2020

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 17, 2020
@codyhoag codyhoag linked an issue Nov 17, 2020 that may be closed by this pull request
[enterprise-4.6] Issue in file machine_management/creating-infrastructure-machinesets.adoc #27437
Closed
@codyhoag codyhoag added this to the Next Release milestone Nov 17, 2020
@codyhoag
Copy link
Copy Markdown
Contributor

codyhoag commented Nov 17, 2020

@jinyunma can you confirm? Thanks!

@codyhoag codyhoag changed the title fix issue #27437 fix vSphere MachineSet issue #27437 Nov 17, 2020
@jinyunma
Copy link
Copy Markdown

jinyunma commented Nov 18, 2020 •
edited
Loading

@sunzhaohua2 could you help to review this PR? thanks.

@jinyunma
Copy link
Copy Markdown

jinyunma commented Nov 18, 2020

@miyadav could you please help to review this PR since Zhaohua is PTO this week? thanks.

@miyadav
Copy link
Copy Markdown
Member

miyadav commented Nov 18, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2020
@codyhoag codyhoag self-requested a review November 18, 2020 14:35
codyhoag
codyhoag approved these changes Nov 18, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@codyhoag codyhoag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built this locally and it looks good. Thanks @annelson-rh for the fix!

@codyhoag codyhoag merged commit 85e782f into openshift:master Nov 18, 2020
@codyhoag
Copy link
Copy Markdown
Contributor

codyhoag commented Nov 18, 2020 •
edited by openshift-ci-robot
Loading

/cherrypick enterprise-4.7

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 18, 2020
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Nov 18, 2020 •
edited by openshift-ci-robot
Loading

@codyhoag: new pull request created: #27474

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codyhoag
Copy link
Copy Markdown
Contributor

codyhoag commented Nov 18, 2020 •
edited by openshift-ci-robot
Loading

/cherrypick enterprise-4.6

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 18, 2020
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Nov 18, 2020 •
edited by openshift-ci-robot
Loading

@codyhoag: new pull request created: #27475

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codyhoag
Copy link
Copy Markdown
Contributor

codyhoag commented Nov 18, 2020 •
edited by openshift-ci-robot
Loading

/cherrypick enterprise-4.5

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 18, 2020
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Nov 18, 2020 •
edited by openshift-ci-robot
Loading

@codyhoag: new pull request created: #27476

Details

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@annelson-rh annelson-rh deleted the patch-3 branch November 18, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@codyhoag codyhoag codyhoag approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@miyadav miyadav

Labels

branch/enterprise-4.5 branch/enterprise-4.6 branch/enterprise-4.7 lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

[enterprise-4.6] Issue in file machine_management/creating-infrastructure-machinesets.adoc

6 participants

@annelson-rh @codyhoag @jinyunma @miyadav @openshift-cherrypick-robot @openshift-ci-robot