Avoid reboots in select cases by mburke5678 · Pull Request #28090 · openshift/openshift-docs

mburke5678 · 2020-12-14T16:48:37Z

https://issues.redhat.com/browse/OSDOCS-1645

mburke5678 · 2020-12-14T17:01:13Z

@yuqi-zhang Would you be the best person to review these doc changes?

yuqi-zhang

Generally I think we should specify that these are explicitly 4.7 specifically (or maybe implied is good enough?) and that they still disrupt your workloads due to the drain action. There just won't be a physical reboot.

yuqi-zhang · 2020-12-14T20:01:29Z

Perhaps we should specify specifically that:

as of 4.7, this change will no longer trigger a reboot (if no other changes were applied at the same time)

it will instead drain the nodes, apply the changes and reload crio.service on the host, and then uncordon

the /host/etc/containers/registries.conf is a bit odd, it should just be /etc/containers/registries.conf on the actual hosts. The only time you would see if in /host... is if you have a container that mounted the system root to /host (e.g. a debug container)

yuqi-zhang · 2020-12-14T20:01:52Z

Maybe should specify as of 4.7, this will not reboot

yuqi-zhang · 2020-12-14T20:03:09Z

... e.g. ICSP changes

@yuqi-zhang Thanks for the comments.
What is ICSP? ImageContentSourcePolicy?
We don't use that acronym in the docs apparently.

Ah sorry that would be imageContentSourcePolicy, e.g. here: https://docs.openshift.com/container-platform/4.6/updating/updating-restricted-network-cluster.html#images-configuration-registry-mirror_updating-restricted-network-cluster

i.e. if you create/update an imagecontentsourcepolicy object, it gets populated into a machineconfig. This was one of the asks from customers so I thought it might have made sense to explicitly list it here. I defer to your judgement on that though.

mburke5678 · 2020-12-15T19:55:46Z

Check reference in images-configuration-file.adoc

mburke5678 · 2020-12-17T16:21:15Z

mburke5678 · 2020-12-17T16:21:29Z

mike-nguyen · 2020-12-17T17:01:40Z

lgtm

mburke5678 · 2020-12-17T22:13:30Z

openshift-docs-preview-bot · 2020-12-18T15:28:01Z

The preview will be available shortly at:

https://mco-avoid-reboots--ocpdocs.netlify.com/

bmcelvee · 2020-12-18T19:46:58Z

Suggestions since this content was already in place :)

s/Machine Config Operator/Machine Config Operator (MCO)
s/CA/certificate authority (CA)

bmcelvee · 2020-12-18T19:47:26Z

I left a couple of small suggestions, otherwise LGTM!

mburke5678 · 2020-12-18T22:04:47Z

/cherrypick enterprise-4.7

openshift-cherrypick-robot · 2020-12-18T22:05:18Z

@mburke5678: new pull request created: #28251

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Adding MCO behavior changes from #28090

…-28388-to-enterprise-4.7 [enterprise-4.7] Adding MCO behavior changes from #28090

openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 14, 2020

mburke5678 added the branch/enterprise-4.7 label Dec 14, 2020

mburke5678 added this to the Future Release milestone Dec 14, 2020

yuqi-zhang reviewed Dec 14, 2020

View reviewed changes

openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 14, 2020

mburke5678 commented Dec 17, 2020

View reviewed changes

Comment thread modules/machine-config-overview.adoc Outdated

Copy link
Copy Markdown

Contributor Author

mburke5678 Dec 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed typo

mburke5678 commented Dec 17, 2020

View reviewed changes

Comment thread modules/nodes-pods-secrets-creating.adoc Outdated

Copy link
Copy Markdown

Contributor Author

mburke5678 Dec 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed typo

mburke5678 commented Dec 17, 2020

View reviewed changes

Comment thread modules/images-configuration-parameters.adoc Outdated

Copy link
Copy Markdown

Contributor Author

mburke5678 Dec 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed typo

mburke5678 force-pushed the mco-avoid-reboots branch from ed925d8 to 7aa09a6 Compare December 18, 2020 15:23

mburke5678 force-pushed the mco-avoid-reboots branch from 7aa09a6 to 83ca275 Compare December 18, 2020 19:05

bmcelvee reviewed Dec 18, 2020

View reviewed changes

bmcelvee added the peer-review-done Signifies that the peer review team has reviewed this PR label Dec 18, 2020

Avoid reboots in select cases

6497751

mburke5678 force-pushed the mco-avoid-reboots branch from 83ca275 to 6497751 Compare December 18, 2020 22:01

mburke5678 merged commit a8e4c4e into openshift:master Dec 18, 2020

mburke5678 deleted the mco-avoid-reboots branch December 18, 2020 22:04

openshift-cherrypick-robot mentioned this pull request Dec 18, 2020

[enterprise-4.7] Avoid reboots in select cases #28251

Merged

mburke5678 mentioned this pull request Dec 23, 2020

Reorganize Image configuration resources topic #28268

Merged

mburke5678 mentioned this pull request Jan 6, 2021

Adding MCO behavior changes from #28090 #28388

Merged

mburke5678 added a commit to mburke5678/openshift-docs that referenced this pull request Jan 6, 2021

Adding MCO behavior changes from openshift#28090

d7fdd3d

mburke5678 added a commit that referenced this pull request Jan 6, 2021

Merge pull request #28388 from mburke5678/mco-avoid-reboots-follow-up

ca4dac6

Adding MCO behavior changes from #28090

openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/openshift-docs that referenced this pull request Jan 6, 2021

Adding MCO behavior changes from openshift#28090

0de0d01

mburke5678 added a commit that referenced this pull request Jan 6, 2021

Merge pull request #28390 from openshift-cherrypick-robot/cherry-pick…

67f07e0

…-28388-to-enterprise-4.7 [enterprise-4.7] Adding MCO behavior changes from #28090

vikram-redhat modified the milestones: Future Release, OCP 4.7 GA Feb 24, 2021

yuvalk mentioned this pull request Mar 18, 2021

cnf 4.6 references #30640

Closed

mburke5678 mentioned this pull request Mar 22, 2023

Updating imagecontentsourcepolicy should not trigger a node drain #57440

Merged

1 task

Conversation

mburke5678 commented Dec 14, 2020

Uh oh!

mburke5678 commented Dec 14, 2020

Uh oh!

yuqi-zhang left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mburke5678 Dec 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mburke5678 commented Dec 15, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mike-nguyen commented Dec 17, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

openshift-docs-preview-bot commented Dec 18, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bmcelvee commented Dec 18, 2020

Uh oh!

mburke5678 commented Dec 18, 2020 • edited by openshift-ci-robot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-cherrypick-robot commented Dec 18, 2020 • edited by openshift-ci-robot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

mburke5678 Dec 14, 2020 •

edited

Loading

mburke5678 commented Dec 18, 2020 •

edited by openshift-ci-robot

Loading

openshift-cherrypick-robot commented Dec 18, 2020 •

edited by openshift-ci-robot

Loading