[OSP] MachineSet primary subnet support#28303
Merged
maxwelldb merged 8 commits intoopenshift:masterfrom Jan 18, 2021
Merged
Conversation
openshift-ci-robot
added
the
size/XS
|
The preview will be available shortly at:
|
maxwelldb
force-pushed
the
setting-osp-machine-subnet-osdocs1663
branch
from
3d6848c to
3a63e72
Compare
openshift-ci-robot
added
size/S
Contributor
Author
|
FYI @iamemilio |
maxwelldb
changed the title
Contributor
Author
|
Review URL is way wrong. TY, previewbot. |
|
lgtm |
Contributor
Author
|
TY! |
maxwelldb
force-pushed
the
setting-osp-machine-subnet-osdocs1663
branch
from
17ad430 to
4f28bf0
Compare
ghost
reviewed
Jan 8, 2021
maxwelldb
commented
Jan 8, 2021
|
LGTM |
Contributor
Author
|
Thanks! |
maxwelldb
added
the
peer-review-needed
Contributor
Author
|
@openshift/team-documentation PTAL when you have a moment. Thanks! |
kalexand-rh
reviewed
Jan 18, 2021
Contributor
kalexand-rh
left a comment
kalexand-rh
left a comment
There was a problem hiding this comment.
A few picky things, but it largely LGTM
kalexand-rh
added
peer-review-done
Co-authored-by: Kathryn Alexander <37149781+kalexand-rh@users.noreply.github.com>
Co-authored-by: Kathryn Alexander <37149781+kalexand-rh@users.noreply.github.com>
maxwelldb
commented
Jan 18, 2021
maxwelldb
commented
Jan 18, 2021
Contributor
Author
|
@kalexand-rh TY! |
maxwelldb
commented
Jan 18, 2021
openshift-ci-robot
added
size/M
openshift-ci-robot
added
size/S
Contributor
Author
|
/cherry-pick enterprise-4.7 |
|
@maxwelldb: new pull request created: #28663 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: https://issues.redhat.com/browse/OSDOCS-1663