CNV-9030 New UI for Virtual Machine Templates by lmandavi · Pull Request #28478 · openshift/openshift-docs

lmandavi · 2021-01-09T19:59:24Z

This PR is associated with CNV-9030. In the OpenShift Virtualization web console, a new UI has been introduced with major new features for virtual machine templates. We now provide preconfigured Red Hat templates for Linux, Windows, and Fedora. Users can open a preconfigured Red Hat template, customize it by adding a boot source, and create a customized template for creating multiple virtual machines.

The Templates tab lists all of the Red Hat templates and any custom templates created by users. Users have the flexibility to use either Red Hat templates or the interactive wizard to create virtual machine templates. By offering preconfigured Red Hat templates to our users, we make it easy for them to choose a template and quickly customize it for their needs.

Virtual machine templates provided by Red Hat cannot be edited or deleted. Users can, however, delete templates that they have created.

This new UI also impacts how our users use Red Hat templates to create virtual machines. The tasks applying to the creation of virtual machines by using Red Hat templates and custom templates are covered by a different Jira story that will be released for review when that PR is ready.

openshift-docs-preview-bot · 2021-01-09T20:02:51Z

The preview will be available shortly at:

https://CNV-9030-vm-templates--ocpdocs.netlify.com/

lmandavi · 2021-01-09T21:09:57Z

@jelkosz @yaacov
Requesting SME review and comments for this PR:

Creating virtual machine templates
https://cnv-9030-vm-templates--ocpdocs.netlify.app/openshift-enterprise/latest/virt/vm_templates/virt-creating-vm-template.html

Editing virtual machine templates
https://cnv-9030-vm-templates--ocpdocs.netlify.app/openshift-enterprise/latest/virt/vm_templates/virt-editing-vm-template.html

Enabling dedicated resources for virtual machines
https://cnv-9030-vm-templates--ocpdocs.netlify.app/openshift-enterprise/latest/virt/vm_templates/virt-dedicated-resources-vm-template.html

Deleting a virtual machine template
https://cnv-9030-vm-templates--ocpdocs.netlify.app/openshift-enterprise/latest/virt/vm_templates/virt-deleting-vm-template.html

For validating the doc content that I developed, I have used this build that Guohua has provided:

https://console-openshift-console.apps.uit02.cnv-qe.rhcloud.com/k8s/ns/openshift/virtualization

Please note that doc content for virtual machines will be provided through a different Jira story. This particular Jira story focuses only on virtual machine templates.

yaacov · 2021-01-10T19:06:13Z

LGTM

lmandavi · 2021-01-10T19:11:16Z

SME review was completed - many thanks to @yaacov for moving quickly with the SME review. @gouyang - requesting QE review.

gouyang · 2021-01-11T01:40:01Z

Some content on the preview page are not precisely any more, not sure whether it beyonds the PR. Just mention it here:

https://cnv-9030-vm-templates--ocpdocs.netlify.app/openshift-enterprise/latest/virt/vm_templates/virt-editing-vm-template.html#virt-vm-edit-cdrom_virt-editing-vm-template

CDROM is not available in VM/VM template any more, should remove the whole section

https://cnv-9030-vm-templates--ocpdocs.netlify.app/openshift-enterprise/latest/virt/vm_templates/virt-creating-vm-template.html#virt-vm-wizard-fields-web_virt-creating-vm-template

The bottom line of the table is missing.
Description of Persistent Volume Claim project is not correct

https://cnv-9030-vm-templates--ocpdocs.netlify.app/openshift-enterprise/latest/virt/vm_templates/virt-creating-vm-template.html#virt-cloud-init-fields-web_virt-creating-vm-template

Authenticated SSH Keys renamed to Authorized SSH Keys

lmandavi · 2021-01-11T16:04:57Z

@gouyang - Responding:

I will run the build again, so you can see the updated HTML content.
I am seeing CD-ROM in the VM Template screen, therefore I have retained the information about CD-ROM. See attached screenshot. (Also sent email to @yaacov and mentioning that I am seeing CD-ROM)
I am looking into fixing the bottom line for the table.
Please provide a correct description for Persistent Volume Claim project.

lmandavi · 2021-01-11T19:40:34Z

@gouyang I responded to your comments by email. CD-ROM stays in the Add source dialog. Please refer to my email and review the changes. Thanks, Lavanya

lmandavi · 2021-01-11T19:48:37Z

@gouyang This is the latest HTML content:
https://cnv-9030-vm-templates--ocpdocs.netlify.app/openshift-enterprise/latest/virt/vm_templates/virt-creating-vm-template.html

lmandavi · 2021-01-12T22:42:01Z

@gouyang Please review the doc content changes and advise if the changes look good for QE review completion.

gouyang · 2021-01-12T23:27:08Z

LGTM

lmandavi · 2021-01-13T21:51:06Z

@gouyang Please review and approve the minor changes. Thanks!

gouyang · 2021-01-14T00:01:11Z

LGTM

lmandavi · 2021-01-22T20:26:03Z

@yaacov @jelkosz I updated the topic heading to be: "Adding a boot source..." This was done to ensure that this was a generic topic that could be reused in our customer doc. Could you please review and approve. Thanks!

aburdenthehand

Some notes re: shared and conditionalised content.

aburdenthehand · 2021-01-28T10:44:22Z

This now means that this text only appears in the Template wizard field, which doesn't seem right ("Template from which to create the virtual machine").
However it also no longer seems relevant to the VM wizard fields due to the workflow change. If true, we can remove this entirely.

Template, Template provider, Template support - these 3 items display only if the user selects Create virtual Machine Template. Therefore, they are embedded within the conditional expressions.

aburdenthehand · 2021-01-28T10:56:43Z

These seem to be the only differences between the VM and the Template wizard fields - and they seem to be marked up correctly for conditionals - but this is now a separate module.
This means that the conditionals here aren't doing anything, but also we have two locations to update in the future.
I highly recommend not duplicating this table, but including these conditionalised rows in the virt-vm-wizard-felds-web.adoc
Again - the conditionals here look correct, so you should be able to just copy lines 30-43 and pasting them at line 30 in the virt-vm-wizard-fields-web.adoc <-- in fact it looks like lines 30-34 are already there ready to go.

Updated virt-vm-wizard-fields-web.adoc and adding it to the assembly. Removing virt-vm-template-wizard-fields-web.adoc.

lmandavi · 2021-01-28T22:28:14Z

@aburdenthehand - please review the conditionals. Thanks.

CNV-9030 New UI for Virtual Machine Templates interactive and panes

sjhala-ccs · 2021-01-29T19:26:02Z

/cherrypick enterprise-4.7

openshift-cherrypick-robot · 2021-01-29T19:26:18Z

@sjhala-ccs: new pull request created: #28976

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

… like this was added in openshift#28478

openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 9, 2021

yaacov reviewed Jan 10, 2021

View reviewed changes

Comment thread modules/virt-creating-template-redhat-web.adoc Outdated

yaacov reviewed Jan 10, 2021

View reviewed changes

Comment thread modules/virt-template-fields-for-boot-source.adoc Outdated

yaacov reviewed Jan 10, 2021

View reviewed changes

Comment thread modules/virt-understanding-vm-templates.adoc Outdated

lmandavi force-pushed the CNV-9030-vm-templates branch from 7d14ae5 to 62133b7 Compare January 10, 2021 18:56

gouyang reviewed Jan 11, 2021

View reviewed changes

Comment thread modules/virt-creating-template-wizard-web.adoc Outdated

Comment thread modules/virt-template-fields-for-boot-source.adoc Outdated

Comment thread modules/virt-template-fields-for-boot-source.adoc Outdated

Comment thread modules/virt-creating-template-redhat-web.adoc Outdated

lmandavi force-pushed the CNV-9030-vm-templates branch from 62133b7 to 488af92 Compare January 11, 2021 16:23

aburdenthehand reviewed Jan 11, 2021

View reviewed changes

Comment thread modules/virt-add-disk-to-vm.adoc Outdated

lmandavi force-pushed the CNV-9030-vm-templates branch from 488af92 to 58c0aae Compare January 11, 2021 19:07

lmandavi force-pushed the CNV-9030-vm-templates branch from 58c0aae to eafc746 Compare January 11, 2021 19:42

gouyang reviewed Jan 12, 2021

View reviewed changes

Comment thread modules/virt-template-fields-for-boot-source.adoc Outdated

Comment thread modules/virt-vm-wizard-fields-web.adoc Outdated

lmandavi force-pushed the CNV-9030-vm-templates branch from eafc746 to 9cd7d86 Compare January 12, 2021 15:59

lmandavi force-pushed the CNV-9030-vm-templates branch from 9cd7d86 to 16ee81e Compare January 13, 2021 21:40

lmandavi force-pushed the CNV-9030-vm-templates branch from 16ee81e to 5413b55 Compare January 14, 2021 15:27

lmandavi force-pushed the CNV-9030-vm-templates branch 2 times, most recently from 1ded0f9 to 55039b1 Compare January 22, 2021 18:23

lmandavi force-pushed the CNV-9030-vm-templates branch from 55039b1 to 23c1f12 Compare January 23, 2021 21:57

sjhala-ccs added the peer-review-done Signifies that the peer review team has reviewed this PR label Jan 27, 2021

aburdenthehand reviewed Jan 28, 2021

View reviewed changes

Comment thread modules/virt-vm-wizard-fields-web.adoc Outdated

aburdenthehand reviewed Jan 28, 2021

View reviewed changes

lmandavi force-pushed the CNV-9030-vm-templates branch 3 times, most recently from d0f6200 to e5b9a94 Compare January 28, 2021 22:24

lmandavi force-pushed the CNV-9030-vm-templates branch 8 times, most recently from f17861d to f6ecb08 Compare January 29, 2021 19:07

openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 29, 2021

CNV-9030 New UI for Virtual Machine Templates

ecae03e

CNV-9030 New UI for Virtual Machine Templates interactive and panes

lmandavi force-pushed the CNV-9030-vm-templates branch from f6ecb08 to ecae03e Compare January 29, 2021 19:17

sjhala-ccs merged commit 4451682 into openshift:master Jan 29, 2021

openshift-cherrypick-robot mentioned this pull request Jan 29, 2021

[enterprise-4.7] CNV-9030 New UI for Virtual Machine Templates #28976

Merged

aburdenthehand added a commit to aburdenthehand/openshift-docs that referenced this pull request Feb 12, 2021

Removing unused template wizard file to avoid future confusion. Looks…

2f856e8

… like this was added in openshift#28478

aburdenthehand mentioned this pull request Feb 12, 2021

CNV - removing unused virt-removing-template-wizard.adoc #29453

Merged

openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/openshift-docs that referenced this pull request Feb 15, 2021

Removing unused template wizard file to avoid future confusion. Looks…

dadb897

… like this was added in openshift#28478

vikram-redhat modified the milestones: Future Release, OCP 4.7 GA Feb 24, 2021

yuvalk mentioned this pull request Mar 18, 2021

cnf 4.6 references #30640

Closed

Conversation

lmandavi commented Jan 9, 2021 • edited by openshift-ci-robot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-docs-preview-bot commented Jan 9, 2021

Uh oh!

lmandavi commented Jan 9, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yaacov commented Jan 10, 2021

Uh oh!

lmandavi commented Jan 10, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gouyang commented Jan 11, 2021

Uh oh!

lmandavi commented Jan 11, 2021

Uh oh!

Uh oh!

lmandavi commented Jan 11, 2021

Uh oh!

lmandavi commented Jan 11, 2021

Uh oh!

Uh oh!

Uh oh!

lmandavi commented Jan 12, 2021

Uh oh!

gouyang commented Jan 12, 2021

Uh oh!

lmandavi commented Jan 13, 2021

Uh oh!

gouyang commented Jan 14, 2021

Uh oh!

lmandavi commented Jan 22, 2021

Uh oh!

Uh oh!

aburdenthehand left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aburdenthehand Jan 28, 2021

Choose a reason for hiding this comment

Uh oh!

lmandavi Jan 28, 2021

Choose a reason for hiding this comment

Uh oh!

aburdenthehand Jan 28, 2021

Choose a reason for hiding this comment

Uh oh!

lmandavi Jan 28, 2021

Choose a reason for hiding this comment

Uh oh!

lmandavi commented Jan 28, 2021

Uh oh!

sjhala-ccs commented Jan 29, 2021 • edited by openshift-ci-robot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-cherrypick-robot commented Jan 29, 2021 • edited by openshift-ci-robot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

lmandavi commented Jan 9, 2021 •

edited by openshift-ci-robot

Loading

sjhala-ccs commented Jan 29, 2021 •

edited by openshift-ci-robot

Loading

openshift-cherrypick-robot commented Jan 29, 2021 •

edited by openshift-ci-robot

Loading