Skip to content

Update migration-controller SCC on OCP3.10/earlier (1.4.0)#28993

Merged
apinnick merged 1 commit intoopenshift:masterfrom
apinnick:bz1921559-mtc-ocp3-upgrade-set-scc
Feb 1, 2021
Merged

Update migration-controller SCC on OCP3.10/earlier (1.4.0)#28993
apinnick merged 1 commit intoopenshift:masterfrom
apinnick:bz1921559-mtc-ocp3-upgrade-set-scc

Conversation

@apinnick
Copy link
Copy Markdown
Contributor

@apinnick apinnick commented Jan 31, 2021

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 31, 2021
@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 31, 2021 •
edited
Loading

Deploy preview for osdocs ready!

Built with commit edcf7c9

https://deploy-preview-28993--osdocs.netlify.app

shawn-hurley
shawn-hurley reviewed Feb 1, 2021
View reviewed changes
Copy link
Copy Markdown

@shawn-hurley shawn-hurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if migration-controller might be confusing so we should add that it is the service account?

Comment thread modules/migration-upgrading-migration-tool-3.adoc Outdated
Comment thread modules/migration-upgrading-migration-tool-3.adoc Outdated
@apinnick apinnick force-pushed the bz1921559-mtc-ocp3-upgrade-set-scc branch from 0ba7087 to edcf7c9 Compare February 1, 2021 13:49
sergiordlr
sergiordlr approved these changes Feb 1, 2021
View reviewed changes
Copy link
Copy Markdown

@sergiordlr sergiordlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Thank you very much!

@apinnick apinnick marked this pull request as ready for review February 1, 2021 14:57
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 1, 2021
@apinnick apinnick added branch/enterprise-4.5 branch/enterprise-4.6 branch/enterprise-4.7 peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 1, 2021
@apinnick apinnick added this to the Next Release milestone Feb 1, 2021
jeana-redhat
jeana-redhat approved these changes Feb 1, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeana-redhat jeana-redhat added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 1, 2021
@apinnick apinnick merged commit 5568c6c into openshift:master Feb 1, 2021
@apinnick apinnick deleted the bz1921559-mtc-ocp3-upgrade-set-scc branch February 1, 2021 15:06
@apinnick
Copy link
Copy Markdown
Contributor Author

apinnick commented Feb 1, 2021 •
edited by openshift-ci-robot
Loading

/cherrypick enterprise-4.7

@apinnick
Copy link
Copy Markdown
Contributor Author

apinnick commented Feb 1, 2021 •
edited by openshift-ci-robot
Loading

/cherrypick enterprise-4.6

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 1, 2021
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Feb 1, 2021 •
edited by openshift-ci-robot
Loading

@apinnick: new pull request created: #29005

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@apinnick
Copy link
Copy Markdown
Contributor Author

apinnick commented Feb 1, 2021 •
edited by openshift-ci-robot
Loading

/cherrypick enterprise-4.5

@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Feb 1, 2021 •
edited by openshift-ci-robot
Loading

@apinnick: new pull request created: #29006

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Feb 1, 2021
Merged
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Feb 1, 2021 •
edited by openshift-ci-robot
Loading

@apinnick: new pull request created: #29007

Details

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeana-redhat jeana-redhat jeana-redhat approved these changes

+2 more reviewers

@shawn-hurley shawn-hurley shawn-hurley approved these changes

@sergiordlr sergiordlr sergiordlr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.5 branch/enterprise-4.6 branch/enterprise-4.7 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

6 participants

@apinnick @openshift-cherrypick-robot @shawn-hurley @sergiordlr @jeana-redhat @openshift-ci-robot