Skip to content

sr-iov related to RHOSP (SDN-1170)#29024

Merged
jboxman merged 1 commit intoopenshift:masterfrom
mikemckiernan:sriov-shift-on-stack
Feb 9, 2021
Merged

sr-iov related to RHOSP (SDN-1170)#29024
jboxman merged 1 commit intoopenshift:masterfrom
mikemckiernan:sriov-shift-on-stack

Conversation

@mikemckiernan
Copy link
Copy Markdown

@mikemckiernan mikemckiernan commented Feb 1, 2021

  • Original PR from Zenghui.
  • Updates to terminology.
  • Feedback from Aaron about nicSelector hierarchy.

This is a followup PR to #28418.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 1, 2021
@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 1, 2021 •
edited
Loading

Deploy preview for osdocs ready!

Built with commit bd031e3

https://deploy-preview-29024--osdocs.netlify.app

@mikemckiernan
Copy link
Copy Markdown
Author

mikemckiernan commented Feb 1, 2021

@jboxman, @atyronesmith, @zshi-redhat , this is a followup PR to Zenghui's work. PTAL.

Jason, can you add branch/enterprise-4.7 and Future-Release labels?

@jboxman jboxman added this to the Future Release milestone Feb 1, 2021
zshi-redhat
zshi-redhat reviewed Feb 2, 2021
View reviewed changes
Comment thread modules/nw-sriov-networknodepolicy-object.adoc Outdated
@mikemckiernan
Copy link
Copy Markdown
Author

mikemckiernan commented Feb 8, 2021

@openshift/team-documention, PTAL. I favored general reference format for the API objects instead of the object reference format--please let me know if I poisoned it.

jboxman
jboxman reviewed Feb 8, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@jboxman jboxman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments for review.

Comment thread modules/nw-sriov-networknodepolicy-object.adoc Outdated
Comment thread modules/nw-sriov-networknodepolicy-object.adoc Outdated
Comment thread modules/nw-sriov-networknodepolicy-object.adoc Outdated
Comment thread modules/nw-sriov-networknodepolicy-object.adoc Outdated
@jboxman jboxman added the peer-review-done Signifies that the peer review team has reviewed this PR label Feb 8, 2021
sr-iov related to RHOSP (SDN-1170)
bd031e3 
* Original PR from Zenghui.
* Updates to terminology.
* Feedback from Aaron about nicSelector hierarchy.
* Typo for InfiniBand.
* Favor general references for API objects.
* Review from Jason.
@jboxman jboxman merged commit 8f56e8a into openshift:master Feb 9, 2021
@jboxman
Copy link
Copy Markdown
Contributor

jboxman commented Feb 9, 2021

/cherry-pick enterprise-4.7

@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Feb 9, 2021

@jboxman: new pull request created: #29319

Details

In response to this:

/cherry-pick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@jboxman jboxman jboxman left review comments

@zshi-redhat zshi-redhat zshi-redhat left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mikemckiernan mikemckiernan

Labels

branch/enterprise-4.7 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.7 GA

Development

Successfully merging this pull request may close these issues.

6 participants

@mikemckiernan @jboxman @openshift-cherrypick-robot @zshi-redhat @vikram-redhat @openshift-ci-robot