Skip to content

For global proxy noProxy can be ignored#29093

Merged
jboxman merged 1 commit intoopenshift:masterfrom
jboxman-rh:gh-28782
Mar 5, 2021
Merged

For global proxy noProxy can be ignored#29093
jboxman merged 1 commit intoopenshift:masterfrom
jboxman-rh:gh-28782

Conversation

@jboxman
Copy link
Copy Markdown
Contributor

@jboxman jboxman commented Feb 3, 2021 •
edited
Loading

Preview: Enabling the cluster-wide proxy

Change:

This field is ignored if neither the httpProxy or httpsProxy fields are set.

@jboxman jboxman added this to the Next Release milestone Feb 3, 2021
@jboxman jboxman self-assigned this Feb 3, 2021
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 3, 2021
@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 3, 2021 •
edited
Loading

Deploy preview for osdocs ready!

Built with commit da18f8c

https://deploy-preview-29093--osdocs.netlify.app

@sgreene570
Copy link
Copy Markdown

sgreene570 commented Mar 2, 2021

LGTM

@jboxman jboxman added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 3, 2021
codyhoag
codyhoag reviewed Mar 3, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@codyhoag codyhoag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some inconsistent rendering issues I've noted. Otherwise, the looks good!

Comment thread modules/nw-proxy-configure-object.adoc
@codyhoag codyhoag added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 3, 2021
@jboxman jboxman merged commit 1e2b864 into openshift:master Mar 5, 2021
@jboxman jboxman deleted the gh-28782 branch March 5, 2021 03:13
@jboxman
Copy link
Copy Markdown
Contributor Author

jboxman commented Mar 5, 2021

/cherry-pick enterprise-4.8

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 5, 2021
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Mar 5, 2021

@jboxman: new pull request created: #30138

Details

In response to this:

/cherry-pick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jboxman
Copy link
Copy Markdown
Contributor Author

jboxman commented Mar 5, 2021

/cherry-pick enterprise-4.7

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 5, 2021
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Mar 5, 2021

@jboxman: new pull request created: #30139

Details

In response to this:

/cherry-pick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jboxman
Copy link
Copy Markdown
Contributor Author

jboxman commented Mar 5, 2021

/cherry-pick enterprise-4.6

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 5, 2021
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Mar 5, 2021

@jboxman: new pull request created: #30140

Details

In response to this:

/cherry-pick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jboxman
Copy link
Copy Markdown
Contributor Author

jboxman commented Mar 5, 2021

/cherry-pick enterprise-4.5

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 5, 2021
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Mar 5, 2021

@jboxman: new pull request created: #30141

Details

In response to this:

/cherry-pick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@codyhoag codyhoag codyhoag left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jboxman jboxman

Labels

branch/enterprise-4.5 branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

5 participants

@jboxman @sgreene570 @openshift-cherrypick-robot @codyhoag @openshift-ci-robot