Skip to content

Highlight relantionship between defaultNodeSelector and pod's nodeSelector#29102

Merged
mburke5678 merged 1 commit intoopenshift:masterfrom
mburke5678:BZ-1846671
Mar 4, 2021
Merged

Highlight relantionship between defaultNodeSelector and pod's nodeSelector#29102
mburke5678 merged 1 commit intoopenshift:masterfrom
mburke5678:BZ-1846671

Conversation

@mburke5678
Copy link
Copy Markdown
Contributor

@mburke5678 mburke5678 added this to the Next Release milestone Feb 3, 2021
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 3, 2021
@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 3, 2021

Deploy preview for osdocs ready!

Built with commit bd21c80

https://deploy-preview-29102--osdocs.netlify.app

@mburke5678
Copy link
Copy Markdown
Contributor Author

@kasturinarra Is this an issue that you can review for QE?

@kasturinarra
Copy link
Copy Markdown

@mburke5678 sure, would it be okay if i can check this on thursday as i am attending training till tomorrow ? Thanks !! Please let me know if it is urgent, i will take some time out, thanks !!

@kasturinarra
Copy link
Copy Markdown

@mburke5678 looks good to me, thanks !!

@kasturinarra
Copy link
Copy Markdown

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2021
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be out of scope for this PR since it's existing content (your call! 🙂 ) but suggested change:

<2> Optional: Specify

@bmcelvee bmcelvee added the peer-review-done Signifies that the peer review team has reviewed this PR label Mar 4, 2021
@bmcelvee
Copy link
Copy Markdown
Contributor

bmcelvee commented Mar 4, 2021

LGTM!

One possibly-out-of-scope suggestion and a reminder to squash commits. 🌞

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2021
@openshift-ci-robot
Copy link
Copy Markdown

New changes are detected. LGTM label has been removed.

@mburke5678 mburke5678 merged commit e088215 into openshift:master Mar 4, 2021
@mburke5678 mburke5678 deleted the BZ-1846671 branch March 4, 2021 14:06
@mburke5678
Copy link
Copy Markdown
Contributor Author

/cherrypick enterprise-4.5

@openshift-cherrypick-robot
Copy link
Copy Markdown

@mburke5678: new pull request created: #30102

Details

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678
Copy link
Copy Markdown
Contributor Author

/cherrypick enterprise-4.6

@mburke5678
Copy link
Copy Markdown
Contributor Author

/cherrypick enterprise-4.7

@mburke5678
Copy link
Copy Markdown
Contributor Author

/cherrypick enterprise-4.8

@openshift-cherrypick-robot
Copy link
Copy Markdown

@mburke5678: new pull request created: #30103

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@mburke5678: new pull request created: #30107

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@mburke5678: new pull request created: #30108

Details

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.5 branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants