Skip to content

Compatibility and firmware requirements.#29321

Merged
ahardin-rh merged 1 commit intoopenshift:masterfrom
johnwilkins:knideploy-2088
Feb 10, 2021
Merged

Compatibility and firmware requirements.#29321
ahardin-rh merged 1 commit intoopenshift:masterfrom
johnwilkins:knideploy-2088

Conversation

@johnwilkins
Copy link
Copy Markdown
Contributor

@johnwilkins johnwilkins commented Feb 9, 2021 •
edited by openshift-ci-robot
Loading

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 9, 2021
@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 9, 2021 •
edited
Loading

Deploy preview for osdocs ready!

Built with commit 1bff817

https://deploy-preview-29321--osdocs.netlify.app

iurygregory
iurygregory reviewed Feb 10, 2021
View reviewed changes
Comment thread modules/ipi-install-firmware-requirements-for-installing-with-virtual-media.adoc Outdated
iurygregory
iurygregory approved these changes Feb 10, 2021
View reviewed changes
Copy link
Copy Markdown

@iurygregory iurygregory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Ty!

@ahardin-rh ahardin-rh self-assigned this Feb 10, 2021
ahardin-rh
ahardin-rh reviewed Feb 10, 2021
View reviewed changes
Comment thread modules/ipi-install-bmc-addressing.adoc Outdated
ahardin-rh
ahardin-rh reviewed Feb 10, 2021
View reviewed changes
Comment thread modules/ipi-install-bmc-addressing.adoc Outdated
ahardin-rh
ahardin-rh reviewed Feb 10, 2021
View reviewed changes
Comment thread modules/ipi-install-creating-a-disconnected-registry.adoc Outdated
ahardin-rh
ahardin-rh reviewed Feb 10, 2021
View reviewed changes
Comment thread modules/ipi-install-firmware-requirements-for-installing-with-virtual-media.adoc Outdated
@ahardin-rh ahardin-rh added peer-review-done Signifies that the peer review team has reviewed this PR telco Label for all Telco PRs labels Feb 10, 2021
@ahardin-rh ahardin-rh added this to the Future Release milestone Feb 10, 2021
@ahardin-rh
Copy link
Copy Markdown
Contributor

ahardin-rh commented Feb 10, 2021

@iurygregory Is this work targeting 4.7 or 4.8? I notice that the associated JIRAs are for 4.8 so just want to confirm before merging. Thanks!

@iurygregory
Copy link
Copy Markdown

iurygregory commented Feb 10, 2021

@ahardin-rh we need this documentation in 4.7, we will have code to verify the support for virtual media in 4.8. I think we will also need the information about firmware in 4.6 docs, because virtual media support was added in 4.6

@ahardin-rh
Copy link
Copy Markdown
Contributor

ahardin-rh commented Feb 10, 2021

Thank you!

@ahardin-rh
Copy link
Copy Markdown
Contributor

ahardin-rh commented Feb 10, 2021

@johnwilkins You might need to look into what content needs backported to 4.6 based off of Iury's comment above. I will get this in for 4.7. Than you, all!

@ahardin-rh ahardin-rh merged commit 75418cf into openshift:master Feb 10, 2021
@ahardin-rh
Copy link
Copy Markdown
Contributor

ahardin-rh commented Feb 10, 2021

/cherrypick enterprise-4.7

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 10, 2021
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Feb 10, 2021

@ahardin-rh: new pull request created: #29387

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@johnwilkins johnwilkins deleted the knideploy-2088 branch May 18, 2021 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahardin-rh ahardin-rh ahardin-rh left review comments

+1 more reviewer

@iurygregory iurygregory iurygregory approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ahardin-rh ahardin-rh

Labels

branch/enterprise-4.7 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files. telco Label for all Telco PRs

Projects

None yet

Milestone

OCP 4.7 GA

Development

Successfully merging this pull request may close these issues.

6 participants

@johnwilkins @ahardin-rh @iurygregory @openshift-cherrypick-robot @vikram-redhat @openshift-ci-robot