Skip to content

RHDEVDOCS-2604 Wrong value and definition for legacy syslog hostname#29385

Merged
ahardin-rh merged 1 commit intoopenshift:masterfrom
rolfedh:RHDEVDOCS-2604
Feb 24, 2021
Merged

RHDEVDOCS-2604 Wrong value and definition for legacy syslog hostname#29385
ahardin-rh merged 1 commit intoopenshift:masterfrom
rolfedh:RHDEVDOCS-2604

Conversation

@rolfedh
Copy link
Copy Markdown
Contributor

@rolfedh rolfedh commented Feb 10, 2021 •
edited
Loading

https://issues.redhat.com/browse/RHDEVDOCS-2604
[enterprise-4.6][enterprise-4.7][enterprise-4.8]

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 10, 2021
@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 10, 2021 •
edited
Loading

Deploy preview for osdocs ready!

Built with commit 5f8517a

https://deploy-preview-29385--osdocs.netlify.app

@kalexand-rh kalexand-rh added this to the Next Release milestone Feb 12, 2021
kalexand-rh
kalexand-rh reviewed Feb 12, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@kalexand-rh kalexand-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple of questions and suggestions.

Comment thread modules/cluster-logging-collector-legacy-syslog.adoc Outdated
Comment thread modules/cluster-logging-collector-legacy-syslog.adoc Outdated
Comment thread modules/cluster-logging-collector-legacy-syslog.adoc Outdated
@kalexand-rh kalexand-rh added the peer-review-done Signifies that the peer review team has reviewed this PR label Feb 12, 2021
@r2d2rnd
Copy link
Copy Markdown

r2d2rnd commented Feb 12, 2021

@rolfedh it should be exactly as it's shown now ${hostname}. It must be a variable that it will be replaced by fluent in real-time for the name of the fluentd pod. If you put a name there, all the fluentd pods will send with the same hostname.

@rolfedh rolfedh closed this Feb 12, 2021
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 12, 2021
@rolfedh
Copy link
Copy Markdown
Contributor Author

rolfedh commented Feb 12, 2021

Thanks, @kalexand-rh. We've resolved all conversations.

@rolfedh rolfedh reopened this Feb 12, 2021
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 12, 2021
@rolfedh rolfedh changed the title RHDEVDOCS-2604 Wrong value and definition for legacy syslog hostname [enterprise-4.6][enterprise-4.7][enterprise-4.8] RHDEVDOCS-2604 Wrong value and definition for legacy syslog hostname Feb 12, 2021
@ahardin-rh ahardin-rh merged commit c290f0b into openshift:master Feb 24, 2021
@ahardin-rh
Copy link
Copy Markdown
Contributor

ahardin-rh commented Feb 24, 2021

/cherrypick enterprise-4.6

@ahardin-rh
Copy link
Copy Markdown
Contributor

ahardin-rh commented Feb 24, 2021

/cherrypick enterprise-4.7

@ahardin-rh
Copy link
Copy Markdown
Contributor

ahardin-rh commented Feb 24, 2021

/cherrypick enterprise-4.8

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 24, 2021
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Feb 24, 2021

@ahardin-rh: new pull request created: #29814

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Feb 24, 2021

@ahardin-rh: new pull request created: #29815

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Feb 24, 2021
Merged
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Feb 24, 2021

@ahardin-rh: new pull request created: #29816

Details

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcantrill jcantrill jcantrill left review comments

@mburke5678 mburke5678 mburke5678 left review comments

@kalexand-rh kalexand-rh kalexand-rh left review comments

@aburdenthehand aburdenthehand Awaiting requested review from aburdenthehand

@codyhoag codyhoag Awaiting requested review from codyhoag

@jeana-redhat jeana-redhat Awaiting requested review from jeana-redhat

@vikram-redhat vikram-redhat Awaiting requested review from vikram-redhat

Assignees

No one assigned

Labels

branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

9 participants

@rolfedh @r2d2rnd @ahardin-rh @openshift-cherrypick-robot @jcantrill @mburke5678 @kalexand-rh @adellape @openshift-ci-robot