Skip to content

RHDEVDOCS-2610#29514

Merged
ahardin-rh merged 1 commit intoopenshift:masterfrom
rolfedh:RHDEVDOCS-2610
Feb 24, 2021
Merged

RHDEVDOCS-2610#29514
ahardin-rh merged 1 commit intoopenshift:masterfrom
rolfedh:RHDEVDOCS-2610

Conversation

@rolfedh
Copy link
Copy Markdown
Contributor

@rolfedh rolfedh commented Feb 16, 2021

Add a location for the audit log file
[enterprise-4.7]

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 16, 2021
@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 16, 2021 •
edited
Loading

Deploy preview for osdocs ready!

Built with commit a84a59a

https://deploy-preview-29514--osdocs.netlify.app

@jboxman jboxman added this to the Future Release milestone Feb 17, 2021
jboxman
jboxman suggested changes Feb 17, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@jboxman jboxman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments for your review, thanks!

Comment thread modules/cluster-logging-about-collector.adoc Outdated
Comment thread modules/cluster-logging-about-collector.adoc Outdated
Comment thread modules/cluster-logging-about-collector.adoc Outdated
@jboxman jboxman added the peer-review-done Signifies that the peer review team has reviewed this PR label Feb 17, 2021
@huikang
Copy link
Copy Markdown

huikang commented Feb 19, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2021
@ahardin-rh ahardin-rh merged commit 91ce6f5 into openshift:master Feb 24, 2021
@ahardin-rh
Copy link
Copy Markdown
Contributor

ahardin-rh commented Feb 24, 2021

/cherrypick enterprise-4.7

@ahardin-rh
Copy link
Copy Markdown
Contributor

ahardin-rh commented Feb 24, 2021

/cherrypick enterprise-4.8

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 24, 2021
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Feb 24, 2021

@ahardin-rh: new pull request created: #29805

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 24, 2021
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Feb 24, 2021

@ahardin-rh: new pull request created: #29806

Details

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aburdenthehand aburdenthehand Awaiting requested review from aburdenthehand

@codyhoag codyhoag Awaiting requested review from codyhoag

@jeana-redhat jeana-redhat Awaiting requested review from jeana-redhat

@vikram-redhat vikram-redhat Awaiting requested review from vikram-redhat

1 more reviewer

@jboxman jboxman jboxman requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@huikang huikang

Labels

branch/enterprise-4.7 branch/enterprise-4.8 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

7 participants

@rolfedh @huikang @ahardin-rh @openshift-cherrypick-robot @jboxman @vikram-redhat @openshift-ci-robot