RHDEVDOCS-2614 Define ClusterLogForwarder compatibility matrix#29573
RHDEVDOCS-2614 Define ClusterLogForwarder compatibility matrix#29573ahardin-rh merged 1 commit intoopenshift:masterfrom rolfedh:RHDEVDOCS-2614
Conversation
rolfedh
requested review from
aburdenthehand,
codyhoag,
jeana-redhat and
vikram-redhat
as code owners
openshift-ci-robot
added
the
size/M
|
Deploy preview for osdocs ready! Built with commit b1229d5 |
|
Please take a look, @sichvoge @jcantrill @vimalk78. I think I've addressed all of the issues we discussed in the OpenShift Logging compatibility matrix Google doc. Please mark this PR as "lgtm" or suggest further improvements here in this PR, not in the Google doc. I've also set up this Slack thread for us to discuss this PR. |
|
@jcantrill @sichvoge @vimalk78 Please approve this PR with "lgtm" thanks. |
|
/lgtm |
ahardin-rh
added
branch/enterprise-4.7
peer-review-done
|
@rolfedh Just a few comments from me. 👍 |
|
Left another two comments. |
|
LGTM |
rolfedh
left a comment
rolfedh
left a comment
There was a problem hiding this comment.
- Thank you, @alanconway. That makes a lot more sense. I've updated the topic accordingly.
- PTAL @jcantrill @sichvoge @vimalk78
There was a problem hiding this comment.
"Tested with" rather than "Target" - we don't want to imply these are the only versions that work, they're just the ones we've tested against. Otherwise all good.
There was a problem hiding this comment.
Thanks, @alanconway. I've updated the heading. Please mark this PR as "/lgtm"
|
@rolfedh: you cannot LGTM your own PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
New changes are detected. LGTM label has been removed. |
|
/cherrypick enterprise-4.7 |
|
/cherrypick enterprise-4.8 |
|
@ahardin-rh: #29573 failed to apply on top of branch "enterprise-4.7": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ahardin-rh: #29573 failed to apply on top of branch "enterprise-4.8": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
|
||
| = Supported log data output types | ||
|
|
||
| [role="_abstract"] |
There was a problem hiding this comment.
@vikram-redhat Sure - no problem. I'll fix it today. This particular case comes from the redhat-documentation/modular-docs templates. We should have a tete-a-tete with Emily Murphy to avoid expanding issues like this.
There was a problem hiding this comment.
@vikram-redhat I've removed [role="_abstract"] in #30088, which is WIP. Please note that [role= also appears in the following locations:
Results for "[role=" in "*.adoc"
/home/rdlugyhe/openshift-docs/migration/migrating_3_4/migrating-applications-with-cam-3-4.adoc:
62: [role="_additional-resources"]
/home/rdlugyhe/openshift-docs/migration/migrating_3_4/troubleshooting-3-4.adoc:
38: [role="_additional-resources"]
/home/rdlugyhe/openshift-docs/migration/migrating_4_1_4/migrating-applications-with-cam-4-1-4.adoc:
61: [role="_additional-resources"]
/home/rdlugyhe/openshift-docs/migration/migrating_4_1_4/troubleshooting-4-1-4.adoc:
37: [role="_additional-resources"]
/home/rdlugyhe/openshift-docs/migration/migrating_4_2_4/migrating-applications-with-cam-4-2-4.adoc:
61: [role="_additional-resources"]
/home/rdlugyhe/openshift-docs/migration/migrating_4_2_4/troubleshooting-4-2-4.adoc:
37: [role="_additional-resources"]
9 participants
https://issues.redhat.com/browse/RHDEVDOCS-2614
[enterprise-4.7]