[enterprise-4.5]Fix URLs in the cluster logging templates#29679
Merged
bobfuru merged 1 commit intoopenshift:enterprise-4.5from Mar 7, 2021
Merged
[enterprise-4.5]Fix URLs in the cluster logging templates#29679bobfuru merged 1 commit intoopenshift:enterprise-4.5from
bobfuru merged 1 commit intoopenshift:enterprise-4.5from
Conversation
openshift-ci-robot
added
the
size/XS
|
Deploy preview for osdocs ready! Built with commit f05d39a |
Contributor
|
I see QE approval was granted in #29637. @openshift/team-documentation when you have a chance, please review and merge away. |
rolfedh
suggested changes
Feb 23, 2021
Contributor
rolfedh
left a comment
rolfedh
left a comment
There was a problem hiding this comment.
Please make a similar change here:
/home/rdlugyhe/openshift-docs/modules/cluster-logging-elasticsearch-audit.adoc:
115: endpoint: elasticsearch-insecure.svc.messaging.cluster.local
Contributor
Author
|
@rolfedh Thanks for your finding, updated new change in the new commit |
bobfuru
added
the
peer-review-done
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the feedback from #29637, 4.5 used the wrong URLs in the cluster logging templates.
@vikram-redhat This PR is only for the branch
enterprise-4.5, thanks.