Skip to content

BZ-1915563 Update metering MySQL Hive metastore configuration#29817

Merged
lbarbeevargas merged 1 commit intoopenshift:masterfrom
lbarbeevargas:BZ-1915563-update-mysql-hive-metastore-config
Feb 25, 2021
Merged

BZ-1915563 Update metering MySQL Hive metastore configuration#29817
lbarbeevargas merged 1 commit intoopenshift:masterfrom
lbarbeevargas:BZ-1915563-update-mysql-hive-metastore-config

Conversation

@lbarbeevargas
Copy link
Copy Markdown
Contributor

@lbarbeevargas lbarbeevargas commented Feb 24, 2021 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 24, 2021
@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 24, 2021 •
edited
Loading

Deploy preview for osdocs ready!

Built with commit b003bed

https://deploy-preview-29817--osdocs.netlify.app

@lbarbeevargas lbarbeevargas force-pushed the BZ-1915563-update-mysql-hive-metastore-config branch from 319095c to 13ce3ca Compare February 24, 2021 21:56
@lbarbeevargas
Copy link
Copy Markdown
Contributor Author

lbarbeevargas commented Feb 24, 2021

@timflannagan @pruan-rht PTAL.

timflannagan
timflannagan reviewed Feb 24, 2021
View reviewed changes
Comment thread modules/metering-use-mysql-or-postgresql-for-hive.adoc Outdated
Copy link
Copy Markdown
Contributor

@timflannagan timflannagan Feb 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Copy Markdown
Member

@pruan-rht pruan-rht Feb 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

timflannagan
timflannagan approved these changes Feb 24, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@timflannagan timflannagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this looks good to me. Thanks!

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2021
@lbarbeevargas lbarbeevargas added this to the Next Release milestone Feb 25, 2021
@lbarbeevargas lbarbeevargas force-pushed the BZ-1915563-update-mysql-hive-metastore-config branch from 13ce3ca to 89cabdf Compare February 25, 2021 14:59
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2021
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 25, 2021

New changes are detected. LGTM label has been removed.

@lbarbeevargas lbarbeevargas added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 25, 2021
ahardin-rh
ahardin-rh reviewed Feb 25, 2021
View reviewed changes
Comment thread modules/metering-use-mysql-or-postgresql-for-hive.adoc Outdated
Copy link
Copy Markdown
Contributor

@ahardin-rh ahardin-rh Feb 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/username/user name per IBM Style Guide

Copy link
Copy Markdown
Contributor Author

@lbarbeevargas lbarbeevargas Feb 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

ahardin-rh
ahardin-rh reviewed Feb 25, 2021
View reviewed changes
Comment thread modules/metering-use-mysql-or-postgresql-for-hive.adoc Outdated
Copy link
Copy Markdown
Contributor

@ahardin-rh ahardin-rh Feb 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/username/user name

@ahardin-rh ahardin-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 25, 2021
@ahardin-rh
Copy link
Copy Markdown
Contributor

ahardin-rh commented Feb 25, 2021

Just some minor comments, but otherwise LGTM!

@lbarbeevargas lbarbeevargas force-pushed the BZ-1915563-update-mysql-hive-metastore-config branch from 89cabdf to b003bed Compare February 25, 2021 16:07
@lbarbeevargas lbarbeevargas merged commit fb84628 into openshift:master Feb 25, 2021
@lbarbeevargas
Copy link
Copy Markdown
Contributor Author

lbarbeevargas commented Feb 25, 2021

/cherrypick enterprise-4.7

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 25, 2021
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Feb 25, 2021

@lbarbeevargas: new pull request created: #29854

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lbarbeevargas
Copy link
Copy Markdown
Contributor Author

lbarbeevargas commented Feb 25, 2021

/cherrypick enterprise-4.8

@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Feb 25, 2021

@lbarbeevargas: new pull request created: #29855

Details

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 25, 2021
Merged
@lbarbeevargas
Copy link
Copy Markdown
Contributor Author

lbarbeevargas commented Feb 25, 2021 •
edited
Loading

These updates also need to be CP'd to enterprise-4.6 once the code/update is backported to 4.6. Keeping this feature branch "open" until then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahardin-rh ahardin-rh ahardin-rh left review comments

+2 more reviewers

@pruan-rht pruan-rht pruan-rht left review comments

@timflannagan timflannagan timflannagan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pruan-rht pruan-rht

Labels

branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

6 participants

@lbarbeevargas @openshift-ci-robot @ahardin-rh @openshift-cherrypick-robot @pruan-rht @timflannagan