Skip to content

BZ1867205: clarification#30086

Merged
bmcelvee merged 1 commit intoopenshift:masterfrom
skrthomas:BZ1867205
Mar 5, 2021
Merged

BZ1867205: clarification#30086
bmcelvee merged 1 commit intoopenshift:masterfrom
skrthomas:BZ1867205

Conversation

@skrthomas
Copy link
Copy Markdown
Contributor

@skrthomas skrthomas commented Mar 3, 2021

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 3, 2021
@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 3, 2021

Deploy preview for osdocs ready!

Built with commit c8534c4

https://deploy-preview-30086--osdocs.netlify.app

= Using DNS forwarding

You can use DNS forwarding to override the forwarding configuration identified in `/etc/resolv.conf` on a per-zone basis by specifying which name server should be used for a given zone.
You can use DNS forwarding to override the forwarding configuration identified in `/etc/resolv.conf` on a per-zone basis by specifying which name server should be used for a given zone. If the forwarded zone is the Ingress domain managed by {product-title}, then the upstream name server must be authorized for the domain.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested edit:
If the forwarded zone is a domain managed by {product-title}, such as the Ingress domain, then...

@bmcelvee
Copy link
Copy Markdown
Contributor

bmcelvee commented Mar 4, 2021

Just a suggested reword, otherwise LGTM! Once the PR goes through QE and SME review, I'll be happy to merge. 🌞

@bmcelvee bmcelvee added the peer-review-done Signifies that the peer review team has reviewed this PR label Mar 4, 2021
@bmcelvee bmcelvee added this to the Next Release milestone Mar 4, 2021
@lihongan
Copy link
Copy Markdown

lihongan commented Mar 5, 2021

It looks great! Thank you @skrthomas

@bmcelvee
Copy link
Copy Markdown
Contributor

bmcelvee commented Mar 5, 2021

@danehans I'm going ahead with the merge and cherry pick on this one since it's a straight forward update. Please let us know if any additional changes are required and we can make those in a follow-up PR. Thanks!

@bmcelvee bmcelvee merged commit c7a1c6a into openshift:master Mar 5, 2021
@bmcelvee
Copy link
Copy Markdown
Contributor

bmcelvee commented Mar 5, 2021

/cherrypick enterprise-4.5

@bmcelvee
Copy link
Copy Markdown
Contributor

bmcelvee commented Mar 5, 2021

/cherrypick enterprise-4.6

@bmcelvee
Copy link
Copy Markdown
Contributor

bmcelvee commented Mar 5, 2021

/cherrypick enterprise-4.7

@bmcelvee
Copy link
Copy Markdown
Contributor

bmcelvee commented Mar 5, 2021

/cherrypick enterprise-4.8

@openshift-cherrypick-robot
Copy link
Copy Markdown

@bmcelvee: new pull request created: #30145

Details

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@bmcelvee: new pull request created: #30146

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@bmcelvee: new pull request created: #30147

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@bmcelvee: new pull request created: #30148

Details

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bmcelvee
Copy link
Copy Markdown
Contributor

bmcelvee commented Mar 5, 2021

/cherrypick enterprise-4.6

@openshift-cherrypick-robot
Copy link
Copy Markdown

@bmcelvee: new pull request created: #30168

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.5 branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants