Skip to content

handle flattening of cert-dir#305

Merged
adellape merged 1 commit intoopenshift:masterfrom
deads2k:deads-handle-flattenting
Apr 30, 2015
Merged

handle flattening of cert-dir#305
adellape merged 1 commit intoopenshift:masterfrom
deads2k:deads-handle-flattenting

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented Apr 17, 2015

Files are moving due to openshift/origin#1737 and we have significant drift from reality. This brings us back into alignment.

Do not merge until openshift/origin#1737 goes in.

@deads2k
Copy link
Contributor Author

deads2k commented Apr 17, 2015

@liggitt

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

write-config

@deads2k deads2k force-pushed the deads-handle-flattenting branch from 31cac6e to d7e3dee Compare April 17, 2015 13:22
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add an example IP to the --hostnames arg, just so people know they can (and probably should) include the node IP

@liggitt
Copy link

liggitt commented Apr 17, 2015

a few comments, sweep for rogue KUBECONFIG references, LGTM otherwise

@liggitt
Copy link

liggitt commented Apr 28, 2015

pre-doc reorg :-/

@deads2k deads2k force-pushed the deads-handle-flattenting branch 2 times, most recently from f7f9256 to a646d45 Compare April 28, 2015 14:43
@deads2k
Copy link
Contributor Author

deads2k commented Apr 28, 2015

rebased. I think that it found everything correctly. I don't see any rogue .crt, or .kubeconfig file references.

@deads2k deads2k changed the title [DO NOT MERGE] handle flattening of cert-dir handle flattening of cert-dir Apr 28, 2015
@deads2k deads2k force-pushed the deads-handle-flattenting branch from a646d45 to 6e949fa Compare April 29, 2015 17:51
@deads2k
Copy link
Contributor Author

deads2k commented Apr 29, 2015

rebased.

@adellape
Copy link
Contributor

@deads2k Thanks, will merge after the build passes.

adellape added a commit that referenced this pull request Apr 30, 2015
@adellape adellape merged commit 335bb7d into openshift:master Apr 30, 2015
sbeskin-redhat pushed a commit to sbeskin-redhat/openshift-docs that referenced this pull request Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants