Skip to content

Fix RHEL supported version in 4.7 RNs#31722

Merged
jeana-redhat merged 1 commit intoopenshift:enterprise-4.7from
jeana-redhat:RHEL-version-bump-fix-4.7-RNs
May 13, 2021
Merged

Fix RHEL supported version in 4.7 RNs#31722
jeana-redhat merged 1 commit intoopenshift:enterprise-4.7from
jeana-redhat:RHEL-version-bump-fix-4.7-RNs

Conversation

@jeana-redhat
Copy link
Copy Markdown
Contributor

@jeana-redhat jeana-redhat commented Apr 20, 2021 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 20, 2021
@jeana-redhat jeana-redhat added branch/enterprise-4.7 peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 20, 2021
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 20, 2021 •
edited
Loading

Deploy preview for osdocs ready!

Built with commit a5641d7

https://deploy-preview-31722--osdocs.netlify.app

@jeana-redhat
Copy link
Copy Markdown
Contributor Author

jeana-redhat commented Apr 20, 2021

Requesting approvals for this change from @miabbott, @marrusl, @control-d, @sferich888, @xltian, and @vikram-redhat

Xiaoli, thanks again for finding this one!

Also, when speaking to Bob Furu, I learned that "it was decided to change 4.6 docs to drop RHEL 7.8 and only indicate 7.9." So please let me know if this change should actually be from 7.7 -> 7.9.

@mburke5678
Copy link
Copy Markdown
Contributor

mburke5678 commented Apr 20, 2021

@jeana-redhat LGTM

@mburke5678 mburke5678 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 20, 2021
@control-d
Copy link
Copy Markdown

control-d commented Apr 20, 2021

Also, when speaking to Bob Furu, I learned that "it was decided to change 4.6 docs to drop RHEL 7.8 and only indicate 7.9." So please let me know if this change should actually be from 7.7 -> 7.9.

Yes, @marrusl and I discussed this, and it should be 7.9. Thanks!

@vikram-redhat
Copy link
Copy Markdown
Contributor

vikram-redhat commented Apr 21, 2021

ack

@jeana-redhat jeana-redhat force-pushed the RHEL-version-bump-fix-4.7-RNs branch from 5e5ee35 to 2deefcd Compare April 21, 2021 13:22
@jeana-redhat
Copy link
Copy Markdown
Contributor Author

jeana-redhat commented Apr 21, 2021

@control-d & @marrusl - thanks, updated to 7.9. Ready for approval again :)

@control-d
Copy link
Copy Markdown

control-d commented Apr 21, 2021

@jeana-redhat LGTM

miabbott
miabbott reviewed Apr 21, 2021
View reviewed changes
Comment thread release_notes/ocp-4-7-release-notes.adoc Outdated
@jeana-redhat jeana-redhat force-pushed the RHEL-version-bump-fix-4.7-RNs branch from 2deefcd to bce768c Compare April 27, 2021 13:36
@sferich888
Copy link
Copy Markdown
Contributor

sferich888 commented Apr 27, 2021

/label px-approved

@openshift-ci-robot openshift-ci-robot added the px-approved Signifies that Product Support has signed off on this PR label Apr 27, 2021
@jeana-redhat jeana-redhat force-pushed the RHEL-version-bump-fix-4.7-RNs branch from bce768c to 24b4b7b Compare April 29, 2021 17:11
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 29, 2021
@jeana-redhat
Copy link
Copy Markdown
Contributor Author

jeana-redhat commented Apr 29, 2021

@miabbott & @vikram-redhat - Mark uncovered a couple more places this version information needed to be updated, can you please take a look to make sure you still approve?

@bobfuru bobfuru mentioned this pull request Apr 29, 2021
Merged
@vikram-redhat
Copy link
Copy Markdown
Contributor

vikram-redhat commented Apr 29, 2021

Still works for me.

@xltian
Copy link
Copy Markdown

xltian commented Apr 30, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2021
@miabbott
Copy link
Copy Markdown
Member

miabbott commented Apr 30, 2021

/lgtm

@jeana-redhat jeana-redhat force-pushed the RHEL-version-bump-fix-4.7-RNs branch from 24b4b7b to a5641d7 Compare May 11, 2021 19:04
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 11, 2021

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label May 11, 2021
@jeana-redhat
Copy link
Copy Markdown
Contributor Author

jeana-redhat commented May 11, 2021

(last push just resolved merge conflicts)

@jeana-redhat jeana-redhat merged commit d555b07 into openshift:enterprise-4.7 May 13, 2021
@bobfuru bobfuru mentioned this pull request Jun 16, 2021
Merged
@jeana-redhat jeana-redhat deleted the RHEL-version-bump-fix-4.7-RNs branch July 16, 2021 17:35
@codyhoag codyhoag mentioned this pull request Sep 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@miabbott miabbott miabbott left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@xltian xltian

@miabbott miabbott

Labels

branch/enterprise-4.7 peer-review-done Signifies that the peer review team has reviewed this PR px-approved Signifies that Product Support has signed off on this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@jeana-redhat @mburke5678 @control-d @vikram-redhat @sferich888 @xltian @miabbott @openshift-ci-robot