OSDOCS-2144-Update 4.6+ sys reqs that BYO RHEL7 is deprecated by bobfuru · Pull Request #32074 · openshift/openshift-docs

bobfuru · 2021-04-30T01:03:23Z

Updates wording to note that BYO RHEL7 compute machines is deprecated in 4.6+, as indicated in this related PR: Update 4.8+ doc that OCP supports only RHEL 7.9 worker nodes #32070 (comment)
* Minor edits for style guide consistency (<- these do not need SME or QE review) (to mirror edits made in Update 4.8+ doc that OCP supports only RHEL 7.9 worker nodes #32070)

PREVIEW LINK (System requirements for RHEL compute nodes):
https://deploy-preview-32074--osdocs.netlify.app/openshift-enterprise/latest/machine_management/user_infra/adding-rhel-compute.html#rhel-compute-requirements_adding-rhel-compute

netlify · 2021-04-30T01:05:03Z

Deploy preview for osdocs ready!

Built with commit 2d69cf0

https://deploy-preview-32074--osdocs.netlify.app

bobfuru · 2021-04-30T21:37:11Z

As @katherinedube pointed out in #32070 (comment), we announced deprecation of this in 4.6, so this is updating the docs to reflect.

@katherinedube and @miabbott , @marrusl - please scrutinize line 28 ("In addition, you must not upgrade...") to be sure this makes sense here. Thanks!

lgtm. Thanks!

miabbott · 2021-05-05T19:43:20Z

BYO RHEL nodes don't really fall under the purview of RHCOS, but the wording looks sane to me.

/lgtm

codyhoag

One minor question. Looks good otherwise!

codyhoag · 2021-05-05T20:05:27Z

I see none of this module uses the RHEL attributes ({op-system-base-full} and {op-system-base}). Not sure if it's worth updating now or later, but thought I'd mention it.

Good point and worth the update. Resolved. Thanks, @codyhoag!

openshift-ci-robot · 2021-05-05T20:19:34Z

New changes are detected. LGTM label has been removed.

bobfuru · 2021-05-05T20:27:08Z

/cherrypick enterprise-4.8

bobfuru · 2021-05-05T20:27:12Z

/cherrypick enterprise-4.7

bobfuru · 2021-05-05T20:27:17Z

/cherrypick enterprise-4.6

openshift-cherrypick-robot · 2021-05-05T20:27:47Z

@bobfuru: #32074 failed to apply on top of branch "enterprise-4.7":

Applying: OSDOCS-2144-Update 4.6+ sys reqs that BYO RHEL7 is deprecated
Using index info to reconstruct a base tree...
M	modules/rhel-compute-requirements.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/rhel-compute-requirements.adoc
CONFLICT (content): Merge conflict in modules/rhel-compute-requirements.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OSDOCS-2144-Update 4.6+ sys reqs that BYO RHEL7 is deprecated
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2021-05-05T20:27:48Z

@bobfuru: new pull request created: #32242

Details

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2021-05-05T20:27:55Z

@bobfuru: #32074 failed to apply on top of branch "enterprise-4.6":

Applying: OSDOCS-2144-Update 4.6+ sys reqs that BYO RHEL7 is deprecated
Using index info to reconstruct a base tree...
M	modules/rhel-compute-requirements.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/rhel-compute-requirements.adoc
CONFLICT (content): Merge conflict in modules/rhel-compute-requirements.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OSDOCS-2144-Update 4.6+ sys reqs that BYO RHEL7 is deprecated
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bobfuru added branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 labels Apr 30, 2021

bobfuru added this to the Next Release milestone Apr 30, 2021

openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 30, 2021

bobfuru mentioned this pull request Apr 30, 2021

Update 4.8+ doc that OCP supports only RHEL 7.9 worker nodes #32070

Merged

bobfuru added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 30, 2021

bobfuru force-pushed the OSDOCS-2144 branch from 89c7a9e to 880857b Compare April 30, 2021 01:12

bobfuru removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 30, 2021

bobfuru force-pushed the OSDOCS-2144 branch from 880857b to ae0d62f Compare April 30, 2021 21:25

openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 30, 2021

bobfuru commented Apr 30, 2021

View reviewed changes

bobfuru force-pushed the OSDOCS-2144 branch from ae0d62f to 54f9ad3 Compare May 3, 2021 18:56

openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 3, 2021

openshift-ci-robot assigned miabbott May 5, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2021

bobfuru added the peer-review-needed Signifies that the peer review team needs to review this PR label May 5, 2021

codyhoag reviewed May 5, 2021

View reviewed changes

codyhoag added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels May 5, 2021

OSDOCS-2144-Update 4.6+ sys reqs that BYO RHEL7 is deprecated

2d69cf0

bobfuru force-pushed the OSDOCS-2144 branch from 54f9ad3 to 2d69cf0 Compare May 5, 2021 20:19

openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 5, 2021

bobfuru merged commit f0822c5 into openshift:master May 5, 2021

bobfuru deleted the OSDOCS-2144 branch May 5, 2021 20:27

openshift-cherrypick-robot mentioned this pull request May 5, 2021

[enterprise-4.8] OSDOCS-2144-Update 4.6+ sys reqs that BYO RHEL7 is deprecated #32242

Merged

This was referenced May 5, 2021

[enterprise-4.7] OSDOCS-2144-Update 4.6+ sys reqs that BYO RHEL7 is deprecated #32246

Merged

[enterprise-4.6] OSDOCS-2144-Update 4.6+ sys reqs that BYO RHEL7 is deprecated #32248

Merged

Conversation

bobfuru commented Apr 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify Bot commented Apr 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bobfuru Apr 30, 2021

Choose a reason for hiding this comment

Uh oh!

katherinedube May 2, 2021

Choose a reason for hiding this comment

Uh oh!

miabbott commented May 5, 2021

Uh oh!

codyhoag left a comment

Choose a reason for hiding this comment

Uh oh!

codyhoag May 5, 2021

Choose a reason for hiding this comment

Uh oh!

bobfuru May 5, 2021

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented May 5, 2021

Uh oh!

bobfuru commented May 5, 2021

Uh oh!

bobfuru commented May 5, 2021

Uh oh!

bobfuru commented May 5, 2021

Uh oh!

openshift-cherrypick-robot commented May 5, 2021

Uh oh!

openshift-cherrypick-robot commented May 5, 2021

Uh oh!

openshift-cherrypick-robot commented May 5, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

bobfuru commented Apr 30, 2021 •

edited

Loading

netlify Bot commented Apr 30, 2021 •

edited

Loading