OSDOCS-1770 Installing a cluster on GCP in a restricted network by codyhoag · Pull Request #32482 · openshift/openshift-docs

codyhoag · 2021-05-12T14:56:10Z

https://issues.redhat.com/browse/OSDOCS-1770

Previews:

netlify · 2021-05-12T15:02:07Z

Deploy preview for osdocs ready!

Built with commit f591cba

https://deploy-preview-32482--osdocs.netlify.app

codyhoag · 2021-05-12T15:23:59Z

@staebler PTAL. I followed a similar path as what was recommended for AWS. Thanks!

staebler

LGTM

codyhoag · 2021-05-12T16:53:17Z

@tsze-redhat can you confirm from a QE perspective? Thanks!

tsze-redhat · 2021-05-12T17:25:37Z

Is this for adding a page for IPI Restricted cluster?

Assuming it is,
1 why do we need an existing vpc?

2 Item 12 in
https://deploy-preview-32482--osdocs.netlify.app/openshift-enterprise/latest/installing/installing_gcp/installing-restricted-networks-gcp-installer-provisioned.html#installation-gcp-config-yaml_installing-restricted-networks-gcp-installer-provisioned

under
additionalTrustBundle: |
-----BEGIN CERTIFICATE-----
<MY_TRUSTED_CA_CERT>
-----END CERTIFICATE-----

texts need to have two spaces from beginning.

Right now, there appears to be 4.

Can you confirm?

3 Hyperthreading for compute under
compute:

hyperthreading: Enabled

is marked as remark #3 only but it should be #3 & #4 (similar to control).

4 Configuring the cluster-wide proxy during installation should be optional
https://deploy-preview-32482--osdocs.netlify.app/openshift-enterprise/latest/installing/installing_gcp/installing-restricted-networks-gcp-installer-provisioned.html#installation-configure-proxy_installing-restricted-networks-gcp-installer-provisioned

In fact, why do we have this section?
It is not there in Restricted network UPI page.

This section only appears in "Installing a cluster on GCP into an existing VPC" page.

Please feel free to ping me if you need any clarification on any of the above.

Thanks.

codyhoag · 2021-05-12T18:00:47Z

@tsze-redhat a few answers below:

Is this for adding a page for IPI Restricted cluster?

Yes

why do we need an existing vpc?

Matthew explained it well here. A snippet from his explanation to me: The point of needing to BYO VPC is that either (1) the mirror registry needs to be in the VPC or (2) the VPC needs to have firewall rules or peering to access the mirror registry hosted elsewhere. In either case, the VPC needs to exist before installation.

texts need to have two spaces from beginning. Right now, there appears to be 4.

Fixed

Hyperthreading for compute is marked as remark Initial build system #3 only but it should be Initial build system #3 & Fixed doc files to meet AsciiDoctor standards #4 (similar to control).

Fixed

Configuring the cluster-wide proxy during installation should be optional. In fact, why do we have this section? It is not there in Restricted network UPI page.

I've been putting this in the restricted assemblies based on feedback I receieved during the vSphere review process from Jinyun here. From what I understand, this used to not be supported for IPI installs, but is now supported as of recently. I'm not sure why it is not there for GCP UPI, but I can add it there in a separate PR if that would be relevant there.

Let me know if there's any other feedback or any changes for this. Thanks!

tsze-redhat · 2021-05-12T21:18:44Z

Given that user must provide vpc,
6, 7, 8 in https://deploy-preview-32482--osdocs.netlify.app/openshift-enterprise/latest/installing/installing_gcp/installing-restricted-networks-gcp-installer-provisioned.html#installation-gcp-config-yaml_installing-restricted-networks-gcp-installer-provisioned
should not begin with "If you use an existing VPC, "

The rest is good.

Thanks.

maxwelldb

Looks copacetic.

I made a few comments/suggestions, but nothing major.

The list punctuation thing should be resolved prior to merging.

codyhoag · 2021-05-13T00:46:33Z

/cherrypick enterprise-4.8

codyhoag · 2021-05-13T00:46:37Z

/cherrypick enterprise-4.7

codyhoag · 2021-05-13T00:46:41Z

/cherrypick enterprise-4.6

codyhoag · 2021-05-13T00:46:45Z

/cherrypick enterprise-4.5

openshift-cherrypick-robot · 2021-05-13T00:47:13Z

@codyhoag: new pull request created: #32510

Details

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2021-05-13T00:47:17Z

@codyhoag: new pull request created: #32511

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2021-05-13T00:47:18Z

@codyhoag: #32482 failed to apply on top of branch "enterprise-4.6":

Applying: Installing a cluster on GCP in a restricted network
Using index info to reconstruct a base tree...
M	_topic_map.yml
A	installing/installing-preparing.adoc
M	modules/cli-installing-cli.adoc
M	modules/cluster-entitlements.adoc
M	modules/installation-about-restricted-network.adoc
M	modules/installation-configuration-parameters.adoc
M	modules/installation-configure-proxy.adoc
M	modules/installation-gcp-config-yaml.adoc
M	modules/installation-initializing.adoc
M	modules/ssh-agent-using.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/ssh-agent-using.adoc
Auto-merging modules/installation-initializing.adoc
Auto-merging modules/installation-gcp-config-yaml.adoc
CONFLICT (content): Merge conflict in modules/installation-gcp-config-yaml.adoc
Auto-merging modules/installation-configure-proxy.adoc
Auto-merging modules/installation-configuration-parameters.adoc
Auto-merging modules/installation-about-restricted-network.adoc
Auto-merging modules/cluster-entitlements.adoc
Auto-merging modules/cli-installing-cli.adoc
CONFLICT (modify/delete): installing/installing-preparing.adoc deleted in HEAD and modified in Installing a cluster on GCP in a restricted network. Version Installing a cluster on GCP in a restricted network of installing/installing-preparing.adoc left in tree.
Auto-merging _topic_map.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Installing a cluster on GCP in a restricted network
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2021-05-13T00:47:21Z

@codyhoag: #32482 failed to apply on top of branch "enterprise-4.5":

Applying: Installing a cluster on GCP in a restricted network
Using index info to reconstruct a base tree...
M	_topic_map.yml
A	installing/installing-preparing.adoc
M	modules/cli-installing-cli.adoc
M	modules/cli-logging-in-kubeadmin.adoc
M	modules/cluster-entitlements.adoc
M	modules/installation-about-restricted-network.adoc
M	modules/installation-configuration-parameters.adoc
M	modules/installation-configure-proxy.adoc
M	modules/installation-gcp-config-yaml.adoc
M	modules/installation-initializing.adoc
M	modules/installation-launching-installer.adoc
M	modules/ssh-agent-using.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/ssh-agent-using.adoc
Auto-merging modules/installation-launching-installer.adoc
Auto-merging modules/installation-initializing.adoc
Auto-merging modules/installation-gcp-config-yaml.adoc
CONFLICT (content): Merge conflict in modules/installation-gcp-config-yaml.adoc
Auto-merging modules/installation-configure-proxy.adoc
Auto-merging modules/installation-configuration-parameters.adoc
Auto-merging modules/installation-about-restricted-network.adoc
CONFLICT (content): Merge conflict in modules/installation-about-restricted-network.adoc
Auto-merging modules/cluster-entitlements.adoc
Auto-merging modules/cli-logging-in-kubeadmin.adoc
Auto-merging modules/cli-installing-cli.adoc
CONFLICT (modify/delete): installing/installing-preparing.adoc deleted in HEAD and modified in Installing a cluster on GCP in a restricted network. Version Installing a cluster on GCP in a restricted network of installing/installing-preparing.adoc left in tree.
Auto-merging _topic_map.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Installing a cluster on GCP in a restricted network
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

codyhoag added branch/enterprise-4.5 branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 labels May 12, 2021

codyhoag added this to the Next Release milestone May 12, 2021

openshift-ci Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 12, 2021

codyhoag force-pushed the gcp-restricted-network branch from 731983e to 7e53f4c Compare May 12, 2021 15:05

staebler reviewed May 12, 2021

View reviewed changes

codyhoag force-pushed the gcp-restricted-network branch from 7e53f4c to 3901633 Compare May 12, 2021 17:59

codyhoag force-pushed the gcp-restricted-network branch from 3901633 to cf44568 Compare May 12, 2021 21:28

codyhoag added the peer-review-needed Signifies that the peer review team needs to review this PR label May 12, 2021

maxwelldb self-requested a review May 12, 2021 23:25

maxwelldb reviewed May 13, 2021

View reviewed changes

maxwelldb added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels May 13, 2021

Installing a cluster on GCP in a restricted network

f591cba

codyhoag force-pushed the gcp-restricted-network branch from cf44568 to f591cba Compare May 13, 2021 00:43

codyhoag merged commit 402a539 into openshift:master May 13, 2021

openshift-cherrypick-robot mentioned this pull request May 13, 2021

[enterprise-4.8] OSDOCS-1770 Installing a cluster on GCP in a restricted network #32510

Merged

openshift-cherrypick-robot mentioned this pull request May 13, 2021

[enterprise-4.7] OSDOCS-1770 Installing a cluster on GCP in a restricted network #32511

Merged

This was referenced May 13, 2021

[enterprise-4.6] OSDOCS-1770 Installing a cluster on GCP in a restricted network #32513

Merged

[enterprise-4.5] OSDOCS-1770 Installing a cluster on GCP in a restricted network #32514

Merged

kalexand-rh mentioned this pull request Aug 19, 2021

BZ1860721: adding certificate customizations #34976

Merged

Conversation

codyhoag commented May 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify Bot commented May 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codyhoag commented May 12, 2021

Uh oh!

staebler left a comment

Choose a reason for hiding this comment

Uh oh!

codyhoag commented May 12, 2021

Uh oh!

tsze-redhat commented May 12, 2021

Uh oh!

codyhoag commented May 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tsze-redhat commented May 12, 2021

Uh oh!

maxwelldb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codyhoag commented May 13, 2021

Uh oh!

codyhoag commented May 13, 2021

Uh oh!

codyhoag commented May 13, 2021

Uh oh!

codyhoag commented May 13, 2021

Uh oh!

openshift-cherrypick-robot commented May 13, 2021

Uh oh!

openshift-cherrypick-robot commented May 13, 2021

Uh oh!

openshift-cherrypick-robot commented May 13, 2021

Uh oh!

openshift-cherrypick-robot commented May 13, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codyhoag commented May 12, 2021 •

edited

Loading

netlify Bot commented May 12, 2021 •

edited

Loading

codyhoag commented May 12, 2021 •

edited

Loading