Skip to content

OSDOCS-2082: Add coreos print-stream-json sub-command to AWS AMI install#33415

Merged
bobfuru merged 1 commit intoopenshift:masterfrom
bobfuru:OSDOCS-2082
Jun 24, 2021
Merged

OSDOCS-2082: Add coreos print-stream-json sub-command to AWS AMI install#33415
bobfuru merged 1 commit intoopenshift:masterfrom
bobfuru:OSDOCS-2082

Conversation

@bobfuru
Copy link
Copy Markdown
Contributor

@bobfuru bobfuru commented Jun 14, 2021 •
edited
Loading

OSDOCS-2082
In this example, we want to give admins a better way than the current workflow of hardcoding AMIs that are copy-pasted from the openshift-installer. This PR documents how to run the new coreos sub-command of the installer so that users can avoid having to manually parse the HTML in modules/installation-aws-user-infra-rhcos-ami.adoc.

Preview links:

@bobfuru bobfuru added this to the Future Release milestone Jun 14, 2021
@openshift-ci openshift-ci Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 14, 2021
@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 14, 2021 •
edited
Loading

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 9f3b152

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/60d4b80c217dd00008346647

😎 Browse the preview: https://deploy-preview-33415--osdocs.netlify.app

@bobfuru bobfuru force-pushed the OSDOCS-2082 branch 3 times, most recently from 14299ff to 719cd3e Compare June 14, 2021 19:04
@bobfuru
Copy link
Copy Markdown
Contributor Author

bobfuru commented Jun 14, 2021

Hi @cgwalters (Eng) and @miabbott (QE) - PTAL for review in OCP 4.8. 🙇

This content for bootimages is generally new to me, so I've looked at the discussion in the stream-metadata-go library and in the GRPA-1807 epic, along with the CoreOS bootimages doc in the openshift/installer repo.

This PR starts with the UPI install docs for automating the AWS AMI bootimage using the openshift-install coreos print-stream-json command. You'll see also where I've left the docs intact for manually specifying the AMI (aside from a few minor wording changes).

Once the AMI use case in this PR has been resolved, I can look at adding manual copy instructions for OpenStack QCOW2 and bare metal ISO in a new PR.

bobfuru
bobfuru commented Jun 14, 2021
View reviewed changes
Comment thread modules/installation-aws-ami-stream-metadata.adoc Outdated
bobfuru
bobfuru commented Jun 14, 2021
View reviewed changes
Comment thread modules/installation-aws-ami-stream-metadata.adoc Outdated
bobfuru
bobfuru commented Jun 14, 2021
View reviewed changes
Comment thread modules/installation-aws-ami-stream-metadata.adoc Outdated
bobfuru
bobfuru commented Jun 14, 2021
View reviewed changes
Comment thread modules/installation-aws-user-infra-rhcos-ami.adoc Outdated
@bobfuru bobfuru mentioned this pull request Jun 14, 2021
Merged
cgwalters
cgwalters reviewed Jun 14, 2021
View reviewed changes
Comment thread modules/installation-aws-ami-stream-metadata.adoc Outdated
bobfuru
bobfuru commented Jun 15, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@bobfuru bobfuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review, @cgwalters. I made some revisions based on your feedback. Could you PTAL at these updates?

Comment thread modules/installation-aws-ami-stream-metadata.adoc Outdated
Comment thread modules/installation-aws-ami-stream-metadata.adoc Outdated
miabbott
miabbott reviewed Jun 18, 2021
View reviewed changes
Comment thread modules/installation-aws-ami-stream-metadata.adoc Outdated
miabbott
miabbott reviewed Jun 18, 2021
View reviewed changes
Comment thread modules/installation-aws-ami-stream-metadata.adoc Outdated
miabbott
miabbott reviewed Jun 18, 2021
View reviewed changes
Comment thread modules/installation-aws-ami-stream-metadata.adoc Outdated
@miabbott
Copy link
Copy Markdown
Member

miabbott commented Jun 18, 2021

Overall content looks good, just some suggested cleanups/corrections.

@bobfuru bobfuru force-pushed the OSDOCS-2082 branch 2 times, most recently from 211d313 to 914f8d7 Compare June 18, 2021 20:51
@bobfuru
Copy link
Copy Markdown
Contributor Author

bobfuru commented Jun 18, 2021

Applied feedback from @miabbott and will wait for approval from @cgwalters before merging. Thanks!

@ahardin-rh ahardin-rh added the peer-review-done Signifies that the peer review team has reviewed this PR label Jun 21, 2021
@ahardin-rh
Copy link
Copy Markdown
Contributor

ahardin-rh commented Jun 21, 2021

LGTM!

@miabbott
Copy link
Copy Markdown
Member

miabbott commented Jun 22, 2021

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2021
cgwalters
cgwalters approved these changes Jun 24, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2021
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 24, 2021

New changes are detected. LGTM label has been removed.

@bobfuru bobfuru merged commit bcc3711 into openshift:master Jun 24, 2021
@bobfuru bobfuru deleted the OSDOCS-2082 branch June 24, 2021 17:27
@bobfuru
Copy link
Copy Markdown
Contributor Author

bobfuru commented Jun 24, 2021

/cherrypick enterprise-4.8

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 24, 2021
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Jun 24, 2021

@bobfuru: new pull request created: #33916

Details

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@miabbott miabbott miabbott left review comments

@cgwalters cgwalters cgwalters approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cgwalters cgwalters

@miabbott miabbott

Labels

branch/enterprise-4.8 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.8 GA

Development

Successfully merging this pull request may close these issues.

6 participants

@bobfuru @miabbott @ahardin-rh @openshift-cherrypick-robot @cgwalters @vikram-redhat