Card origin_devexp_286 - Added ssh key-based access to private git repository documentation#339
Conversation
|
Related docs card: https://trello.com/c/nsFhtpIV |
|
couple minor fixes and one medium size suggestion, otherwise looks good! |
|
@bparees addressed all your comments. |
There was a problem hiding this comment.
It'll be changed to ssh-privatekey based on discussion here.
There was a problem hiding this comment.
@soltysh Just to confirm, when sshsecret is changed to ssh-privatekey, will ssh-privatekey be specifically what is required for this, like the dockercfg key in the previous section? I'm assuming so based on the "Supported auth methods are: ssh-privatekey" comments in the linked dev PR.
There was a problem hiding this comment.
Yes that's correct, based on the key name we'll choose the appropriate auth method. For now ssh-privatekey is the only supported, future versions will support user+password and token etc. I'll update that PR as soon as my code PR is done, which I'm pretty close to.
|
couple more comments. |
…pository documentation
|
@bparees updated & addressed your comments. PTAL. |
|
looks good to me, excellent work @soltysh! |
|
@bparees thx, I have good reviewers 😄 |
|
@soltysh I'm assuming I should wait til the code PR merges before merging this. I'll slap a [do not merge] on this until told otherwise. Thanks! |
adellape
changed the title
|
yeah, you'll want to wait on this PR: openshift/origin#1926 |
adellape
changed the title
Card origin_devexp_286 - Added ssh key-based access to private git repository documentation
Add article to full name of product
3 participants
@bparees @CowboysFan @mfojtik PTAL