Skip to content

OSDOCS-2361: Add olm.catalogImageTemplate docs#36199

Merged
adellape merged 1 commit intoopenshift:mainfrom
adellape:switch_catalog
Sep 16, 2021
Merged

OSDOCS-2361: Add olm.catalogImageTemplate docs#36199
adellape merged 1 commit intoopenshift:mainfrom
adellape:switch_catalog

Conversation

@adellape
Copy link
Copy Markdown
Contributor

@adellape adellape commented Sep 8, 2021

https://issues.redhat.com/browse/OSDOCS-2361

Preview builds for changes:

  • Added olm.catalogImageTemplate to the example CatalogSource object (callout 3) as an optional annotation in the Catalog source section of the "Operator Lifecycle Manager concepts and resources" topic.
  • Added new Image template for custom catalog sources subsection under the "Catalog source" section with more conceptual details on how the annotation works.
  • Added shorter mention of olm.catalogImageTemplate in the CatalogSource object for the "Creating a catalog from an index image" section that appears in the Managing custom catalogs topic, with a link in its "Additional resources" list to the "Catalog source" concept page for more details about the spec.
  • Did not include olm.catalogImageTemplate in the example CatalogSource object in the version of "Creating a catalog from an index image" that appears in the Using Operator Lifecycle Manager on restricted networks topic, but it does mention the option with a link to the new subsection in the "Additional resources" list at the end of the section.
  • Duplicated the new info about how CVO automatically upgrades RH-provided catalogs into the About Red Hat-provided Operator catalogs section.

@adellape adellape added this to the Future Release milestone Sep 8, 2021
@openshift-ci openshift-ci Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 8, 2021
@netlify
Copy link
Copy Markdown

netlify Bot commented Sep 8, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: fec1969

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/61437cd742586b0007418b33

😎 Browse the preview: https://deploy-preview-36199--osdocs.netlify.app

@adellape adellape force-pushed the switch_catalog branch 4 times, most recently from 22e0e3e to 7fca5ea Compare September 10, 2021 21:35
@openshift-ci openshift-ci Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 10, 2021
@adellape adellape force-pushed the switch_catalog branch 5 times, most recently from 6dcc098 to 489079c Compare September 10, 2021 22:14
Comment thread modules/olm-catalogsource-image-template.adoc Outdated
Comment thread modules/olm-catalogsource.adoc Outdated
@adellape adellape force-pushed the switch_catalog branch 2 times, most recently from 13ed417 to b420a21 Compare September 13, 2021 16:06
@adellape
Copy link
Copy Markdown
Contributor Author

@kevinrizza PTAL for tech review. 🙏

@kevinrizza
Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2021
@adellape adellape added the peer-review-needed Signifies that the peer review team needs to review this PR label Sep 16, 2021
Copy link
Copy Markdown
Contributor

@EricPonvelle EricPonvelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Comment thread modules/olm-catalogsource.adoc Outdated
@EricPonvelle EricPonvelle added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Sep 16, 2021
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Sep 16, 2021

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2021
@adellape adellape merged commit ea17ce8 into openshift:main Sep 16, 2021
@adellape adellape deleted the switch_catalog branch September 16, 2021 17:31
@adellape
Copy link
Copy Markdown
Contributor Author

/cherrypick enterprise-4.9

@openshift-cherrypick-robot
Copy link
Copy Markdown

@adellape: new pull request created: #36450

Details

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.9 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants