TELCODOCS-258: D/S Docs & RN: MPHARDWARE-11 (KNIDEPLOY-4526), Bare Metal IPI Support on IBM Cloud by johnwilkins · Pull Request #36529 · openshift/openshift-docs

johnwilkins · 2021-09-17T21:19:01Z

Provides documentation for deploying an installer-provisioned cluster on IBM Cloud.

See https://issues.redhat.com/browse/TELCODOCS-258 for additional details.

Preview URL: https://deploy-preview-36529--osdocs.netlify.app/openshift-enterprise/latest/installing/installing_ibm_cloud/install-ibm-cloud-prerequisites.html

For release(s): 4.9
Signed-off-by: John Wilkins jowilkin@redhat.com

netlify · 2021-09-17T21:26:24Z

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 40eca033f01f3d0c3d93a421c46a4dd483d0cbd7

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/61450646138cfa0007d01709

😎 Browse the preview: https://deploy-preview-36529--osdocs.netlify.app

netlify · 2021-09-17T21:28:52Z

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: b91399d

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/6160874cc7f9350007dcfbcd

😎 Browse the preview: https://deploy-preview-36529--osdocs.netlify.app/openshift-enterprise/latest/installing/installing_ibm_cloud/install-ibm-cloud-prerequisites

derekhiggins

Some comments added, I'll run through the instruction on a new environment to ensure it all works

derekhiggins

Notes added inline
I think all of the content around creating the kni user and configuring sudo and ssh keys is duplicated, we probably don't need this in here

Also we should explicitly mention somewhere that only ipmi/pxe is supported in 4.9 (i.e. redfish support has not been added/tested)

johnwilkins · 2021-09-22T01:39:37Z

Notes added inline
I think all of the content around creating the kni user and configuring sudo and ssh keys is duplicated, we probably don't need this in here

Also we should explicitly mention somewhere that only ipmi/pxe is supported in 4.9 (i.e. redfish support has not been added/tested)

Per the release notes, I'm replacing the entire procedure for the IBM steps. I'm inclined to completely review the baremetal steps too in case we no longer need the pool steps. There are a few comments in that procedure from Dieter and others that I'm resolving as well.

I will make a few additional comments to indicate that we are completely substituting a procedure.

johnwilkins · 2021-09-22T04:57:38Z

@derekhiggins I've made the noted changes. I've also added in statements and links to the main IPI docs. I still think this could use a summary telling them what to do next, and what's NOT supported in the main IPI docs--e.g., disconnected installation.

derekhiggins

Per the release notes, I'm replacing the entire procedure for the IBM steps. I'm inclined to completely review the baremetal steps too in case we no longer need the pool steps. There are a few comments in that procedure from Dieter and others that I'm resolving as well.

I'm a bit confused the Release notes you sent me says "The documentation provides complementary sections identifying the differences between installing on bare metal and installing on IBM Cloud."

So I'd be expecting that we only need to document the differences.

derekhiggins · 2021-09-22T10:53:41Z

@derekhiggins I've made the noted changes. I've also added in statements and links to the main IPI docs. I still think this could use a summary telling them what to do next, and what's NOT supported in the main IPI docs--e.g., disconnected installation.

thanks, looks pretty close to be, the only thing I know of that not supported is redfish and virtual media (we've only tested ipmi/pxe)

lshilin-r · 2021-10-07T20:09:18Z

Please, correct as we discussed and lgtm

derekhiggins · 2021-10-07T21:49:44Z

lgtm, also confirmed the comments @lshilin-r mentioned have been addressed

bergerhoffer

@johnwilkins thanks for the updates! LGTM. I pointed out just one thing, but it's not enough to hold the PR over.

However there are 2 commits in the PR now, so we can't merge until that is squashed. I'm out tomorrow, but if you ping me on slack once you squash I can try to hop on and merge it for ya!

…r-provisioned infrastructure on IBM Cloud..

bergerhoffer · 2021-10-08T18:17:08Z

Thanks for the squash, merging!

bergerhoffer · 2021-10-08T18:17:16Z

/cherrypick enterprise-4.9

openshift-cherrypick-robot · 2021-10-08T18:17:56Z

@bergerhoffer: new pull request created: #37262

Details

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci Bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 17, 2021

johnwilkins changed the title ~~TELCODOCS-258: D/S Docs & RN: MPHARDWARE-11 (KNIDEPLOY-4526), Bare Metal IPI Support on IBM Cloud~~ WIP: TELCODOCS-258: D/S Docs & RN: MPHARDWARE-11 (KNIDEPLOY-4526), Bare Metal IPI Support on IBM Cloud Sep 17, 2021

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 17, 2021

johnwilkins changed the title ~~WIP: TELCODOCS-258: D/S Docs & RN: MPHARDWARE-11 (KNIDEPLOY-4526), Bare Metal IPI Support on IBM Cloud~~ TELCODOCS-258: D/S Docs & RN: MPHARDWARE-11 (KNIDEPLOY-4526), Bare Metal IPI Support on IBM Cloud Sep 17, 2021

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 17, 2021

derekhiggins reviewed Sep 20, 2021

View reviewed changes

derekhiggins reviewed Sep 21, 2021

View reviewed changes

johnwilkins force-pushed the TELCODOCS-258 branch from db6361c to 414f2bd Compare September 22, 2021 04:55

derekhiggins reviewed Sep 22, 2021

View reviewed changes

kquinn1204 reviewed Sep 22, 2021

View reviewed changes

Comment thread modules/install-ibm-cloud-configuring-the-install-config-file.adoc Outdated

Comment thread modules/install-ibm-cloud-preparing-the-provisioner-node.adoc Outdated

Comment thread modules/install-ibm-cloud-configuring-the-install-config-file.adoc Outdated

lshilin-r reviewed Oct 4, 2021

View reviewed changes

Comment thread modules/install-ibm-cloud-configuring-the-public-subnet.adoc Outdated

lshilin-r reviewed Oct 4, 2021

View reviewed changes

Comment thread modules/install-ibm-cloud-preparing-the-provisioner-node.adoc Outdated

lshilin-r reviewed Oct 4, 2021

View reviewed changes

Comment thread modules/install-ibm-cloud-configuring-the-install-config-file.adoc Outdated

lshilin-r reviewed Oct 5, 2021

View reviewed changes

Comment thread modules/install-ibm-cloud-configuring-the-public-subnet.adoc Outdated

lshilin-r reviewed Oct 5, 2021

View reviewed changes

Comment thread modules/install-ibm-cloud-configuring-the-public-subnet.adoc Outdated

johnwilkins force-pushed the TELCODOCS-258 branch from 7b12df8 to 105c0b2 Compare October 6, 2021 01:30

lshilin-r reviewed Oct 6, 2021

View reviewed changes

Comment thread installing/installing_ibm_cloud/install-ibm-cloud-installing-on-ibm-cloud.adoc Outdated

openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 7, 2021

lshilin-r reviewed Oct 7, 2021

View reviewed changes

Comment thread installing/installing_ibm_cloud/install-ibm-cloud-installation-workflow.adoc Outdated

johnwilkins force-pushed the TELCODOCS-258 branch from 20d1f9b to abd186f Compare October 7, 2021 05:03

openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 7, 2021

derekhiggins reviewed Oct 7, 2021

View reviewed changes

Comment thread modules/install-ibm-cloud-setting-up-ibm-cloud-infrastructure.adoc Outdated

Comment thread modules/install-ibm-cloud-setting-up-ibm-cloud-infrastructure.adoc Outdated

Comment thread modules/install-ibm-cloud-configuring-the-public-subnet.adoc Outdated

johnwilkins force-pushed the TELCODOCS-258 branch 2 times, most recently from 8e27ea2 to 1be53dd Compare October 7, 2021 15:42

bergerhoffer added the branch/enterprise-4.9 label Oct 7, 2021

bergerhoffer added the peer-review-needed Signifies that the peer review team needs to review this PR label Oct 7, 2021

bergerhoffer added this to the Future Release milestone Oct 7, 2021

bergerhoffer reviewed Oct 7, 2021

View reviewed changes

bergerhoffer added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Oct 7, 2021

lshilin-r reviewed Oct 7, 2021

View reviewed changes

Comment thread modules/install-ibm-cloud-configuring-the-public-subnet.adoc Outdated

lshilin-r reviewed Oct 7, 2021

View reviewed changes

Comment thread modules/install-ibm-cloud-configuring-the-public-subnet.adoc Outdated

lshilin-r reviewed Oct 7, 2021

View reviewed changes

Comment thread modules/install-ibm-cloud-configuring-the-public-subnet.adoc Outdated

bergerhoffer reviewed Oct 8, 2021

View reviewed changes

Comment thread modules/install-ibm-cloud-setting-up-ibm-cloud-infrastructure.adoc Outdated

johnwilkins force-pushed the TELCODOCS-258 branch from a89559d to c79b88e Compare October 8, 2021 17:57

TELCODOCS-258: Provides documentation for deploying OCP with installe…

b91399d

…r-provisioned infrastructure on IBM Cloud..

johnwilkins force-pushed the TELCODOCS-258 branch from e982091 to b91399d Compare October 8, 2021 18:00

bergerhoffer merged commit c29a389 into openshift:main Oct 8, 2021

openshift-cherrypick-robot mentioned this pull request Oct 8, 2021

[enterprise-4.9] TELCODOCS-258: D/S Docs & RN: MPHARDWARE-11 (KNIDEPLOY-4526), Bare Metal IPI Support on IBM Cloud #37262

Merged

vikram-redhat modified the milestones: Future Release, OCP 4.9 GA Oct 18, 2021

Conversation

johnwilkins commented Sep 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify Bot commented Sep 17, 2021

Uh oh!

netlify Bot commented Sep 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

derekhiggins left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

derekhiggins left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

johnwilkins commented Sep 22, 2021

Uh oh!

johnwilkins commented Sep 22, 2021

Uh oh!

derekhiggins left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

derekhiggins commented Sep 22, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lshilin-r commented Oct 7, 2021

Uh oh!

derekhiggins commented Oct 7, 2021

Uh oh!

bergerhoffer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bergerhoffer commented Oct 8, 2021

Uh oh!

bergerhoffer commented Oct 8, 2021

Uh oh!

johnwilkins commented Sep 17, 2021 •

edited

Loading

netlify Bot commented Sep 17, 2021 •

edited

Loading