Skip to content

Adds a prerequisite to obtain service principal permissions at the su…#37275

Merged
bobfuru merged 1 commit intoopenshift:mainfrom
stevsmit:BZ1946216
Oct 14, 2021
Merged

Adds a prerequisite to obtain service principal permissions at the su…#37275
bobfuru merged 1 commit intoopenshift:mainfrom
stevsmit:BZ1946216

Conversation

@stevsmit
Copy link
Copy Markdown
Member

@stevsmit stevsmit commented Oct 8, 2021

@openshift-ci openshift-ci Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 8, 2021
@openshift-ci openshift-ci Bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 8, 2021
@stevsmit stevsmit changed the base branch from enterprise-4.7 to main October 8, 2021 19:47
@openshift-ci openshift-ci Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 8, 2021
@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 8, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 0b744c535b8fe5872fadd756f388e24014b8d624

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/61609fd07a1e8600083468fd

😎 Browse the preview: https://deploy-preview-37275--osdocs.netlify.app

@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 8, 2021
…bscription levels as users may run into issues creating config files
@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 8, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 530d070413379a2169a46aa4975e883657d8daac

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/6160a0063c172f00076213c5

😎 Browse the preview: https://deploy-preview-37275--osdocs.netlify.app

@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 8, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: ee1dc59

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/6160a0a93ad94800080bba52

😎 Browse the preview: https://deploy-preview-37275--osdocs.netlify.app

@bobfuru bobfuru added branch/enterprise-4.7 branch/enterprise-4.9 peer-review-done Signifies that the peer review team has reviewed this PR labels Oct 8, 2021
@bobfuru bobfuru added this to the Next Release milestone Oct 8, 2021
@bobfuru
Copy link
Copy Markdown
Contributor

bobfuru commented Oct 8, 2021

LGTM!

@stevsmit
Copy link
Copy Markdown
Member Author

@gpei please review :)

@gpei
Copy link
Copy Markdown

gpei commented Oct 13, 2021

@stevsmit Amogh from QE team has reviewed the PR and verified the bug https://bugzilla.redhat.com/show_bug.cgi?id=1946216

@bobfuru bobfuru merged commit 886a92f into openshift:main Oct 14, 2021
@bobfuru
Copy link
Copy Markdown
Contributor

bobfuru commented Oct 14, 2021

/cherrypick enterprise-4.9

@bobfuru
Copy link
Copy Markdown
Contributor

bobfuru commented Oct 14, 2021

/cherrypick enterprise-4.8

@bobfuru
Copy link
Copy Markdown
Contributor

bobfuru commented Oct 14, 2021

/cherrypick enterprise-4.7

@openshift-cherrypick-robot
Copy link
Copy Markdown

@bobfuru: new pull request created: #37502

Details

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@bobfuru: new pull request created: #37503

Details

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@bobfuru: new pull request created: #37504

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.7 branch/enterprise-4.8 branch/enterprise-4.9 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants