Skip to content

TELCODOCS-310: Update the OCP version number in KNI/Telco contents#37519

Merged
jeana-redhat merged 1 commit intoopenshift:mainfrom
ogradyp:TELCODOCS-310
Oct 15, 2021
Merged

TELCODOCS-310: Update the OCP version number in KNI/Telco contents#37519
jeana-redhat merged 1 commit intoopenshift:mainfrom
ogradyp:TELCODOCS-310

Conversation

@ogradyp
Copy link
Contributor

@ogradyp ogradyp commented Oct 14, 2021 •
edited
Loading

Applies to Main AND the Enterprise-4.9 branch

Jira: https://issues.redhat.com/browse/TELCODOCS-310

Browse the preview here: https://deploy-preview-37519--osdocs.netlify.app

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 14, 2021
@netlify
Copy link

netlify bot commented Oct 14, 2021 •
edited
Loading

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: eb567ce

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/6169a1206f8ecd000854d330

😎 Browse the preview: https://deploy-preview-37519--osdocs.netlify.app/openshift-enterprise/latest/scalability_and_performance/cnf-performance-addon-operator-for-low-latency-nodes

@evgenLevin
Copy link

evgenLevin commented Oct 14, 2021

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Oct 14, 2021

@evgenLevin: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ctauchen
ctauchen reviewed Oct 14, 2021
View reviewed changes
Copy link
Contributor

@ctauchen ctauchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2021
@ctauchen
Copy link
Contributor

ctauchen commented Oct 14, 2021

FYi @kalexand-rh

This PR duplicates some of the 4.8-->4.9 changes in your PR #36974.

So .. I guess it's a race to see who merges first?

@kalexand-rh
Copy link
Contributor

kalexand-rh commented Oct 14, 2021

So .. I guess it's a race to see who merges first?

@ctauchen, I have an exception and will probably merge tomorrow, so I'll look forward to rebasing this in. :)

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2021
@openshift-ci
Copy link

openshift-ci bot commented Oct 15, 2021

New changes are detected. LGTM label has been removed.

@sjstout
Copy link

sjstout commented Oct 15, 2021

LGTM! good to merge :)

jeana-redhat
jeana-redhat approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge approval 👍

@jeana-redhat jeana-redhat added branch/enterprise-4.9 peer-review-done Signifies that the peer review team has reviewed this PR labels Oct 15, 2021
@jeana-redhat jeana-redhat added this to the Future Release milestone Oct 15, 2021
@jeana-redhat jeana-redhat removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 15, 2021
@jeana-redhat
Copy link
Contributor

jeana-redhat commented Oct 15, 2021

Removed WIP because this seems to be ready based on past discussion

@jeana-redhat jeana-redhat changed the title WIP TELCODOCS-310: Update the OCP version number in KNI/Telco contents TELCODOCS-310: Update the OCP version number in KNI/Telco contents Oct 15, 2021
@jeana-redhat jeana-redhat merged commit 6e512e9 into openshift:main Oct 15, 2021
@jeana-redhat
Copy link
Contributor

jeana-redhat commented Oct 15, 2021

/cherrypick enterprise-4.9

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 15, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 15, 2021

@jeana-redhat: new pull request created: #37589

Details

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeana-redhat jeana-redhat jeana-redhat approved these changes

+1 more reviewer

@ctauchen ctauchen ctauchen left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@ctauchen ctauchen

Labels

branch/enterprise-4.9 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.9 GA

Development

Successfully merging this pull request may close these issues.

8 participants

@ogradyp @evgenLevin @ctauchen @kalexand-rh @sjstout @jeana-redhat @openshift-cherrypick-robot @vikram-redhat