[enterprise-4.8] modules: Drop 'upstream' from ClusterVersion examples#38889
Merged
kalexand-rh merged 1 commit intoopenshift:enterprise-4.8from Nov 18, 2021
Conversation
In 4.1, the installer used to explicitly set upstream to our default URI. But in openshift/installer#c9095b34518a0 (data/manifests/bootkube/cvo-overrides: Drop the explicit update, 2020-08-28, openshift/installer#4112), which landed in 4.7 and was not backported, I'd stopped doing that. In clusters born in 4.7 and later, the installer will leave upstream unset, and the cluster-version operator will default to making a reasonable choice. We still need to talk about explicit upstreams in the case where folks are pointing their cluster at a local OpenShift Update Service, but this commit drops the properties where we were incidentally pointing at the default, Red-Hat-hosted location, because explicitly setting that value is an anti-pattern that makes it harder for clusters to adapt if we try to move our default location elsewhere in the future.
openshift-ci
bot
added
the
size/XS
|
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: e67b5dd 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/61957aa2faa7260007515355 😎 Browse the preview: https://deploy-preview-38889--osdocs.netlify.app |
kalexand-rh
changed the title
Contributor
|
/cherrypick enterprise-4.7 |
|
@kalexand-rh: #38889 failed to apply on top of branch "enterprise-4.7": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manually backporting #35567 to 4.8.