Skip to content

GH38823: Fixed typo in namespace selector label for OpenShift SDN [Fixes #38823]#38897

Merged
ctauchen merged 1 commit intoopenshift:mainfrom
ctauchen:GH38823
Nov 29, 2021
Merged

GH38823: Fixed typo in namespace selector label for OpenShift SDN [Fixes #38823]#38897
ctauchen merged 1 commit intoopenshift:mainfrom
ctauchen:GH38823

Conversation

@ctauchen
Copy link
Copy Markdown
Contributor

@ctauchen ctauchen commented Nov 18, 2021

Fixes #38823

@jon2100 discovered a problem in a new format for the namespace selector label for OpenShift SDN. Turned out to be a typo.

This PR fixes the typo.

Applies to versions 4.6 +

QE review: @anuragthehatter Can you take a look?

Preview: https://deploy-preview-38897--osdocs.netlify.app/openshift-enterprise/latest/networking/network_policy/multitenant-network-policy.html#nw-networkpolicy-multitenant-isolation_multitenant-network-policy

See also: #38898 #38283

cc @jboxman

@openshift-ci openshift-ci Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 18, 2021
@ctauchen ctauchen changed the title GH38823: Fixed typo in namespace selector label for OpenShift SDN [Fixes #38832] GH38823: Fixed typo in namespace selector label for OpenShift SDN [Fixes #38823] Nov 18, 2021
@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 18, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: d910d45

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/619656a315b18100072eefdd

😎 Browse the preview: https://deploy-preview-38897--osdocs.netlify.app

Copy link
Copy Markdown

@asood-rh asood-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2021
@ctauchen ctauchen merged commit f074f92 into openshift:main Nov 29, 2021
@ctauchen ctauchen added this to the Next Release milestone Nov 29, 2021
@openshift-cherrypick-robot
Copy link
Copy Markdown

@ctauchen: #38897 failed to apply on top of branch "enterprise-4.6":

Applying: GH38823: Fixed typo in namespace selector label for OpenShift SDN
Using index info to reconstruct a base tree...
M	modules/nw-networkpolicy-multitenant-isolation.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/nw-networkpolicy-multitenant-isolation.adoc
CONFLICT (content): Merge conflict in modules/nw-networkpolicy-multitenant-isolation.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 GH38823: Fixed typo in namespace selector label for OpenShift SDN
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@ctauchen: new pull request created: #39330

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@ctauchen: new pull request created: #39331

Details

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stevsmit
Copy link
Copy Markdown
Member

LGTM. Thanks for fixing.

@ctauchen ctauchen added the peer-review-needed Signifies that the peer review team needs to review this PR label Nov 29, 2021
@stevsmit stevsmit added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 29, 2021
@ctauchen
Copy link
Copy Markdown
Contributor Author

/cherrypick enterprise-4.9

@ctauchen
Copy link
Copy Markdown
Contributor Author

/cherrypick enterprise-4.10

@openshift-cherrypick-robot
Copy link
Copy Markdown

@ctauchen: new pull request created: #39332

Details

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@ctauchen: new pull request created: #39333

Details

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ctauchen
Copy link
Copy Markdown
Contributor Author

/cherrypick enterprise-4.6

@openshift-cherrypick-robot
Copy link
Copy Markdown

@ctauchen: #38897 failed to apply on top of branch "enterprise-4.6":

Applying: GH38823: Fixed typo in namespace selector label for OpenShift SDN
Using index info to reconstruct a base tree...
M	modules/nw-networkpolicy-multitenant-isolation.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/nw-networkpolicy-multitenant-isolation.adoc
CONFLICT (content): Merge conflict in modules/nw-networkpolicy-multitenant-isolation.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 GH38823: Fixed typo in namespace selector label for OpenShift SDN
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 branch/enterprise-4.9 branch/enterprise-4.10 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[enterprise-4.8] Issue in file networking/network_policy/multitenant-network-policy.adoc

4 participants