Skip to content

BZ2051452: Add L2 subnet info to vSphere, RHV, and Openstack prerequisites#43599

Closed
cherraz wants to merge 1 commit intoopenshift:enterprise-4.10from
cherraz:BZ2051452
Closed

BZ2051452: Add L2 subnet info to vSphere, RHV, and Openstack prerequisites#43599
cherraz wants to merge 1 commit intoopenshift:enterprise-4.10from
cherraz:BZ2051452

Conversation

@cherraz
Copy link
Copy Markdown
Contributor

@cherraz cherraz commented Mar 22, 2022 •
edited
Loading

Added a reusable snippet across some vSphere, RHV, and Openstack installer IPI

FIXES BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2051452

PREVIEW:
Openstack

RHV

vSphere

vSphere cloud

VERSIONS: 4.10, 4.9, 4.8, 4.7, 4.6 (it doesn't apply to main)

@openshift-ci openshift-ci Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 22, 2022
@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 22, 2022 •
edited
Loading

✅ Deploy Preview for osdocs ready!

Name Link
🔨 Latest commit 094e732
🔍 Latest deploy log https://app.netlify.com/sites/osdocs/deploys/62544f9334380f00082b4d35
😎 Deploy Preview https://deploy-preview-43599--osdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@cherraz cherraz force-pushed the BZ2051452 branch 2 times, most recently from 50f0ef2 to 34c6282 Compare March 25, 2022 09:53
@openshift-ci openshift-ci Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 25, 2022
@cherraz cherraz force-pushed the BZ2051452 branch 2 times, most recently from c7daaef to f47e270 Compare March 25, 2022 10:07
@cherraz
Copy link
Copy Markdown
Contributor Author

cherraz commented Mar 25, 2022

Hi @cybertron, made changes to the PR as you adviced. Could you please take a look at this new one and see everything looks fine? It's basically one file with a sentence and a link. The other files are the IPI sections including this sentence. Thank you!

cybertron
cybertron reviewed Apr 4, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@cybertron cybertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I thought I had already looked at this. A couple of thoughts inline.

Comment thread snippets/installing-subnet-requirements.adoc Outdated
@kelbrown20
Copy link
Copy Markdown
Contributor

kelbrown20 commented Apr 7, 2022

Looks great! LGTM

@stevsmit
Copy link
Copy Markdown
Member

stevsmit commented Apr 7, 2022

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2022
@stevsmit stevsmit added this to the Next Release milestone Apr 7, 2022
@cybertron
Copy link
Copy Markdown
Member

cybertron commented Apr 7, 2022

/lgtm

Thanks!

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2022
@cherraz
Copy link
Copy Markdown
Contributor Author

cherraz commented Apr 11, 2022

@zhaozhanqi Hi! When you can, please let me know if you approve this PR so that we can merge it. Thanks!

@jinyunma
Copy link
Copy Markdown

jinyunma commented Apr 11, 2022 •
edited
Loading

the update looks good to me for vsphere part.

I checked that all IPI installation on VMC docs (under "Installing on VMC") are not applied the update. Those docs also need to be updated.

Another question is that can we add KCS link directly in official doc?

@cherraz
Copy link
Copy Markdown
Contributor Author

cherraz commented Apr 11, 2022

the update looks good to me for vsphere part.

I checked that all IPI installation on VMC docs (under "Installing on VMC") are not applied the update. Those docs also need to be updated.

Another question is that can we add KCS link directly in official doc?

Hi! Thank you for checking this -- I'll add the note to those sections as well.

About the link, yeah, this is not the first link to the knowledge base in the docset, so that should be ok :)

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2022
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 11, 2022

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 11, 2022
@jinyunma
Copy link
Copy Markdown

jinyunma commented Apr 12, 2022

@cherraz thanks for updating. The changes look good to me now for vsphere part.

@cherraz
Copy link
Copy Markdown
Contributor Author

cherraz commented Apr 12, 2022

Waiting for RHV and Openstack QEs to comment or give lgtm.

@jinyunma jinyunma mentioned this pull request May 5, 2022
Closed
mandre
mandre reviewed May 17, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The note looks good to me, however shouldn't we include it in UPI installation method as well? It also seems to me it's missing from a couple of OpenStack doc (SR-IOV and OVS-DPDK).

@cybertron
Copy link
Copy Markdown
Member

cybertron commented May 17, 2022

This isn't relevant for UPI because it doesn't run keepalived. It also isn't necessary going forward because we switched everyone to unicast keepalived so it won't conflict.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Aug 16, 2022

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 16, 2022
@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Sep 19, 2022

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci Bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 19, 2022
@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Oct 19, 2022

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci Bot closed this Oct 19, 2022
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Oct 19, 2022

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@mandre mandre mandre left review comments

@cybertron cybertron cybertron left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@cybertron cybertron

@stevsmit stevsmit

Labels

branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 branch/enterprise-4.9 branch/enterprise-4.10 lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

8 participants

@cherraz @kelbrown20 @stevsmit @cybertron @jinyunma @openshift-bot @mandre @kalexand-rh