SRVCOM-1728: Updating Kafka abstracts for Jupiter guidelines by abrennan89 · Pull Request #44552 · openshift/openshift-docs

abrennan89 · 2022-04-13T16:19:05Z

Jira: https://issues.redhat.com/browse/SRVCOM-1728

Applies for OCP 4.6+

Direct previews:

netlify · 2022-04-13T16:21:09Z

✅ Deploy Preview for osdocs ready!

Name	Link
🔨 Latest commit	`7b01869`
🔍 Latest deploy log	https://app.netlify.com/sites/osdocs/deploys/62602e0de5b41e00084a18cd
😎 Deploy Preview	https://deploy-preview-44552--osdocs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

serverless/develop/serverless-kafka-developer.adoc

serverless/admin_guide/serverless-kafka-admin.adoc

matzew · 2022-04-19T06:33:48Z

modules/serverless-install-kafka-odc.adoc

Additionally, to use the Kafka channel, broker or sink, you must specify the bootstrap servers.

For the broker: the "bootstrap" server can be overriden, with a ConfigMap that is in the "user namespace", and the broker referencing to that one (my original PR for the kafka broker doc had text for using the default global config, and a custom (or overriden) config/broker.

For the kafka sink, the bootstrap URL is only needed on that CR file - not on Knative Kafka

@matzew can you open a follow up Jira for this please, it's out of scope for this PR which is just intended to get our docs in line with Jupiter requirements. This is previously existing content that was just moved slightly in this PR.

jrangelramos

QE Approved

modules/serverless-install-kafka-odc.adoc

michaelryanpeter

I agree with Tami's comment regarding a serial comma. Otherwise, I left a minimalism suggestion regarding the sentence about the declarative API.

Otherwise, LGTM!

(And a friendly reminder to squash your commits once your edits are made) :)

modules/serverless-install-kafka-odc.adoc

modules/serverless-kafka-source-yaml.adoc

abrennan89 · 2022-04-20T16:07:21Z

/cherrypick enterprise-4.9

abrennan89 · 2022-04-20T16:07:27Z

/cherrypick enterprise-4.10

abrennan89 · 2022-04-20T16:07:33Z

/cherrypick enterprise-4.11

openshift-cherrypick-robot · 2022-04-20T16:08:03Z

@abrennan89: new pull request created: #44759

Details

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2022-04-20T16:08:08Z

@abrennan89: new pull request created: #44760

Details

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2022-04-20T16:08:14Z

@abrennan89: new pull request created: #44761

Details

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

abrennan89 added branch/enterprise-4.6 serverless Label for all Serverless PRs branch/enterprise-4.7 branch/enterprise-4.8 branch/enterprise-4.9 branch/enterprise-4.10 branch/enterprise-4.11 labels Apr 13, 2022

abrennan89 added this to the Next Release milestone Apr 13, 2022

openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 13, 2022

openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 13, 2022

abrennan89 force-pushed the kafkaAbstracts branch 2 times, most recently from e3381a9 to 89896c6 Compare April 14, 2022 15:56

abrennan89 changed the title ~~[WIP] SRVCOM-1728: Updating Kafka abstracts for Jupiter guidelines~~ SRVCOM-1728: Updating Kafka abstracts for Jupiter guidelines Apr 14, 2022

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 14, 2022

matzew reviewed Apr 19, 2022

View reviewed changes

serverless/develop/serverless-kafka-developer.adoc Outdated Show resolved Hide resolved

matzew reviewed Apr 19, 2022

View reviewed changes

serverless/admin_guide/serverless-kafka-admin.adoc Outdated Show resolved Hide resolved

matzew reviewed Apr 19, 2022

View reviewed changes

abrennan89 force-pushed the kafkaAbstracts branch from 89896c6 to 7eb5b9e Compare April 19, 2022 13:33

jrangelramos reviewed Apr 19, 2022

View reviewed changes

tmalove reviewed Apr 19, 2022

View reviewed changes

modules/serverless-install-kafka-odc.adoc Outdated Show resolved Hide resolved

michaelryanpeter reviewed Apr 19, 2022

View reviewed changes

modules/serverless-install-kafka-odc.adoc Outdated Show resolved Hide resolved

modules/serverless-kafka-source-yaml.adoc Outdated Show resolved Hide resolved

michaelryanpeter added peer-review-needed Signifies that the peer review team needs to review this PR peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 19, 2022

abrennan89 force-pushed the kafkaAbstracts branch from 7eb5b9e to e8c003b Compare April 20, 2022 15:59

SRVCOM-1728: Updating Kafka abstracts for Jupiter guidelines

7b01869

abrennan89 force-pushed the kafkaAbstracts branch from e8c003b to 7b01869 Compare April 20, 2022 16:00

abrennan89 merged commit 9eec0d4 into openshift:main Apr 20, 2022

openshift-cherrypick-robot mentioned this pull request Apr 20, 2022

[enterprise-4.9] SRVCOM-1728: Updating Kafka abstracts for Jupiter guidelines #44759

Merged

openshift-cherrypick-robot mentioned this pull request Apr 20, 2022

[enterprise-4.10] SRVCOM-1728: Updating Kafka abstracts for Jupiter guidelines #44760

Merged

openshift-cherrypick-robot mentioned this pull request Apr 20, 2022

[enterprise-4.11] SRVCOM-1728: Updating Kafka abstracts for Jupiter guidelines #44761

Merged

abrennan89 deleted the kafkaAbstracts branch June 30, 2022 14:57

Conversation

abrennan89 commented Apr 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Apr 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for osdocs ready!

Uh oh!

Uh oh!

Uh oh!

matzew Apr 19, 2022

Choose a reason for hiding this comment

Uh oh!

abrennan89 Apr 19, 2022

Choose a reason for hiding this comment

Uh oh!

jrangelramos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

michaelryanpeter left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

abrennan89 commented Apr 20, 2022

Uh oh!

abrennan89 commented Apr 20, 2022

Uh oh!

abrennan89 commented Apr 20, 2022

Uh oh!

openshift-cherrypick-robot commented Apr 20, 2022

Uh oh!

openshift-cherrypick-robot commented Apr 20, 2022

Uh oh!

openshift-cherrypick-robot commented Apr 20, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

abrennan89 commented Apr 13, 2022 •

edited

Loading

netlify bot commented Apr 13, 2022 •

edited

Loading

michaelryanpeter left a comment •

edited

Loading