Skip to content

OSDOCS-3605: Added oc adm upgrade channel command#45326

Merged
jeana-redhat merged 1 commit intoopenshift:mainfrom
darshan-nagaraj:OSDOCS-3605
May 25, 2022
Merged

OSDOCS-3605: Added oc adm upgrade channel command#45326
jeana-redhat merged 1 commit intoopenshift:mainfrom
darshan-nagaraj:OSDOCS-3605

Conversation

@darshan-nagaraj
Copy link
Contributor

@darshan-nagaraj darshan-nagaraj commented May 4, 2022 •
edited
Loading

Version(s): 4.10 +

Issue: https://issues.redhat.com/browse/OSDOCS-3605

Link to docs preview: https://deploy-preview-45326--osdocs.netlify.app/openshift-enterprise/latest/updating/updating-cluster-cli.html#update-upgrading-cli_updating-cluster-cli

Additional information: @LalatenduMohanty Could you please review and let me know your feedback. After your ack, I will open another PR for 4.9.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 4, 2022
@netlify
Copy link

netlify bot commented May 4, 2022 •
edited
Loading

✅ Deploy Preview for osdocs ready!

Name Link
🔨 Latest commit 7bfee24
🔍 Latest deploy log https://app.netlify.com/sites/osdocs/deploys/628b59e8aa34de00088aba84
😎 Deploy Preview https://deploy-preview-45326--osdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 4, 2022
@darshan-nagaraj darshan-nagaraj changed the title Added oc adm upgrade channel command OSDOCS-3605: Added oc adm upgrade channel command May 4, 2022
wking
wking reviewed May 5, 2022
View reviewed changes
wking
wking reviewed May 5, 2022
View reviewed changes
LalatenduMohanty
LalatenduMohanty suggested changes May 5, 2022
View reviewed changes
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 18, 2022
wking
wking reviewed May 18, 2022
View reviewed changes
wking
wking reviewed May 18, 2022
View reviewed changes
@darshan-nagaraj
Copy link
Contributor Author

darshan-nagaraj commented May 19, 2022

@jiajliu please review the PR and provide QE ack. Thanks

@darshan-nagaraj darshan-nagaraj force-pushed the OSDOCS-3605 branch 2 times, most recently from e610812 to 24fcc27 Compare May 19, 2022 06:50
@jiajliu
Copy link

jiajliu commented May 19, 2022

@jiajliu please review the PR and provide QE ack. Thanks

Generally lgtm, but still a tiny issue in #45326 (comment)

jeana-redhat
jeana-redhat reviewed May 19, 2022
View reviewed changes
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good overall, just have to work around the xref limitation in our tooling. I included steps for this :)

@jeana-redhat jeana-redhat added peer-review-done Signifies that the peer review team has reviewed this PR branch/enterprise-4.10 branch/enterprise-4.11 labels May 19, 2022
@jeana-redhat jeana-redhat added this to the Next Release milestone May 19, 2022
wking
wking approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Still more work to do in this file, but as it stands this PR is ratcheting us towards a better place.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2022
@jeana-redhat jeana-redhat merged commit 6a36f4d into openshift:main May 25, 2022
@jeana-redhat
Copy link
Contributor

jeana-redhat commented May 25, 2022

/cherrypick enterprise-4.11

@jeana-redhat
Copy link
Contributor

jeana-redhat commented May 25, 2022

/cherrypick enterprise-4.10

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 25, 2022
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented May 25, 2022

@jeana-redhat: new pull request created: #46013

Details

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 25, 2022
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented May 25, 2022

@jeana-redhat: new pull request created: #46014

Details

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@darshan-nagaraj darshan-nagaraj mentioned this pull request Jun 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeana-redhat jeana-redhat jeana-redhat left review comments

+3 more reviewers

@LalatenduMohanty LalatenduMohanty LalatenduMohanty requested changes

@jiajliu jiajliu jiajliu left review comments

@wking wking wking approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@wking wking

Labels

branch/enterprise-4.10 branch/enterprise-4.11 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

6 participants

@darshan-nagaraj @jiajliu @jeana-redhat @openshift-cherrypick-robot @wking @LalatenduMohanty