Skip to content

BZ-2095294: Renamed IBM Cloud to IBM Cloud VPC#46545

Merged
maxwelldb merged 1 commit intoopenshift:mainfrom
mjpytlak:IBMCloudVPC
Jun 24, 2022
Merged

BZ-2095294: Renamed IBM Cloud to IBM Cloud VPC#46545
maxwelldb merged 1 commit intoopenshift:mainfrom
mjpytlak:IBMCloudVPC

Conversation

@mjpytlak
Copy link
Copy Markdown
Contributor

@mjpytlak mjpytlak commented Jun 10, 2022

@openshift-ci openshift-ci Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 10, 2022
@mjpytlak mjpytlak changed the title BZ-2095294: Relabled IBM Cloud to IBM Cloud VPC BZ-2095294: Renamed IBM Cloud to IBM Cloud VPC Jun 10, 2022
@mjpytlak
Copy link
Copy Markdown
Contributor Author

@makentenza Should be good to go here. PTAL. Thanks!

@makentenza
Copy link
Copy Markdown
Contributor

Thanks @mjpytlak, I think we need to extend the change to the text of every section you have changed. Out from the Supported installation methods for different platforms section I still can see a lot of references for IBM Cloud in the text for the other sections. Can we replace IBM Cloud for IBM Cloud VPC on every reference we have to IBM Cloud in those sections?

@openshift-ci openshift-ci Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 13, 2022
@mjpytlak
Copy link
Copy Markdown
Contributor Author

mjpytlak commented Jun 13, 2022

Can we replace IBM Cloud for IBM Cloud VPC on every reference we have to IBM Cloud in those sections?

@makentenza This should take care of it. PTAL.

@makentenza
Copy link
Copy Markdown
Contributor

Thanks @mjpytlak, it LGTM!

Copy link
Copy Markdown
Contributor

@sheriff-rh sheriff-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maxwelldb maxwelldb added peer-review-done Signifies that the peer review team has reviewed this PR branch/enterprise-4.10 branch/enterprise-4.11 labels Jun 24, 2022
@maxwelldb maxwelldb added this to the Next Release milestone Jun 24, 2022
@maxwelldb maxwelldb merged commit 7bba8c8 into openshift:main Jun 24, 2022
@maxwelldb
Copy link
Copy Markdown
Contributor

/cherry-pick enterprise-4.10

@maxwelldb
Copy link
Copy Markdown
Contributor

/cherry-pick enterprise-4.11

@openshift-cherrypick-robot
Copy link
Copy Markdown

@maxwelldb: new pull request created: #47034

Details

In response to this:

/cherry-pick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@maxwelldb: new pull request created: #47035

Details

In response to this:

/cherry-pick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.10 branch/enterprise-4.11 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants