Skip to content

BZ2104374: Removed period (.) as supported character from metadata.name#49100

Merged
mjpytlak merged 1 commit intoopenshift:mainfrom
mjpytlak:bz2104374
Aug 29, 2022
Merged

BZ2104374: Removed period (.) as supported character from metadata.name#49100
mjpytlak merged 1 commit intoopenshift:mainfrom
mjpytlak:bz2104374

Conversation

@mjpytlak
Copy link
Copy Markdown
Contributor

@mjpytlak mjpytlak commented Aug 15, 2022

Version(s):
CP to 4.6+

Issue:
This PR addresses BZ2104374

Link to docs preview:

@openshift-ci openshift-ci Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 15, 2022
@mjpytlak
Copy link
Copy Markdown
Contributor Author

mjpytlak commented Aug 15, 2022

@sgaoshang Exact same content from the Nutanix update [1]. Simply updated the conditions to include the change to the respective content in the vSphere and baremetal content.

@pamoedom and @jinyunma Small update to supported characters for metadata.name for vSphere and baremetal. PTAL. Thanks.

[1] #44537 (comment)

@sgaoshang
Copy link
Copy Markdown

/lgtm, thanks

@jinyunma
Copy link
Copy Markdown

@mjpytlak thanks for addressing the issues, I checked that the value of metadata.name is only updated in related docs under Installing on vSphere, also need to update same part under Installing on VMC

@mjpytlak
Copy link
Copy Markdown
Contributor Author

also need to update same part under Installing on VMC

Thank you @jinyunma. Updated the VMC content.

@jinyunma
Copy link
Copy Markdown

@mjpytlak thanks for the update, then it looks good to me for vsphere/vmc part.

@pamoedom
Copy link
Copy Markdown

LGTM for the BM part, thanks @mjpytlak

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2022
Copy link
Copy Markdown
Contributor

@kelbrown20 kelbrown20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renders and everything looks great!
/lgtm

@mjpytlak
Copy link
Copy Markdown
Contributor Author

/cherrypick enterprise-4.12

@openshift-cherrypick-robot
Copy link
Copy Markdown

@mjpytlak: new pull request created: #49699

Details

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mjpytlak
Copy link
Copy Markdown
Contributor Author

/cherrypick enterprise-4.11

@mjpytlak
Copy link
Copy Markdown
Contributor Author

/cherrypick enterprise-4.10

@mjpytlak
Copy link
Copy Markdown
Contributor Author

/cherrypick enterprise-4.9

@mjpytlak
Copy link
Copy Markdown
Contributor Author

/cherrypick enterprise-4.8

@mjpytlak
Copy link
Copy Markdown
Contributor Author

/cherrypick enterprise-4.7

@openshift-cherrypick-robot
Copy link
Copy Markdown

@mjpytlak: new pull request created: #49700

Details

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mjpytlak
Copy link
Copy Markdown
Contributor Author

/cherrypick enterprise-4.6

@openshift-cherrypick-robot
Copy link
Copy Markdown

@mjpytlak: #49100 failed to apply on top of branch "enterprise-4.10":

Applying: BZ2104374: Removed period (.) as supported character from metadata.name
Using index info to reconstruct a base tree...
M	modules/installation-configuration-parameters.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/installation-configuration-parameters.adoc
CONFLICT (content): Merge conflict in modules/installation-configuration-parameters.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 BZ2104374: Removed period (.) as supported character from metadata.name
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@mjpytlak: #49100 failed to apply on top of branch "enterprise-4.9":

Applying: BZ2104374: Removed period (.) as supported character from metadata.name
Using index info to reconstruct a base tree...
M	modules/installation-configuration-parameters.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/installation-configuration-parameters.adoc
CONFLICT (content): Merge conflict in modules/installation-configuration-parameters.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 BZ2104374: Removed period (.) as supported character from metadata.name
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@mjpytlak: #49100 failed to apply on top of branch "enterprise-4.8":

Applying: BZ2104374: Removed period (.) as supported character from metadata.name
Using index info to reconstruct a base tree...
M	modules/installation-configuration-parameters.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/installation-configuration-parameters.adoc
CONFLICT (content): Merge conflict in modules/installation-configuration-parameters.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 BZ2104374: Removed period (.) as supported character from metadata.name
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@mjpytlak: #49100 failed to apply on top of branch "enterprise-4.7":

Applying: BZ2104374: Removed period (.) as supported character from metadata.name
Using index info to reconstruct a base tree...
M	modules/installation-configuration-parameters.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/installation-configuration-parameters.adoc
CONFLICT (content): Merge conflict in modules/installation-configuration-parameters.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 BZ2104374: Removed period (.) as supported character from metadata.name
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@mjpytlak: #49100 failed to apply on top of branch "enterprise-4.6":

Applying: BZ2104374: Removed period (.) as supported character from metadata.name
Using index info to reconstruct a base tree...
M	modules/installation-configuration-parameters.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/installation-configuration-parameters.adoc
CONFLICT (content): Merge conflict in modules/installation-configuration-parameters.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 BZ2104374: Removed period (.) as supported character from metadata.name
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 branch/enterprise-4.9 branch/enterprise-4.10 branch/enterprise-4.11 branch/enterprise-4.12 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants