Skip to content

OCPBUGS#760 Added N1 machine type prerequisite and note#49803

Merged
mjpytlak merged 1 commit intoopenshift:enterprise-4.11from
mjpytlak:ocpbugs-760
Sep 12, 2022
Merged

OCPBUGS#760 Added N1 machine type prerequisite and note#49803
mjpytlak merged 1 commit intoopenshift:enterprise-4.11from
mjpytlak:ocpbugs-760

Conversation

@mjpytlak
Copy link
Copy Markdown
Contributor

@mjpytlak mjpytlak commented Aug 31, 2022 •
edited
Loading

Version(s):
4.11

Issue:
This issue addresses OCPBUGS-760

Link to docs preview:
Prerequisites

Additional information:
This is the first of two [1] PR to address this issue, as it applies to 4.11 and 4.10 only.

[1] 4.10 #49804

@openshift-ci openshift-ci Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 31, 2022
@mjpytlak mjpytlak added this to the Continuous Release milestone Aug 31, 2022
@mjpytlak mjpytlak added peer-review-needed Signifies that the peer review team needs to review this PR branch/enterprise-4.11 labels Aug 31, 2022
@mjpytlak mjpytlak mentioned this pull request Aug 31, 2022
Merged
@jianli-wei
Copy link
Copy Markdown

jianli-wei commented Sep 1, 2022

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2022
@mjpytlak
Copy link
Copy Markdown
Contributor Author

mjpytlak commented Sep 1, 2022 •
edited
Loading

@jstuever Looks like I mentioned you twice on the 4.10, instead of here. PTAL. Thanks.

@rna-afk
Copy link
Copy Markdown

rna-afk commented Sep 6, 2022

LGTM I'm not sure about the releases but we did change the default from n1 to n2.
openshift/installer#6058

@mjpytlak
Copy link
Copy Markdown
Contributor Author

mjpytlak commented Sep 12, 2022

LGTM I'm not sure about the releases but we did change the default from n1 to n2. openshift/installer#6058

Thanks for looking at this. We default to n2 in 4.12, which is why this statement added to 4.10 and 4.11.

bscott-rh
bscott-rh approved these changes Sep 12, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@bscott-rh bscott-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One question - is there any justification to putting N1 in monospace/codeblock formatting vs. having it in regular formatting?

@mjpytlak
Copy link
Copy Markdown
Contributor Author

mjpytlak commented Sep 12, 2022 •
edited
Loading

LGTM. One question - is there any justification to putting N1 in monospace/codeblock formatting vs. having it in regular formatting?

That is a good point. I will update both PRs to use N1.

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2022
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Sep 12, 2022

New changes are detected. LGTM label has been removed.

bscott-rh
bscott-rh approved these changes Sep 12, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@bscott-rh bscott-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mjpytlak mjpytlak added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Sep 12, 2022
@mjpytlak mjpytlak merged commit 358d62c into openshift:enterprise-4.11 Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bscott-rh bscott-rh bscott-rh approved these changes

Assignees

@jianli-wei jianli-wei

Labels

branch/enterprise-4.11 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

4 participants

@mjpytlak @jianli-wei @rna-afk @bscott-rh