Updated custom builder description#508
Conversation
|
lgtm for now, but ultimately needs more fleshing out about what is really expected of a custom builder (read the build definition env variable, do whatever you want to do, output artifacts to the build's output location if one is defined, etc) |
soltysh
force-pushed
the
492_followup
branch
2 times, most recently
from
7298c2b to
8966f9b
Compare
|
@bparees I've added a few words about how the process should look like, ptal. |
|
Pending ack from @bparees, I'm good with merging this and following up with some minor edits to wording. |
creating_images/custom.adoc
Outdated
There was a problem hiding this comment.
this really needs to say "push the image to the output location if the build produces an image and if the output location is defined"
our output is not (currently) a generic destination. Whether in the future we want to make it one, or we just say "if you want to output to an ftp server, define an env variable in your buildconfig that the custom builder can look at to know where to upload to" i don't particularly care.
creating_images/custom.adoc
Outdated
There was a problem hiding this comment.
you're still assuming the custom builder builds an image.
this should be "if the product of the build is a new image, push the image to...."
|
lgtm. |
|
@adellape merge? |
Updated custom builder description
3 participants
@bparees as promised in here I'm updating the description. ptal
@adellape fyi