Skip to content

OCPBUGS-3533 Adding note about vfio-pci#52851

Merged
jboxman-rh merged 1 commit intoopenshift:mainfrom
kquinn1204:OCPBUGS-3533
Nov 17, 2022
Merged

OCPBUGS-3533 Adding note about vfio-pci#52851
jboxman-rh merged 1 commit intoopenshift:mainfrom
kquinn1204:OCPBUGS-3533

Conversation

@kquinn1204
Copy link
Copy Markdown
Contributor

@kquinn1204 kquinn1204 commented Nov 16, 2022 •
edited
Loading

@openshift-ci openshift-ci Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 16, 2022
@ocpdocs-previewbot
Copy link
Copy Markdown

ocpdocs-previewbot commented Nov 16, 2022 •
edited
Loading

🤖 Updated build preview is available at:
https://52851--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/3648

@kquinn1204
Copy link
Copy Markdown
Contributor Author

kquinn1204 commented Nov 16, 2022

@SchSeba Can you review this PR. NOTE added in two places

@kquinn1204
Copy link
Copy Markdown
Contributor Author

kquinn1204 commented Nov 16, 2022

@kononovn can you give a LGTM on this update requested by Sebastian please.

SchSeba
SchSeba approved these changes Nov 16, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2022
@kquinn1204
Copy link
Copy Markdown
Contributor Author

kquinn1204 commented Nov 16, 2022

/label telco

@openshift-ci openshift-ci Bot added the telco Label for all Telco PRs label Nov 16, 2022
@kquinn1204
Copy link
Copy Markdown
Contributor Author

kquinn1204 commented Nov 16, 2022

/label peer-review-needed added clarification requested by developer

@kquinn1204
Copy link
Copy Markdown
Contributor Author

kquinn1204 commented Nov 16, 2022

/label peer-review-needed

@openshift-ci openshift-ci Bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Nov 16, 2022
@kcarmichael08
Copy link
Copy Markdown
Contributor

kcarmichael08 commented Nov 16, 2022

/label peer-review-in-progress

@openshift-ci openshift-ci Bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Nov 16, 2022
@kcarmichael08
Copy link
Copy Markdown
Contributor

kcarmichael08 commented Nov 16, 2022 •
edited
Loading

Hi @kquinn1204 , should the sentence in callout # 9 for the YAML file in those 2 sections also be changed to remove vfio-pci as a supported type?

Optional: The driver type for the virtual functions. The only allowed values are netdevice and vfio-pci.

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2022
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Nov 16, 2022

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 16, 2022
@kquinn1204
Copy link
Copy Markdown
Contributor Author

kquinn1204 commented Nov 16, 2022

@kcarmichael08 made that update. I believe support is coming back for this, so will need to reinstate.

@kcarmichael08
Copy link
Copy Markdown
Contributor

kcarmichael08 commented Nov 16, 2022

LGTM

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

@openshift-ci openshift-ci Bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 16, 2022
@kquinn1204
Copy link
Copy Markdown
Contributor Author

kquinn1204 commented Nov 17, 2022

/label merge-review-needed

@openshift-ci openshift-ci Bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Nov 17, 2022
@jboxman-rh jboxman-rh added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Nov 17, 2022
@jboxman-rh jboxman-rh added this to the Continuous Release milestone Nov 17, 2022
@jboxman-rh jboxman-rh merged commit 3dc58da into openshift:main Nov 17, 2022
@jboxman-rh
Copy link
Copy Markdown

jboxman-rh commented Nov 17, 2022

/cherry-pick enterprise-4.12

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 17, 2022
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Nov 17, 2022

@jboxman-rh: new pull request created: #52935

Details

In response to this:

/cherry-pick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jboxman-rh
Copy link
Copy Markdown

jboxman-rh commented Nov 17, 2022

/cherry-pick enterprise-4.11

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 17, 2022
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Nov 17, 2022

@jboxman-rh: new pull request created: #52936

Details

In response to this:

/cherry-pick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jboxman-rh jboxman-rh removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@SchSeba SchSeba SchSeba approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@SchSeba SchSeba

Labels

branch/enterprise-4.11 branch/enterprise-4.12 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files. telco Label for all Telco PRs

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

6 participants

@kquinn1204 @ocpdocs-previewbot @kcarmichael08 @jboxman-rh @openshift-cherrypick-robot @SchSeba