modules/update-upgrading-cli: Use 'oc adm upgrade' for current status by wking · Pull Request #53054 · openshift/openshift-docs

wking · 2022-11-21T19:04:22Z

It's our command-line interface for pretty-printing the current ClusterVersion status. And customers may not have jq installed, and we shouldn't be asking them to install it.

Preview.

ocpdocs-previewbot · 2022-11-21T19:10:29Z

🤖 Updated build preview is available at:
https://53054--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/4190

kalexand-rh

@jiajliu or @shellyyang1989, will you PTAL and confirm which versions this change applies to?

It's our command-line interface for pretty-printing the current ClusterVersion status. And customers may not have 'jq' installed, and we shouldn't be asking them to install it.

wking · 2022-11-28T22:27:01Z

... confirm which versions this change applies to?

This could go back to 4.8, which currently requires jq as a nominal prerequisite, and 4.7 and earlier are already end-off-life. I'm agnostic about how far it actually gets picked back though, since we've asked folks to install jq for quite a while now, and only recently had @obrown1205 identified it as a rough edge that could use smoothing off.

shellyyang1989 · 2022-11-29T06:00:00Z

/lgtm

BTW, the cluster version in the example needs to be updated based on which version the change goes to.

obrown1205 · 2023-01-06T20:20:28Z

/label peer-review-needed

GroceryBoyJr · 2023-01-06T20:43:16Z

/remove-label peer-review-needed
/label peer-review-in-progress

GroceryBoyJr

/LGTM

GroceryBoyJr · 2023-01-06T20:46:47Z

/remove-label peer-review-in-progress
/label peer-review-done

shellyyang1989 · 2023-01-09T11:16:17Z

If it goes to 4.11, it looks good to me. Or else the cluster version in the example is worth to update accordingly.

kalexand-rh · 2023-01-09T13:24:01Z

Then this will need a separate PR for 4.12 and any other versions that you want to backport it to.

obrown1205 · 2023-01-19T16:17:44Z

@wking I'm going to create another PR to include your changes here and avoid the merge conflicts from 67e04c2#diff-a4543a07ef809868d1b552e88f1c5a5b4dbbc99a3ff5c769ec4ad63cd55d0b4dL131-R131
keeping this open for reference

openshift-merge-robot · 2023-01-19T16:17:54Z

@wking: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2023-04-20T09:00:20Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot · 2023-05-21T00:30:58Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

openshift-bot · 2023-06-20T08:01:05Z

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci · 2023-06-20T08:01:17Z

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 21, 2022

kalexand-rh reviewed Nov 28, 2022

View reviewed changes

Comment thread modules/update-upgrading-cli.adoc Outdated

Comment thread modules/update-upgrading-cli.adoc Outdated

modules/update-upgrading-cli: Use 'oc adm upgrade' for current status

37cc657

It's our command-line interface for pretty-printing the current ClusterVersion status. And customers may not have 'jq' installed, and we shouldn't be asking them to install it.

wking force-pushed the oc-adm-upgrade-for-current-status branch from 9afeaa7 to 37cc657 Compare November 28, 2022 22:22

openshift-ci Bot assigned shellyyang1989 Nov 29, 2022

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2022

openshift-ci Bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 6, 2023

openshift-ci Bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 6, 2023

GroceryBoyJr reviewed Jan 6, 2023

View reviewed changes

openshift-ci Bot assigned GroceryBoyJr Jan 6, 2023

openshift-ci Bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jan 6, 2023

kalexand-rh added the branch/enterprise-4.11 label Jan 9, 2023

kalexand-rh added this to the Continuous Release milestone Jan 9, 2023

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 19, 2023

obrown1205 mentioned this pull request Jan 20, 2023

GH#53054 modules/update-upgrading-cli: Use 'oc adm upgrade' for current status #55005

Merged

1 task

openshift-ci Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 20, 2023

openshift-ci Bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 21, 2023

openshift-ci Bot closed this Jun 20, 2023

Conversation

wking commented Nov 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ocpdocs-previewbot commented Nov 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kalexand-rh left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

wking commented Nov 28, 2022

Uh oh!

shellyyang1989 commented Nov 29, 2022

Uh oh!

obrown1205 commented Jan 6, 2023

Uh oh!

GroceryBoyJr commented Jan 6, 2023

Uh oh!

GroceryBoyJr left a comment

Choose a reason for hiding this comment

Uh oh!

GroceryBoyJr commented Jan 6, 2023

Uh oh!

shellyyang1989 commented Jan 9, 2023

Uh oh!

kalexand-rh commented Jan 9, 2023

Uh oh!

obrown1205 commented Jan 19, 2023

Uh oh!

openshift-merge-robot commented Jan 19, 2023

Uh oh!

openshift-bot commented Apr 20, 2023

Uh oh!

openshift-bot commented May 21, 2023

Uh oh!

openshift-bot commented Jun 20, 2023

Uh oh!

openshift-ci Bot commented Jun 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

wking commented Nov 21, 2022 •

edited

Loading

ocpdocs-previewbot commented Nov 21, 2022 •

edited

Loading

kalexand-rh left a comment •

edited

Loading