TELCODOCS-1037: Add instructions for nmstate network settings #53122

abhatt-rh · 2022-11-23T01:14:20Z

TELCODOCS-1037: This PR adds instructions for nmstate network settings.

Version(s):
OpenShift 4.11+

Issue:
https://issues.redhat.com/browse/TELCODOCS-1037

Link to docs preview:
https://53122--docspreview.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal_ipi/ipi-install-expanding-the-cluster.html#preparing-the-bare-metal-node_ipi-install-expanding
(Added the instruction as callout 4 under step 4 > Static configuration of the bmh.yml)

QE review:

QE has approved this change.

ocpdocs-previewbot · 2022-11-23T01:20:09Z

🤖 Updated build preview is available at:
https://53122--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/4415

abhatt-rh · 2022-11-24T14:04:02Z

Hi @mrbojangles3 and @cybertron,
Request you to review the changes for the nmsate network setting.

Also, do we need to add a note/warning to the following effect:

Setting nmstate.networkConfig.interfaces.state: down might still leave the interface up and show the DHCP configuration.

Thanks!

cybertron · 2022-11-28T22:57:05Z

modules/ipi-install-preparing-the-bare-metal-node.adoc

I might re-word this a bit so instead of "you want to ignore the DHCP configuration" it says something like "you want to disable an interface". When people are running into this problem it's because they want to disable an interface and they may not necessarily equate ignoring DHCP to disabling it, even though in this case they're the same thing.

Also maybe mention the fact that state must be up? I know it's in the example, but that's the kind of unintuitive part here and it wouldn't hurt to reinforce it in the comment.

I agree with the above re-wording. When I got myself into this situation it was because I wanted to disable an interface. I don't fully grok the NetworkManager interface up/down flow so I defer to @cybertron for that.

Thank you for your comments, @cybertron and @mrbojangles3
I have revised the description. PTAL and let me know for any further changes.

cybertron

/lgtm

abhatt-rh · 2022-11-30T20:13:55Z

@pamoedom Request you to review/approve the changes from QE perspective. Thanks!

pamoedom · 2022-12-01T10:07:43Z

/label qe-approved

abhatt-rh · 2022-12-01T11:15:47Z

/label telco
/label need-peer-review

openshift-ci · 2022-12-01T11:15:51Z

@abhatt-rh: The label(s) /label need-peer-review cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, cnv, dev-tools, distributed-tracing, ims, jira/valid-bug, merge-review-in-progress, merge-review-needed, mtc, multi-arch, oadp, peer-review-done, peer-review-in-progress, peer-review-needed, rhacs, rhv, serverless, service-mesh, staff-eng-approved, telco. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

Details

In response to this:

/label telco
/label need-peer-review

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

abhatt-rh · 2022-12-01T11:19:47Z

/label peer-review-needed

abhatt-rh · 2022-12-01T13:50:45Z

/remove-label peer-review-needed
Removing the label to fix callout numbering. We now have a solution :)

abhatt-rh · 2022-12-01T14:18:34Z

/label peer-review-needed

Wiharris · 2022-12-01T18:43:02Z

/label peer-review-in-progress

Wiharris

/LGTM

Wiharris · 2022-12-01T19:25:26Z

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

abhatt-rh · 2022-12-01T19:29:53Z

/label merge-review-needed

mburke5678 · 2022-12-01T19:59:54Z

/cherrypick enterprise-4.11

openshift-cherrypick-robot · 2022-12-01T20:00:38Z

@mburke5678: new pull request created: #53389

Details

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mburke5678 · 2022-12-01T20:46:31Z

/cherrypick enterprise-4.12

openshift-cherrypick-robot · 2022-12-01T20:47:14Z

@mburke5678: new pull request created: #53396

Details

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 23, 2022

abhatt-rh force-pushed the td-1037 branch from ecb8a67 to 22ce2dc Compare November 24, 2022 13:16

cybertron reviewed Nov 28, 2022

View reviewed changes

abhatt-rh force-pushed the td-1037 branch from 22ce2dc to abfbe1b Compare November 30, 2022 17:38

mrbojangles3 approved these changes Nov 30, 2022

View reviewed changes

cybertron reviewed Nov 30, 2022

View reviewed changes

openshift-ci bot assigned cybertron Nov 30, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2022

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Dec 1, 2022

abhatt-rh changed the title ~~[WIP] TELCODOCS-1037: Add instructions for nmstate network settings~~ TELCODOCS-1037: Add instructions for nmstate network settings Dec 1, 2022

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 1, 2022

openshift-ci bot added the telco Label for all Telco PRs label Dec 1, 2022

openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Dec 1, 2022

openshift-ci bot removed the peer-review-needed Signifies that the peer review team needs to review this PR label Dec 1, 2022

abhatt-rh force-pushed the td-1037 branch from abfbe1b to dafa909 Compare December 1, 2022 14:09

openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 1, 2022

openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Dec 1, 2022

openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Dec 1, 2022

Add instructions for nmstate network settings

c67b78e

abhatt-rh force-pushed the td-1037 branch from dafa909 to c67b78e Compare December 1, 2022 19:01

Wiharris reviewed Dec 1, 2022

View reviewed changes

openshift-ci bot assigned Wiharris Dec 1, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2022

openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Dec 1, 2022

openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Dec 1, 2022

mburke5678 added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Dec 1, 2022

mburke5678 merged commit 19739fa into openshift:main Dec 1, 2022

openshift-cherrypick-robot mentioned this pull request Dec 1, 2022

[enterprise-4.11] TELCODOCS-1037: Add instructions for nmstate network settings #53389

Closed

openshift-cherrypick-robot mentioned this pull request Dec 1, 2022

[enterprise-4.12] TELCODOCS-1037: Add instructions for nmstate network settings #53396

Closed

This was referenced Dec 2, 2022

Add instructions for nmstate network settings #53407

Merged

Add instructions for nmstate network settings #53408

Merged

mburke5678 removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Dec 2, 2022

bergerhoffer added branch/enterprise-4.11 branch/enterprise-4.12 labels Jan 10, 2023

abhatt-rh deleted the td-1037 branch April 11, 2023 12:20

TELCODOCS-1037: Add instructions for nmstate network settings #53122

TELCODOCS-1037: Add instructions for nmstate network settings #53122

Uh oh!

Conversation

abhatt-rh commented Nov 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ocpdocs-previewbot commented Nov 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abhatt-rh commented Nov 24, 2022

Uh oh!

cybertron Nov 28, 2022

Choose a reason for hiding this comment

Uh oh!

mrbojangles3 Nov 28, 2022

Choose a reason for hiding this comment

Uh oh!

abhatt-rh Nov 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cybertron left a comment

Choose a reason for hiding this comment

Uh oh!

abhatt-rh commented Nov 30, 2022

Uh oh!

pamoedom commented Dec 1, 2022

Uh oh!

abhatt-rh commented Dec 1, 2022

Uh oh!

openshift-ci bot commented Dec 1, 2022

Uh oh!

abhatt-rh commented Dec 1, 2022

Uh oh!

abhatt-rh commented Dec 1, 2022

Uh oh!

abhatt-rh commented Dec 1, 2022

Uh oh!

Wiharris commented Dec 1, 2022

Uh oh!

Wiharris left a comment

Choose a reason for hiding this comment

Uh oh!

Wiharris commented Dec 1, 2022

Uh oh!

abhatt-rh commented Dec 1, 2022

Uh oh!

mburke5678 commented Dec 1, 2022

Uh oh!

openshift-cherrypick-robot commented Dec 1, 2022

Uh oh!

mburke5678 commented Dec 1, 2022

Uh oh!

openshift-cherrypick-robot commented Dec 1, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

abhatt-rh commented Nov 23, 2022 •

edited

Loading

ocpdocs-previewbot commented Nov 23, 2022 •

edited

Loading

abhatt-rh Nov 30, 2022 •

edited

Loading