Skip to content

OSDOCS-4745: Installing Nutanix cluster in a restricted env#54259

Merged
mjpytlak merged 1 commit intoopenshift:mainfrom
mjpytlak:osdocs-4745
Feb 20, 2023
Merged

OSDOCS-4745: Installing Nutanix cluster in a restricted env#54259
mjpytlak merged 1 commit intoopenshift:mainfrom
mjpytlak:osdocs-4745

Conversation

@mjpytlak
Copy link
Copy Markdown
Contributor

@mjpytlak mjpytlak commented Jan 5, 2023 •
edited
Loading

Version(s):
4.12+

Issue:
This PR addresses osdocs-4745.

Link to docs preview:
Installing a cluster on Nutanix in a restricted network

A fair amount of the content in this assembly is reused from existing approved Nutanix material. The following preview links are for areas where new content was added in support of a restricted installation:

QE review:

  • QE has approved this change.

@openshift-ci openshift-ci Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 5, 2023
@ocpdocs-previewbot
Copy link
Copy Markdown

ocpdocs-previewbot commented Jan 5, 2023 •
edited
Loading

🤖 Updated build preview is available at:
https://54259--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/8906

@mjpytlak mjpytlak force-pushed the osdocs-4745 branch 8 times, most recently from dadfcb6 to 349ce99 Compare January 5, 2023 22:10
@openshift-ci openshift-ci Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 5, 2023
@mjpytlak mjpytlak force-pushed the osdocs-4745 branch 9 times, most recently from a26a304 to 11ee5e7 Compare January 17, 2023 19:10
@mjpytlak mjpytlak added this to the Continuous Release milestone Jan 17, 2023
@mjpytlak
Copy link
Copy Markdown
Contributor Author

mjpytlak commented Jan 17, 2023

@vnephologist @sgaoshang Draft PR is ready for review. PTAL. Thank you.

@vnephologist
Copy link
Copy Markdown

vnephologist commented Jan 17, 2023 •
edited
Loading

cc: @yannickstruyf3 @wolfganghuse

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 26, 2023
@yannickstruyf3
Copy link
Copy Markdown

yannickstruyf3 commented Jan 27, 2023

LGTM

@mjpytlak
Copy link
Copy Markdown
Contributor Author

mjpytlak commented Jan 31, 2023

@sgaoshang Following up on my request for QE review. PTAL. Thank you in advance.

@sgaoshang
Copy link
Copy Markdown

sgaoshang commented Feb 14, 2023

@mjpytlak restricted installation succeed, /lgtm, thanks.

@mjpytlak mjpytlak added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 14, 2023
@sheriff-rh
Copy link
Copy Markdown
Contributor

sheriff-rh commented Feb 14, 2023

/label peer-review-in-progress
/remove-label peer-review-needed

@openshift-ci openshift-ci Bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 14, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 14, 2023
sheriff-rh
sheriff-rh reviewed Feb 14, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@sheriff-rh sheriff-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, Mike. This is complex work and you've done a great job of keeping it organized. It presents and reads well!

I have two questions in my review.

Comment thread modules/cli-installing-cli.adoc Outdated
Copy link
Copy Markdown
Contributor

@sheriff-rh sheriff-rh Feb 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is intentionally vague, but is there a specific release that works? Can you say oc v1.0+, for example?

Copy link
Copy Markdown
Contributor Author

@mjpytlak mjpytlak Feb 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH. I cannot answer. I do not own this module. I simply reuse it in the context of installation assemblies.

Comment thread modules/registry-configuring-storage-nutanix.adoc Outdated
Copy link
Copy Markdown
Contributor

@sheriff-rh sheriff-rh Feb 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the Nutanix Operator supported by Red Hat? If not, do we need to include a note block stating this?

Copy link
Copy Markdown
Contributor Author

@mjpytlak mjpytlak Feb 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is supported, but must be installed separately post-installation. For the time being the guidance from the team was to simply xref the Nutanix doc.

@sheriff-rh
Copy link
Copy Markdown
Contributor

sheriff-rh commented Feb 14, 2023

/label peer-review-done
/remove-label peer-review-in-progress

@openshift-ci openshift-ci Bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Feb 14, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 14, 2023
@wolfganghuse
Copy link
Copy Markdown

wolfganghuse commented Feb 15, 2023

LGTM

1 similar comment
@yannickstruyf3
Copy link
Copy Markdown

yannickstruyf3 commented Feb 15, 2023

LGTM

@sferich888
Copy link
Copy Markdown
Contributor

sferich888 commented Feb 16, 2023

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2023
makentenza
makentenza approved these changes Feb 20, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@makentenza makentenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjstout
Copy link
Copy Markdown

sjstout commented Feb 20, 2023

LGTM

@mjpytlak mjpytlak merged commit 961028b into openshift:main Feb 20, 2023
@mjpytlak
Copy link
Copy Markdown
Contributor Author

mjpytlak commented Feb 20, 2023

/cherrypick enterprise-4.13

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 20, 2023
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Feb 20, 2023

@mjpytlak: new pull request created: #56129

Details

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mjpytlak
Copy link
Copy Markdown
Contributor Author

mjpytlak commented Feb 20, 2023

/cherrypick enterprise-4.12

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 20, 2023
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Feb 20, 2023

@mjpytlak: new pull request created: #56130

Details

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mjpytlak mjpytlak mentioned this pull request May 15, 2023
Merged
1 task
This was referenced Sep 6, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sheriff-rh sheriff-rh sheriff-rh left review comments

+1 more reviewer

@makentenza makentenza makentenza approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sferich888 sferich888

Labels

branch/enterprise-4.12 branch/enterprise-4.13 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.