Skip to content

OSDCOS-4814: Final AWS Local Zone updates ahead of GA#54727

Merged
kalexand-rh merged 1 commit intoopenshift:mainfrom
mjpytlak:osdocs-4814
Jan 17, 2023
Merged

OSDCOS-4814: Final AWS Local Zone updates ahead of GA#54727
kalexand-rh merged 1 commit intoopenshift:mainfrom
mjpytlak:osdocs-4814

Conversation

@mjpytlak
Copy link
Copy Markdown
Contributor

@mjpytlak mjpytlak commented Jan 16, 2023 •
edited by kalexand-rh
Loading

Version(s):
4.12+

Issue:
This issue addresses osdocs-4814, which addresses the final comments from SME/QE ahead of 4.12 GA.

Link to docs preview:

QE review:

  • QE has approved this change.

@mjpytlak mjpytlak added this to the Planned for 4.12 GA milestone Jan 16, 2023
@openshift-ci openshift-ci Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 16, 2023
@mjpytlak mjpytlak mentioned this pull request Jan 16, 2023
Merged
@ocpdocs-previewbot
Copy link
Copy Markdown

ocpdocs-previewbot commented Jan 16, 2023 •
edited
Loading

🤖 Updated build preview is available at:
https://54727--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/7190

@kalexand-rh
Copy link
Copy Markdown
Contributor

kalexand-rh commented Jan 16, 2023

@mtulio, will you PTAL?

kalexand-rh
kalexand-rh approved these changes Jan 16, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@kalexand-rh kalexand-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kalexand-rh kalexand-rh added the peer-review-done Signifies that the peer review team has reviewed this PR label Jan 16, 2023
@mjpytlak
Copy link
Copy Markdown
Contributor Author

mjpytlak commented Jan 16, 2023 •
edited
Loading

@yunjiang29 Given the nature of these updates, please take one final look.

@kalexand-rh
Copy link
Copy Markdown
Contributor

kalexand-rh commented Jan 16, 2023

If Marco approves these changes, it's exempt from freeze. @yunjiang29, will you please confirm that this addresses your final concerns from #54535?

mtulio
mtulio reviewed Jan 16, 2023
View reviewed changes
Comment thread modules/installation-aws-tested-machine-types.adoc Outdated
Comment on lines 44 to 48
Copy link
Copy Markdown
Contributor

@mtulio mtulio Jan 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yunjiang29 Please take a look into these items, considering my last comment here[1]

[1] #54535 (comment)

Copy link
Copy Markdown
Contributor

@yunjiang29 yunjiang29 Jan 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjpytlak Agree with @mtulio [1], please add m5.2xlarge and c5.2xlarge, other parts LGTM, thanks.

[1] #54535 (comment)

@mtulio
Copy link
Copy Markdown
Contributor

mtulio commented Jan 16, 2023 •
edited
Loading

@kalexand-rh @mjpytlak I just sent a suggestion on #54535 (review) (nit). Overall, LGTM.
I would wait for @yunjiang29 to review the instance types - if we can keep m5.2xlarge. The values added by you (m5, c5d, t3) are desired to cover many locations.

@openshift-ci openshift-ci Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 16, 2023
@mjpytlak
Copy link
Copy Markdown
Contributor Author

mjpytlak commented Jan 16, 2023

@mtulio Picked up your latest suggestion for #54535 (review).

@mtulio
Copy link
Copy Markdown
Contributor

mtulio commented Jan 16, 2023

@mtulio Picked up your latest suggestion for #54535 (review).

LGTM

@bergerhoffer
Copy link
Copy Markdown
Contributor

bergerhoffer commented Jan 16, 2023

The branch/enterprise-4.13 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.12. And any PR going into main must also target the latest version branch (enterprise-4.13).

If the update in your PR does NOT apply to version 4.13 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

@yunjiang29
Copy link
Copy Markdown
Contributor

yunjiang29 commented Jan 17, 2023

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2023
@kalexand-rh kalexand-rh merged commit 6faa68f into openshift:main Jan 17, 2023
@kalexand-rh
Copy link
Copy Markdown
Contributor

kalexand-rh commented Jan 17, 2023

/cherrypick enterprise-4.12

@kalexand-rh
Copy link
Copy Markdown
Contributor

kalexand-rh commented Jan 17, 2023

/cherrypick enterprise-4.13

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 17, 2023
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Jan 17, 2023

@kalexand-rh: new pull request created: #54758

Details

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 17, 2023
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Jan 17, 2023

@kalexand-rh: new pull request created: #54759

Details

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kalexand-rh kalexand-rh kalexand-rh approved these changes

+2 more reviewers

@mtulio mtulio mtulio left review comments

@yunjiang29 yunjiang29 yunjiang29 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@yunjiang29 yunjiang29

Labels

branch/enterprise-4.12 branch/enterprise-4.13 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

7 participants

@mjpytlak @ocpdocs-previewbot @kalexand-rh @mtulio @bergerhoffer @yunjiang29 @openshift-cherrypick-robot